From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Paolo Pisati <paolo.pisati@canonical.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>,
Jian Yang <jianyang@google.com>,
Network Development <netdev@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] selftest: txtimestamp: fix net ns entry logic
Date: Wed, 22 Jul 2020 08:49:47 -0400 [thread overview]
Message-ID: <CA+FuTSc0V4TGMF6KhZVkLfv1=OXXdV+J3ufKuXd0GhrHb2hjbw@mail.gmail.com> (raw)
In-Reply-To: <CAMsH0TTQnPGrXci3WvjM+8sdJdxOjR9MnwFvv4DS6=crMCAt4A@mail.gmail.com>
On Wed, Jul 22, 2020 at 4:37 AM Paolo Pisati <paolo.pisati@canonical.com> wrote:
>
> On Tue, Jul 21, 2020 at 6:26 PM Willem de Bruijn
> <willemdebruijn.kernel@gmail.com> wrote:
> >
> > Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
> >
> > Acked-by: Willem de Bruijn <willemb@google.com>
>
> Besides, is it just me or this test fails frequently? I've been
> running it on 5.4.x, 5.7.x and 5.8-rcX and it often fails:
>
> ...
> USR: 1595405084 s 947366 us (seq=0, len=0)
> SND: 1595405084 s 948686 us (seq=9, len=10) (USR +1319 us)
> ERROR: 6542 us expected between 6000 and 6500
> ACK: 1595405084 s 953908 us (seq=9, len=10) (USR +6541 us)
> USR: 1595405084 s 997979 us (seq=0, len=0)
> SND: 1595405084 s 999101 us (seq=19, len=10) (USR +1121 us)
> ACK: 1595405085 s 4438 us (seq=19, len=10) (USR +6458 us)
> USR: 1595405085 s 49317 us (seq=0, len=0)
> SND: 1595405085 s 50680 us (seq=29, len=10) (USR +1363 us)
> ERROR: 6661 us expected between 6000 and 6500
> ACK: 1595405085 s 55978 us (seq=29, len=10) (USR +6661 us)
> USR: 1595405085 s 101049 us (seq=0, len=0)
> SND: 1595405085 s 102342 us (seq=39, len=10) (USR +1293 us)
> ERROR: 6578 us expected between 6000 and 6500
> ACK: 1595405085 s 107627 us (seq=39, len=10) (USR +6577 us)
> USR-SND: count=4, avg=1274 us, min=1121 us, max=1363 us
> USR-ACK: count=4, avg=6559 us, min=6458 us, max=6661 us
>
>
> In particular, "run_test_v4v6 ${args} # tcp" is the most
> susceptible to failures (though i've seen the udp variant fail too).
Not for me. The interval bounds have been set as is based on previous
experience.
Are you running it inside a VM? Especially qemu without kvm
acceleration could increase jitter.
The reports are not far outside the bounds. They can be extended a bit
if that considerably reduces flakiness.
next prev parent reply other threads:[~2020-07-22 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:52 [PATCH] selftests: txtimestamp: tear down setup() 'tc' and 'ip' env on EXIT Paolo Pisati
2020-07-21 15:04 ` Willem de Bruijn
2020-07-21 16:17 ` [PATCH v2] selftest: txtimestamp: fix net ns entry logic Paolo Pisati
2020-07-21 16:25 ` Willem de Bruijn
2020-07-22 8:37 ` Paolo Pisati
2020-07-22 12:49 ` Willem de Bruijn [this message]
2020-07-21 23:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSc0V4TGMF6KhZVkLfv1=OXXdV+J3ufKuXd0GhrHb2hjbw@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=jianyang@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.pisati@canonical.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).