From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>, Hangbin Liu <liuhangbin@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Tim.Bird@sony.com,
lkft-triage@lists.linaro.org,
Anders Roxell <anders.roxell@linaro.org>,
Justin Cook <justin.cook@linaro.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Extract run_kselftest.sh and generate stand-alone test list
Date: Wed, 30 Sep 2020 21:47:49 +0530 [thread overview]
Message-ID: <CA+G9fYtAWPuL=SEd3=K0WF3xVu6wwx4ETLadASxKKs0dMYbdWQ@mail.gmail.com> (raw)
In-Reply-To: <20200928202650.2530280-1-keescook@chromium.org>
On Tue, 29 Sep 2020 at 01:56, Kees Cook <keescook@chromium.org> wrote:
>
> v2:
> - update documentation
> - include SPDX line in extracted script
> v1: https://lore.kernel.org/linux-kselftest/20200925234527.1885234-1-keescook@chromium.org/
>
>
> Hi!
>
> I really like Hangbin Liu's intent[1] but I think we need to be a little
> more clean about the implementation. This extracts run_kselftest.sh from
> the Makefile so it can actually be changed without embeds, etc. Instead,
> generate the test list into a text file. Everything gets much simpler.
> :)
>
> And in patch 2, I add back Hangbin Liu's new options (with some extra
> added) with knowledge of "collections" (i.e. Makefile TARGETS) and
> subtests. This should work really well with LAVA too, which needs to
> manipulate the lists of tests being run.
>
> Thoughts?
I have tested this patch set on LAVA with full run and it went well.
>
> -Kees
>
> [1] https://lore.kernel.org/lkml/20200914022227.437143-1-liuhangbin@gmail.com/
>
> Kees Cook (3):
> selftests: Extract run_kselftest.sh and generate stand-alone test list
> selftests/run_kselftest.sh: Make each test individually selectable
> doc: dev-tools: kselftest.rst: Update examples and paths
>
> Documentation/dev-tools/kselftest.rst | 35 +++++----
> tools/testing/selftests/Makefile | 26 ++-----
> tools/testing/selftests/lib.mk | 5 +-
> tools/testing/selftests/run_kselftest.sh | 93 ++++++++++++++++++++++++
> 4 files changed, 124 insertions(+), 35 deletions(-)
> create mode 100755 tools/testing/selftests/run_kselftest.sh
>
> --
> 2.25.1
>
- Naresh
next prev parent reply other threads:[~2020-09-30 16:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 20:26 [PATCH v2 0/3] Extract run_kselftest.sh and generate stand-alone test list Kees Cook
2020-09-28 20:26 ` [PATCH v2 1/3] selftests: " Kees Cook
2020-10-01 5:09 ` Naresh Kamboju
2020-09-28 20:26 ` [PATCH v2 2/3] selftests/run_kselftest.sh: Make each test individually selectable Kees Cook
2020-10-01 5:09 ` Naresh Kamboju
2020-10-15 9:27 ` Naresh Kamboju
2020-10-15 21:57 ` Kees Cook
2020-09-28 20:26 ` [PATCH v2 3/3] doc: dev-tools: kselftest.rst: Update examples and paths Kees Cook
2020-10-01 5:13 ` Naresh Kamboju
2020-09-29 1:53 ` [PATCH v2 0/3] Extract run_kselftest.sh and generate stand-alone test list Hangbin Liu
2020-09-30 16:17 ` Naresh Kamboju [this message]
2020-09-30 23:25 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+G9fYtAWPuL=SEd3=K0WF3xVu6wwx4ETLadASxKKs0dMYbdWQ@mail.gmail.com' \
--to=naresh.kamboju@linaro.org \
--cc=Tim.Bird@sony.com \
--cc=anders.roxell@linaro.org \
--cc=corbet@lwn.net \
--cc=justin.cook@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lkft-triage@lists.linaro.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).