From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D9FC6FD18 for ; Tue, 28 Mar 2023 21:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjC1VI4 (ORCPT ); Tue, 28 Mar 2023 17:08:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjC1VIz (ORCPT ); Tue, 28 Mar 2023 17:08:55 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B6391FFF for ; Tue, 28 Mar 2023 14:08:51 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-544787916d9so254487757b3.13 for ; Tue, 28 Mar 2023 14:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680037730; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HjM/ZqYn/T7unhyITZnKsFzK8c16l02nzfEEL176xOU=; b=ocoA87DNTSkmHztT5vnke6BiFUYBXc6/lZxINhcigUkk0S1CcjEXgStw7e9Zp88jv+ i89diJ/hJM1JqzrRRVhBca1mfW48YWKNSscl5VxNxl/D8BuvFLHWAN4JwAYSOtJsAnvU /hLRstVR0H2yntq3lWpDGRwmwcMZGwMsqstB4dAb+RrozEc4vmQ5viXaNAHQbq7tKKtp bsDDdWbOfanraXHIIKTb/3e2+ED5o30OM1egoRKfHSontwTNP2Ocq5mm+XuTmXg9cwR+ 7CfkIF9F9SFfzSbUPIN0ev0xFztzmGXuEfR7BLx+g6u52KVj0QwddYgJTyOOUy8WqtJ7 MRlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680037730; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HjM/ZqYn/T7unhyITZnKsFzK8c16l02nzfEEL176xOU=; b=gFm/VNunuWyTmiTnUONrg+DjF8UEgJC4wcuqXiBQSVUA3J+YUK+BjkXJmI78kUsYeG jMuCH5cp4g8USTGVoggg3MW1U6hmf2CTwrC6LMWBQ+uxILW5orhSmj1mUZanO6w+6vvV H9VMBK+gXLgs0Hy0V0pZJAaMQPuq1GUgXMYj7ZnEqEI8rVrRt5YMtElgUM2PmywNK4gy 81/62hnmHW1mci3sOWK4N2CPyQVOhaUgHHY2LOUWnf1QOFgLRrEGspIUukwpOhzZ8qcD GI6PPQ8Dnibs53uhbjBNg0YHw4YfogA5dlAnAe+l+gXhgudBqPl5UsGkpvxlTwHuvNTR mKCQ== X-Gm-Message-State: AAQBX9dL9hLFrhQ1re+JdnwrdFH7qJETRmovnjdYc2QPLXgdaYqkZlvH r5sFTWzc4ob+KA+O/5AScbmzERvuDkprcDLt5epHxQ== X-Google-Smtp-Source: AKy350ZLcUn0YW0dPW8RrTZpH1OlJLUgV7pk23eKHtHIEBdLUfe+SXlC99rlPRcKPdL9i7z5gyFajqvtscRGyxF3v54= X-Received: by 2002:a81:a908:0:b0:545:7164:49ac with SMTP id g8-20020a81a908000000b00545716449acmr7922856ywh.5.1680037730422; Tue, 28 Mar 2023 14:08:50 -0700 (PDT) MIME-Version: 1.0 References: <20230316225915.494688-1-rmoar@google.com> In-Reply-To: From: Rae Moar Date: Tue, 28 Mar 2023 17:08:38 -0400 Message-ID: Subject: Re: [KTAP V2 PATCH] ktap_v2: add recognized test name line To: Daniel Latypov Cc: frowand.list@gmail.com, davidgow@google.com, skhan@linuxfoundation.org, keescook@chromium.org, Tim.Bird@sony.com, brendanhiggins@google.com, corbet@lwn.net, guillaume.tucker@collabora.com, kernelci@lists.linux.dev, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Mar 20, 2023 at 3:21=E2=80=AFPM 'Daniel Latypov' via KUnit Developm= ent wrote: > > On Thu, Mar 16, 2023 at 3:59=E2=80=AFPM Rae Moar wrote= : > > > > Add recognition of the test name line ("# Subtest: ") to the KTAP= v2 > > spec. > > > > The purpose of this line is to declare the name of a test before its > > results. This functionality is especially useful when trying to parse t= est > > results incrementally and when interpretting results after a crash. > > > > This line is already compliant with KTAP v1 as it is interpretted as a > > minor nit for if there's a v2, s/interprett/interpret (here and above) > Oops. Thanks for catching this. I will change this for a v2. Unsure why I repeated the typo twice. > Also, I want to elaborate on the previous paragraph a bit more, in > case the motivation isn't clear. > The problem with TAP and KTAP as-is is that the name of a test case is > only known *after* it completes. > > So the scenario being referred to is > > KTAP version 1 > 1..1 > > > > It would be nice if parsers could report "test FOO caused a crash" as > opposed to "the first test case caused a crash, good luck figuring out > which one that was" > Yes, this is exactly what I think is the largest benefit of a line to define the test name pre-results. Thanks for expanding. I will likely add in some of this explanation into the commit message for v2. Thanks, Rae > Daniel > > -- > You received this message because you are subscribed to the Google Groups= "KUnit Development" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to kunit-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgi= d/kunit-dev/CAGS_qxp2u3F4abmYgN%2BXwCG8CJN37NSqWSC%3D%3D%3DSWLCjZG8HYBw%40m= ail.gmail.com.