From: Rae Moar <rmoar@google.com>
To: Daniel Latypov <dlatypov@google.com>
Cc: David Gow <davidgow@google.com>,
brendanhiggins@google.com, skhan@linuxfoundation.org,
mauro.chehab@linux.intel.com, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 2/2] kunit: tool: parse KTAP compliant test output
Date: Wed, 16 Nov 2022 17:04:11 -0500 [thread overview]
Message-ID: <CA+GJov7A7OAZh0tPe3-VCw6j-kyQ9Re2rMBvxeZX0JezM=pwVg@mail.gmail.com> (raw)
In-Reply-To: <CAGS_qxpQVWs2RYX_+6FZS8a9-M1GocoMjHNrLBADtkGzxh8mHw@mail.gmail.com>
On Tue, Nov 15, 2022 at 5:02 PM Daniel Latypov <dlatypov@google.com> wrote:
>
> On Tue, Nov 15, 2022 at 12:46 PM Rae Moar <rmoar@google.com> wrote:
> > > - As Daniel mentioned, can we think of a better placeholder name for
> > > tests without Subtest lines? One thought is to just leave it as the
> > > empty string?
> >
> > I am definitely open to changing this placeholder name.
> >
> > The ideas I thought of are: "Test suite", just "Test", or just an
> > empty string. "Test" or empty string may be less confusing. What do
> > people prefer?
>
> I'd prefer the empty string.
>
> So it would show up as something like
> ===== (1 subtests) =====
> [PASSED] case1
> ====== suite1 ======
>
> Note: we'll just have to make sure to avoid a leading space (e.g.
> we're currently doing message += f' (1 subtest)' )
>
> Daniel
This was discussed off the mailing list and seems like there was
agreement that the empty string would be the best. Just wanted to
update here. Will be changing this in v2.
next prev parent reply other threads:[~2022-11-16 22:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 19:47 [PATCH v1 1/2] kunit: improve KTAP compliance of KUnit test output Rae Moar
2022-11-04 19:47 ` [PATCH v1 2/2] kunit: tool: parse KTAP compliant " Rae Moar
2022-11-07 22:58 ` Daniel Latypov
2022-11-15 7:27 ` David Gow
2022-11-15 20:46 ` Rae Moar
2022-11-15 22:02 ` Daniel Latypov
2022-11-16 22:04 ` Rae Moar [this message]
2022-11-07 22:27 ` [PATCH v1 1/2] kunit: improve KTAP compliance of KUnit " Daniel Latypov
2022-11-15 7:27 ` David Gow
2022-11-15 20:18 ` Rae Moar
2022-11-15 22:41 ` Daniel Latypov
2022-11-16 22:30 ` Rae Moar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+GJov7A7OAZh0tPe3-VCw6j-kyQ9Re2rMBvxeZX0JezM=pwVg@mail.gmail.com' \
--to=rmoar@google.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mauro.chehab@linux.intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).