From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE950C432C0 for ; Wed, 4 Dec 2019 00:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1A7520675 for ; Wed, 4 Dec 2019 00:17:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hOm8wz2J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726410AbfLDARp (ORCPT ); Tue, 3 Dec 2019 19:17:45 -0500 Received: from mail-qv1-f66.google.com ([209.85.219.66]:36017 "EHLO mail-qv1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfLDARp (ORCPT ); Tue, 3 Dec 2019 19:17:45 -0500 Received: by mail-qv1-f66.google.com with SMTP id b18so2389342qvy.3 for ; Tue, 03 Dec 2019 16:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QTyx2RZy7Y05cTkQC5l7sD6FLwz4Qd0lQ0nPf0EZIKQ=; b=hOm8wz2JV5irNU26ecry779uLa4TiPhyZ1ZbH5BMAy/dmu7zOGoJWBAfrrXnkZ4bAI i3S1GGj7B/bD+yuiGyVGBFPy0Scho66AEJzGF0Uz9gjhbCR20aK8/aD754sz5fHdycGk ElbXXiBdPnpI5fmy7qTAqyOnxSjMyNU8gh6CG/lsf7crB4HjGgbZ4aTmvdRq56HBEao6 WiFWriZ/V4caGH9ZsSaK2SudOmSHCEnweMh/Rr4ecE0DCuWpEBcp59cbvpDBglqRURAu 55Rp+JxFnBZW3Y6c9elMR3Ps13iJiRCX7Pcp+gToSKg/XaWp2AXLH4rYaqVePA8HVcGI Is1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QTyx2RZy7Y05cTkQC5l7sD6FLwz4Qd0lQ0nPf0EZIKQ=; b=UF/9Zsez6Ara6iPjcP2Ta8b/KzWOTY4BBUEVIiNJj0+BT9ncBo0liVfZdig+qnBBt0 hrfUTqubyiZtaUNxF05F/ehFOotfjfHT0p//6sfMdxvyKfAJj1sa0IfTO0AitVFLio04 AokOJ5Lc6leI9noJJzumzwiVE0Es1DKOuX1H5KJgyN6qs45QNzcybEhxGqXQhJLxlp7T RySR7tncvj7P9XH+wvEjBYpIuSXH3pUe7eq2t3HkjVYI1M+jqUaq2l7g0IXT0PuO7zwl VVXIHKy7XiufXziwUGdCLlnrrqPi/ae3iz21mp4BY37yckghV1dmXk0ILWTmup2frXCa dvBw== X-Gm-Message-State: APjAAAUS9aA/KfBP1uTFcq6Xy6WMmwoYqPH1uEtGxoYSiXwxn17IEDhc TYwJHqmGHJewOnfu7KOsoJwKdSdcDe2nuZ2GpA+w X-Google-Smtp-Source: APXvYqyz1zLOAzlEW9SR6UXDydhWZrLGVzqeOyJQaU/XEZFykJigtOH++7UD8tHeCTXXoGftLWGr/Iw5KbggfuWAdmA= X-Received: by 2002:a0c:8061:: with SMTP id 88mr411290qva.62.1575418664089; Tue, 03 Dec 2019 16:17:44 -0800 (PST) MIME-Version: 1.0 References: <1575374868-32601-1-git-send-email-alan.maguire@oracle.com> <1575374868-32601-4-git-send-email-alan.maguire@oracle.com> In-Reply-To: <1575374868-32601-4-git-send-email-alan.maguire@oracle.com> From: Iurii Zaikin Date: Tue, 3 Dec 2019 16:17:07 -0800 Message-ID: Subject: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module To: Alan Maguire Cc: Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , KUnit Development , Kees Cook , akpm@linux-foundation.org, Masahiro Yamada , catalin.marinas@arm.com, joe.lawrence@redhat.com, penguin-kernel@i-love.sakura.ne.jp, urezki@gmail.com, andriy.shevchenko@linux.intel.com, corbet@lwn.net, David Gow , adilger.kernel@dilger.ca, "Theodore Ts'o" , Luis Chamberlain , "open list:DOCUMENTATION" , Knut Omang Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org > +ifeq ($(CONFIG_EXT4_KUNIT_TESTS),y) > ext4-$(CONFIG_EXT4_KUNIT_TESTS) += inode-test.o > +else > +obj-$(CONFIG_EXT4_KUNIT_TESTS) += ext4-inode-test.o > +ext4-inode-test-objs += inode-test.o > +endif Why not rename it unconditionally?