From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01955C433EF for ; Sat, 23 Jul 2022 06:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231246AbiGWGdl (ORCPT ); Sat, 23 Jul 2022 02:33:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbiGWGdk (ORCPT ); Sat, 23 Jul 2022 02:33:40 -0400 Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E225851A09 for ; Fri, 22 Jul 2022 23:33:35 -0700 (PDT) Received: by mail-vk1-xa35.google.com with SMTP id b81so2918518vkf.1 for ; Fri, 22 Jul 2022 23:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BfpIOV/6ZvhwkFNNi8F5n6UGeETzcQ0Ic7VQTjCcaxA=; b=T8THoq6U5rrJ6eOYnptWyaffD33E8b6arT8i7Fvu3PMM8WjwopfPP7FK1MCR60/LUT 60AtWKe+av+lrxVtHbOkq/NrgxArG9NWpVkOG5aeXSb6XMu6rClL+ux9fBwdxEbNhuqm XUNCmj12Ktce3ApVxwtETXUylNRuzEhZOswTa6YdbyZOHYH78pzWpJWwlf5NQCQNNidK xBojGlWIXKPodPmAwsuVy87Ad/RTWLR9YR08ZcqELX6Hkj5d1MPhq3h/wkOGSXAA75A7 cKeoulaRK+6zV4LFnZuO8ZT9RO38M+MBT9hsYhy5WuNHt8vmJ1ZMjH8RCUG7OjKAvB2x nUmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BfpIOV/6ZvhwkFNNi8F5n6UGeETzcQ0Ic7VQTjCcaxA=; b=S+bZ+K1MFiO5ZnLa9S6ijfmVpIPmxsa6850RJ6UefIJ/SIysGIUrvlXJ9cM3TepvQV KhSImB5BotjKIz45deajSoNCXtCyZ0AIrc4kspNex8yCvzuMJM2qeeM7Dvs7J72/kzdB E1pDEkwtA8PJR4r2ACSNbWRZLbzoaC4Ug1Y0tRBefKlylDSc631q22teeQLuUJPtg6Qv MBttMt48SVepCbQWh9m0dJ3dF7o31xsInv+TQnKG+SsaVcGMC2KKtwPsjdt9/mgZHWNM ocuVMfndws0gTHtseaB7m2oMWuN4xQrpPSf+LPDiSyjRgUcKI6o42ZkdC9LHRNyRunPH jBGw== X-Gm-Message-State: AJIora+yYiMIUNjRye4QIx/QnzQz2P8IQk6JDSQI32Sor0tYJV2kb4yY WJ8yai8Jb6D5UXcWyMZFvbZYo68vsmBpsA16jERltg== X-Google-Smtp-Source: AGRyM1tRd8CzElUHBeDtzmGnV1yUfi7c8RHRAmVBCaCVgIsof/b/Ob6GDs1QKgyF8YI4pAW5kXGdCY+RBq7EcApefuw= X-Received: by 2002:a1f:bf54:0:b0:375:fdf2:e014 with SMTP id p81-20020a1fbf54000000b00375fdf2e014mr938673vkf.4.1658558014485; Fri, 22 Jul 2022 23:33:34 -0700 (PDT) MIME-Version: 1.0 References: <20220722171534.3576419-1-dlatypov@google.com> <20220722171534.3576419-5-dlatypov@google.com> In-Reply-To: <20220722171534.3576419-5-dlatypov@google.com> From: David Gow Date: Sat, 23 Jul 2022 14:33:23 +0800 Message-ID: Subject: Re: [PATCH v2 5/5] kunit: make kunit_kfree(NULL) a no-op to match kfree() To: Daniel Latypov Cc: Brendan Higgins , Linux Kernel Mailing List , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Sat, Jul 23, 2022 at 1:15 AM Daniel Latypov wrote: > > The real kfree() function will silently return when given a NULL. > So a user might reasonably think they can write the following code: > char *buffer = NULL; > if (param->use_buffer) buffer = kunit_kzalloc(test, 10, GFP_KERNEL); > ... > kunit_kfree(test, buffer); > > As-is, kunit_kfree() will mark the test as FAILED when buffer is NULL. > (And in earlier times, it would segfault). > > Let's match the semantics of kfree(). > > Suggested-by: David Gow > Signed-off-by: Daniel Latypov > --- > v1 -> v2: add this patch to the series. > --- Thanks! This looks good to me, and worked with a basic test. Reviewed-by: David Gow Cheers, -- David > lib/kunit/test.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/kunit/test.c b/lib/kunit/test.c > index c7ca87484968..879c8db36cb5 100644 > --- a/lib/kunit/test.c > +++ b/lib/kunit/test.c > @@ -698,6 +698,9 @@ static inline bool kunit_kfree_match(struct kunit *test, > > void kunit_kfree(struct kunit *test, const void *ptr) > { > + if (!ptr) > + return; > + > if (kunit_destroy_resource(test, kunit_kfree_match, (void *)ptr)) > KUNIT_FAIL(test, "kunit_kfree: %px already freed or not allocated by kunit", ptr); > } > -- > 2.37.1.359.gd136c6c3e2-goog >