From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509F9C433E7 for ; Fri, 16 Oct 2020 05:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEE2420897 for ; Fri, 16 Oct 2020 05:02:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GEeBGO4f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726500AbgJPFCd (ORCPT ); Fri, 16 Oct 2020 01:02:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726334AbgJPFCd (ORCPT ); Fri, 16 Oct 2020 01:02:33 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 194F2C061755 for ; Thu, 15 Oct 2020 22:02:33 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h5so1200938wrv.7 for ; Thu, 15 Oct 2020 22:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9Yg0zO3FoxdCiBdS6sRMMUbHRX5WgeqbMnpmtbAHEtQ=; b=GEeBGO4f+taAcEMQQ85DrncdlK2dJYmUGukW3HAHhZBdrOkDjxt5tNi1JOXg1XnGWR 4p76T9a4fvq1bG1EgUkAVB6bhb7D7tGU+znT+jwNXlwtHY7Z0Ohf9+qM56++eyetvfDu grwxqYQIRvJb/JIn9gloYT4WRi/NaT8ccRQeAx2E88V3swm5f5xr8F5w/Ag4oT8WgCw8 NSvwE24g/XTD8sPFbcD0d4KvtofX3R3/n9lRp5BCJw+fcS2f5HBycmb5jR+Gfc+LkWI+ XaGqoAdFqeSr7pgVBjwSY56seUa/tRmkvFlRA8pXkBttqnZQ2je0R8uZnlvRNn58XNE/ WEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9Yg0zO3FoxdCiBdS6sRMMUbHRX5WgeqbMnpmtbAHEtQ=; b=Oqg62/3a6rzI3wopFTnZrUemOiVFghInS49dvF1GKZOhTOYM9Cwb61330GbSeGbZzp GIW4E40F44NYusk6zc8EFCEbhnddaNCMYrUdpIro+ileSFfq0k81dWbV6kxeaoFpL8C9 gzMqnhmdqpwF08LCuIbxtg63vVU36q8P/g7YozM/ldd6A6bTgKvZECGpIJtjxJP7InSZ VDOi7FKrO+QRgO3Pc1AGZ7IfHqZQZR8m4Hnc01otH36fNhBrLV49J17FOHgMt9XImjKx UdEWFfDiXHIo6thLbx7ztzMKkoVvitCXyBhjcoWxF/B6PHm3nwZ+oL/wpfI+qbvMxXCG iD5w== X-Gm-Message-State: AOAM531KNq10yurAnHNtdGjJZ3lvJdZv1/64Ls/uayKLcFWDTjSxBWgk sCVsRav+Jz5IOZThJgc7AL/KaQIo5UrUqSOXo7TvOZ1Gmv4m5+XP X-Google-Smtp-Source: ABdhPJzPjULLgz9fVF55L6zu/UOw6zghst6/dARkEUWSlP5XW+bhkvBDtcSB4ovV1xVcS1S1m6m5vy8UffbETM9v+Vw= X-Received: by 2002:adf:fb0d:: with SMTP id c13mr1666040wrr.19.1602824551669; Thu, 15 Oct 2020 22:02:31 -0700 (PDT) MIME-Version: 1.0 References: <20201015184416.38999-1-andriy.shevchenko@linux.intel.com> <20201015184416.38999-2-andriy.shevchenko@linux.intel.com> In-Reply-To: <20201015184416.38999-2-andriy.shevchenko@linux.intel.com> From: David Gow Date: Fri, 16 Oct 2020 13:02:20 +0800 Message-ID: Subject: Re: [PATCH v2 2/3] lib/linear_ranges_kunit: Follow new file name convention for KUnit tests To: Andy Shevchenko Cc: "open list:KERNEL SELFTEST FRAMEWORK" , Brendan Higgins , KUnit Development , Shuah Khan , Mark Brown , Matti Vaittinen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko wrote: > > Follow new file name convention for the KUnit tests. > Since we have lib/*test*.c in a few variations, > use 'kunit' suffix to distinguish usual test cases > with KUnit-based ones. > > Cc: Mark Brown > Cc: Matti Vaittinen > Signed-off-by: Andy Shevchenko Thanks. This looks good to me from an "I tested it and it worked" and a "matches the naming guidelines" point of view. (Since the naming documentation isn't actually in Linus' branch yet, I'll drop a link to it here: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/Documentation/dev-tools/kunit/style.rst?h=kunit ) I'm not the test author though, and the naming doc does explicitly leave the possibility of keeping the old filenames for tests if there's a particularly good reason to (e.g., a lot depending on the module name). I'm not aware of any such thing, and so am in favour of the rename, but will defer to the test authors on that point if they object. Either way, Reviewed-by: David Gow Cheers, -- David