From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB583C433FE for ; Sat, 1 Oct 2022 04:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbiJAENv (ORCPT ); Sat, 1 Oct 2022 00:13:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiJAENt (ORCPT ); Sat, 1 Oct 2022 00:13:49 -0400 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26E6815C1C6 for ; Fri, 30 Sep 2022 21:13:48 -0700 (PDT) Received: by mail-vs1-xe33.google.com with SMTP id m65so6693375vsc.1 for ; Fri, 30 Sep 2022 21:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=r+2onGGckPBtWdzBdr7CAeHAIcFU/jinFV0BuS55hiE=; b=KE9p5EF4GPKbSjJ3Xvz00HPCqMUU1H8H+bvXEn8yQJlHJVQ7Mw5kRtcyEoXJkCd/Fn WZMYxd0PUKiixM2JrbNX9vWSOBIv91VwgS9oZRFkuXs0/8GiBlqwSiyEOCBPv5vAuySb mt9w2EnTBw4myBNZPsktCuKkGR122UjAtE1ZWnBk7WYdfxZbDH/dwZVM1I7qfiRF2+nQ 94JJ8AJqNLNb4iatSQwd+mLohXxRL9r4JlkT2QaMZFbKek42Ull4Rs1q5VMVYhC8xFH0 FvnkLN1h1D5MH0RBTvU53pjEViSdfwbmdiaPHKDWjwMTi5uWXnKKGmjZseyllmaE4AwL eByA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=r+2onGGckPBtWdzBdr7CAeHAIcFU/jinFV0BuS55hiE=; b=WZgXjIzN7XtKAOUI8IRXyJt7zSBHqr+a+dkx//OWErjedGzYBjWig6dyEOcqqVKfjg wj5WGZRmDTS0JX/2R+dO2VlO54bYUn+hPri0xXRQh8TuK7YZDm2FQoPXF75Dnv7yzrSe gagXN8zUd37rsnVQfMgb5x0iyP+eFd0X9Ttt5vhEigsOI7vIUO9kavW+UNjZErapLc0i Ynqa++beITY9/KXNCbpq2PxIKz5jcWHylutWi70fAPPAOkeej11LhHl9/yEQWRCN/n/g yHlXApG0r50hP/QMMZh3AzEOayonojflxYlA+0Lt+i1lJk6HcT/2Cnc9vB6NmbPAeDR/ 96dQ== X-Gm-Message-State: ACrzQf0lzu7lYtXbJa9rkurj6GnB6TNmNiOu/aBnUyU+Ae62DsIC2uUV bvzucLPYXFfh8xboiqyRvDVNpQ0a34R2ZLHIIN2iWQ== X-Google-Smtp-Source: AMsMyM5ApvVl++SKO3Vz8lEhweFNfC9tMnRsUoEYiO3XkQKJjJBf+tyatFml0jry6l9ftZ0Gj7soeQDQMs4Q//1FrD8= X-Received: by 2002:a67:d908:0:b0:3a6:4768:bc3 with SMTP id t8-20020a67d908000000b003a647680bc3mr24652vsj.38.1664597627036; Fri, 30 Sep 2022 21:13:47 -0700 (PDT) MIME-Version: 1.0 References: <20221001002638.2881842-1-dlatypov@google.com> <20221001002638.2881842-3-dlatypov@google.com> In-Reply-To: From: David Gow Date: Sat, 1 Oct 2022 12:13:35 +0800 Message-ID: Subject: Re: [PATCH 2/4] kunit: rename base KUNIT_ASSERTION macro to _KUNIT_FAILED To: Daniel Latypov Cc: Brendan Higgins , Linux Kernel Mailing List , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Miguel Ojeda Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000044c17205e9f15616" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org --00000000000044c17205e9f15616 Content-Type: text/plain; charset="UTF-8" On Sat, Oct 1, 2022 at 11:50 AM 'Daniel Latypov' via KUnit Development wrote: > > On Fri, Sep 30, 2022 at 8:26 PM David Gow wrote: > > > > On Sat, Oct 1, 2022 at 8:26 AM 'Daniel Latypov' via KUnit Development > > wrote: > > > > > > Context: > > > Currently this macro's name, KUNIT_ASSERTION conflicts with the name of > > > an enum whose values are {KUNIT_EXPECTATION, KUNIT_ASSERTION}. > > > > > > It's hard to think of a better name for the enum, so rename this macro. > > > It's also a bit strange that the macro might do nothing depending on the > > > boolean argument `pass`. Why not have callers check themselves? > > > > > > This patch: > > > Moves the pass/fail checking into the callers of KUNIT_ASSERTION, so now > > > we only call it when the check has failed. > > > Then we rename the macro the _KUNIT_FAILED() to reflect the new > > > semantics. > > > > > > Signed-off-by: Daniel Latypov > > > --- > > > > Looks good to me. I can't say the name _KUNIT_FAILED() feels perfect > > to me, but I can't think of anything better, either. We've not used a > > leading underscore for internal macros much thus far, as well, though > > I've no personal objections to starting. > > Yeah, I also didn't add a leading underscore on the new > KUNIT_INIT_ASSERT() macro elsewhere in this series. > So I'm not necessarily proposing that we should start doing so here. Yeah: I noticed that. In general, I think I come down slightly on the side of avoiding leading underscores. (And there's also the debate about whether to have one or two, as while two underscores is nominally "reserved for the system", the kernel uses it a lot -- probably because it considers itself "the system"). So I'd tend to lean away from making all of our "internal" macros start with underscores. > > It feels like that KUNIT_FAILED is far too similar to the enum > 55 enum kunit_status { > 56 KUNIT_SUCCESS, > 57 KUNIT_FAILURE, > 58 KUNIT_SKIPPED, > 59 }; > > I.e. we'd be remove one naming conflict between a macro and enum, but > basically introducing a new one in its place :P > Tbh, I was originally going to have this patch just be > s/KUNIT_ASSERTION()/_KUNIT_ASSERTION() to reduce the conflict. > But I figured we could reduce the number of arguments to the macro > (drop `pass`) and have a reason to give it a different name. > > I'm also not entirely convinced about _KUNIT_FAILED(), but I haven't > had any significantly better ideas since I sent the RFC in May. Agreed: particularly since SKIPPED would seem to pair better with FAILED than FAILURE, so they conflict quite a bit. Let's stick with what we have in this change, and we can change it later if someone comes up with a drastically better name. Cheers, -- David --00000000000044c17205e9f15616 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPnwYJKoZIhvcNAQcCoIIPkDCCD4wCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz5MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNgwggPAoAMCAQICEAGH0uAg+eV8wUdHQOJ7 yfswDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMjA2MjAw MjAzNTNaFw0yMjEyMTcwMjAzNTNaMCQxIjAgBgkqhkiG9w0BCQEWE2RhdmlkZ293QGdvb2dsZS5j b20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCv9aO5pJtu5ZPHSb99iASzp2mcnJtk JIh8xsJ+fNj9OOm0B7Rbg2l0+F4c19b1DyIzz/DHXIX9Gc55kfd4TBzhITOJmB+WdbaWS8Lnr9gu SVO8OISymO6uVA0Lmkfne3zV0TwRtFkEeff0+P+MqdaLutOmOcLQRp8eAzb/TNKToSROBYmBRcuA hDOMCVZZozIJ7T4nHBjfOrR+nJ4mjBIDRnDucs4dazypyiYiHYLfedCxp8vldywHMsTxl59Ue9Yk RVewDw3HWvWUIMbc+Y636UXdUn4axP1TXN0khUpexMoc5qCHxpBIE/AyeS4WPASlE8uVY9Qg8dT6 kJmeOT+ZAgMBAAGjggHUMIIB0DAeBgNVHREEFzAVgRNkYXZpZGdvd0Bnb29nbGUuY29tMA4GA1Ud DwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDBAYIKwYBBQUHAwIwHQYDVR0OBBYEFDyAvtuc z/tQRXr3iPeVmZCr7nttMEwGA1UdIARFMEMwQQYJKwYBBAGgMgEoMDQwMgYIKwYBBQUHAgEWJmh0 dHBzOi8vd3d3Lmdsb2JhbHNpZ24uY29tL3JlcG9zaXRvcnkvMAwGA1UdEwEB/wQCMAAwgZoGCCsG AQUFBwEBBIGNMIGKMD4GCCsGAQUFBzABhjJodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9jYS9n c2F0bGFzcjNzbWltZWNhMjAyMDBIBggrBgEFBQcwAoY8aHR0cDovL3NlY3VyZS5nbG9iYWxzaWdu LmNvbS9jYWNlcnQvZ3NhdGxhc3Izc21pbWVjYTIwMjAuY3J0MB8GA1UdIwQYMBaAFHzMCmjXouse LHIb0c1dlW+N+/JjMEYGA1UdHwQ/MD0wO6A5oDeGNWh0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20v Y2EvZ3NhdGxhc3Izc21pbWVjYTIwMjAuY3JsMA0GCSqGSIb3DQEBCwUAA4IBAQAx+EQjLATc/sze VoZkH7OLz+/no1+y31x4BQ3wjW7lKfay9DAAVym896b7ECttSo95GEvS7pYMikzud57WypK7Bjpi ep8YLarLRDrvyyvBuYtyDrIewkuASHtV1oy5E6QZZe2VOxMm6e2oJnFFjbflot4A08D3SwqDwV0i OOYwT0BUtHYR/3903Dmdx5Alq+NDvUHDjozgo0f6oIkwDXT3yBV36utQ/jFisd36C8RD5mM+NFpu 3aqLXARRbKtxw29ErCwulof2dcAonG7cd5j+gmS84sLhKU+BhL1OQVXnJ5tj7xZ5Ri5I23brcwk0 lk/gWqfgs3ppT9Xk7zVit9q8MYICajCCAmYCAQEwaDBUMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQ R2xvYmFsU2lnbiBudi1zYTEqMCgGA1UEAxMhR2xvYmFsU2lnbiBBdGxhcyBSMyBTTUlNRSBDQSAy MDIwAhABh9LgIPnlfMFHR0Die8n7MA0GCWCGSAFlAwQCAQUAoIHUMC8GCSqGSIb3DQEJBDEiBCCU RVhFZMl1+l4Il8Ys6VgFEBnrQ0pPeZo+RIzDD+YGNDAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcB MBwGCSqGSIb3DQEJBTEPFw0yMjEwMDEwNDEzNDdaMGkGCSqGSIb3DQEJDzFcMFowCwYJYIZIAWUD BAEqMAsGCWCGSAFlAwQBFjALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwCwYJKoZIhvcNAQEKMAsG CSqGSIb3DQEBBzALBglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEggEAULwLDIwSE4PtSNkObffD V9G2KlSRVu50PNa66nXSusjLlsqcVXY/1+WP8DnSPSJ7nZBGPGDmRLAusEoS0tluIPPr7f9HO4Np 9mv4XVmS27UTvXcWKIGaL187ST4W7xVSgfQZPVxGAs5pT84aVxbwb6u1A1eupQKgscocGVQz8Vce h5k6f2eRJBof0/rxFpEzL7h6Bl8DuFpZywmoB9YvcxRT5zvD/AiXxczH1YGHmgocO4Vv4JUxceMW gK2HiGqCXDjKHHQd/uh+gWqu8IWcrPtIpMKaxBVqWk36IfmS1QGkZZKiGc3WAFIglVCsEgpVBVWF 7F0mE0pYQv93NP9kpQ== --00000000000044c17205e9f15616--