linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Gow <davidgow@google.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	KUnit Development <kunit-dev@googlegroups.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 3/3] lib/bits_kunit: Follow new file name convention for KUnit tests
Date: Fri, 16 Oct 2020 13:07:05 +0800	[thread overview]
Message-ID: <CABVgOSmxjoNjjn+a0i6Fwyw6hewJNH-dwximK2Fv-nYTDRhLNg@mail.gmail.com> (raw)
In-Reply-To: <20201015184416.38999-3-andriy.shevchenko@linux.intel.com>

On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


Again, this worked and looks good to me. Apart from noting that the
module name will change (so if people are depending on that, it'll
break things), I'm all in favour of this.

For the record (since it's not quite upstream yet), the naming
documentation referenced is currently available here:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/Documentation/dev-tools/kunit/style.rst?h=kunit

Anyway,
Reviewed-by: David Gow <davidgow@google.com>

Thanks,
-- David

  reply	other threads:[~2020-10-16  5:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 18:44 [PATCH v2 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
2020-10-15 18:44 ` [PATCH v2 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
2020-10-16  5:02   ` David Gow
2020-10-16  9:29     ` Andy Shevchenko
2020-10-17  6:57       ` David Gow
2020-10-16 10:38   ` Mark Brown
2020-10-16 11:03     ` Andy Shevchenko
2020-10-16 11:10       ` Andy Shevchenko
2020-10-16 11:12       ` Mark Brown
2020-10-15 18:44 ` [PATCH v2 3/3] lib/bits_kunit: " Andy Shevchenko
2020-10-16  5:07   ` David Gow [this message]
2020-10-16  4:53 ` [PATCH v2 1/3] lib/list_kunit: " David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABVgOSmxjoNjjn+a0i6Fwyw6hewJNH-dwximK2Fv-nYTDRhLNg@mail.gmail.com \
    --to=davidgow@google.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brendanhiggins@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).