Re: [PATCH v1 1/1] .gitignore: Unignore .kunitconfig

From: David Gow <davidgow@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [PATCH v1 1/1] .gitignore: Unignore .kunitconfig
Date: Tue, 31 Jan 2023 08:00:40 +0800	[thread overview]
Message-ID: <CABVgOSnRC3AuUo4Qc2K3pXEcj3Wbt9LE2DTbejGrPOCKefxB2g@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNASsnDymUS=Pyo77g=0v58fMn38PY66A887nC8_E6_qXAg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2014 bytes --]

On Sat, 28 Jan 2023 at 22:37, Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Sat, Jan 28, 2023 at 3:56 PM David Gow <davidgow@google.com> wrote:
> >
> > On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > There are almost dozen of .kunitconfig files that are ignored but
> > > tracked. Unignore them.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> >
> > Thanks! Only the original root-directory .kunitignore file was
> > intended to be ignored, and that's no longer as important, and is now
> > in the build dir anyway.
> >
> > Reviewed-by: David Gow <davidgow@google.com>
> >
> > Cheers,
> > -- David
> >
> > >  .gitignore | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/.gitignore b/.gitignore
> > > index 22984d22d29e..e4f2ba0be516 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -100,6 +100,7 @@ modules.order
> > >  !.get_maintainer.ignore
> > >  !.gitattributes
> > >  !.gitignore
> > > +!.kunitconfig
> > >  !.mailmap
> > >  !.rustfmt.toml
> > >
> > > --
> > > 2.39.0
> > >
>
>
> Why is this a dot file in the first place?
>

In short, historical reasons.

The long answer is that there are two places "kunitconfig" files are
used: as a user-provided file with their preferred test config (which
is kept local), and as a recommended test config for a given subsystem
(which is checked in).
Originally, no .kunitconfig files were checked in: one was either
autogenerated or manually modified and left in the root source
directory. This eventually moved into the build directory, and a
number of features which de-emphasized it in favour of command-line
arguments and the (new) checked-in per-subsystem configs, which
probably shouldn't be hidden.

There's no fundamental reason (other than it being a bit annoying to
rename everything and update the code) we can't change it, either for
all kunitconfig files, or just the checked-in ones, if that's
preferred.

-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]