From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-28.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D82C2B9F4 for ; Fri, 25 Jun 2021 04:08:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9857261400 for ; Fri, 25 Jun 2021 04:08:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbhFYEKg (ORCPT ); Fri, 25 Jun 2021 00:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbhFYEKg (ORCPT ); Fri, 25 Jun 2021 00:10:36 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C26EC061756 for ; Thu, 24 Jun 2021 21:08:15 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id j2so9011437wrs.12 for ; Thu, 24 Jun 2021 21:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wtb2ef1+Onk4FkYj1WTTNjN9qcUMzBKmdDiK41PBwCo=; b=P5ZQzzEtVw32Z7+DdWiYMF9W3ByIMIzM/WNQjjiNvFtNfBECqKgHgrKsuB77VF+vQm KrrG+5fMzjNHLvVs54Hi6R2MLmoky8ex8xOYcUT30gFcc999JVt+iKCFgwGlw3ptwQWV 6wSFWfBP7ycBNvDZmhfN8CekUAVsf2SVHGiCu19QcRQGIbpFgL/Ml4ZdwFb8W7nugqnw UIQ/MfwBwmNQGZfdluQeCWzG+OvybfssXsvWT8TXIJsaJXI2xaq90uW/ww1OufxTmDRs KUYEUevD3JrB341dc4U6AuxtN6SSavtiOZxfnAiV3GK5w6aYTI0Vb/qr7ihGSKjRR03O OrGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wtb2ef1+Onk4FkYj1WTTNjN9qcUMzBKmdDiK41PBwCo=; b=m6Z+8mJmCgB3nhAOC6f4se+tiHI6NabaBUUmpfhc3Qquux2bjDIcyBd1qXL4KClRGJ r7F5TkK2R48FEaQi5xvqMpgbXYKxpXPHXOPbE6EfKvwcltnC8ckO73J4a0q+xrDl1kly TzLceW2WsRQ/F3avVd6q0MOj/N+jFHe/QREtL8u/fak6jIgeIBpu/276Q7VRHfcCzpRW vRzsGEbvsZBDfSqwRHH1YFv/lkdmOQG7/qzOh1XjGPkKDUeJ57STJpJD+4tExjycnpOk mYsTH+s6UHm5BP3nUfOGmfZsrL4qdo78gBKH+57lNkopoMKBfxgOuhUO+b+4mWb2Xn+n KpMw== X-Gm-Message-State: AOAM533h519LrBCEXHsugetK0xfZkzuAiN6Fs4L1SlQycSTCSzRDz6p9 m/cfMsiyFkK2+05uFoiw9uapR62gm0XBgVLq2RKGlA== X-Google-Smtp-Source: ABdhPJxcx1eoU3WmQgAS+epQWrUgX6YHSAX3v4EPioVlfbNsRX//a6JQn2GwTJ0l0p4S+IhH3g+VKja3Yh2iuD8ZFak= X-Received: by 2002:a5d:480e:: with SMTP id l14mr8651762wrq.33.1624594093763; Thu, 24 Jun 2021 21:08:13 -0700 (PDT) MIME-Version: 1.0 References: <20210623201721.980348-1-dlatypov@google.com> In-Reply-To: <20210623201721.980348-1-dlatypov@google.com> From: David Gow Date: Fri, 25 Jun 2021 12:08:02 +0800 Message-ID: Subject: Re: [PATCH] Documentation: kunit: drop obsolete note about uml_abort for coverage To: Daniel Latypov Cc: Brendan Higgins , Linux Kernel Mailing List , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Jun 24, 2021 at 4:17 AM Daniel Latypov wrote: > > Commit b6d5799b0b58 ("kunit: Add 'kunit_shutdown' option") changes KUnit > to call kernel_halt() by default when done testing. > > This fixes the issue with not having .gcda files due to not calling > atexit() handlers, and therefore we can stop recommending people > manually tweak UML code. > > The need to use older versions of GCC (<=6) remains however, due to > linktime issues, same as before. Note: There also might still be issues > with .gcda files as well in newer versions. > > Signed-off-by: Daniel Latypov > --- This looks good to me, thanks! Now if only we could fix the issues with newer gcc versions... Reviewed-by: David Gow -- David > Documentation/dev-tools/kunit/running_tips.rst | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst > index 7d99386cf94a..d1626d548fa5 100644 > --- a/Documentation/dev-tools/kunit/running_tips.rst > +++ b/Documentation/dev-tools/kunit/running_tips.rst > @@ -86,19 +86,7 @@ Generating code coverage reports under UML > .. note:: > TODO(brendanhiggins@google.com): There are various issues with UML and > versions of gcc 7 and up. You're likely to run into missing ``.gcda`` > - files or compile errors. We know one `faulty GCC commit > - `_ > - but not how we'd go about getting this fixed. The compile errors still > - need some investigation. > - > -.. note:: > - TODO(brendanhiggins@google.com): for recent versions of Linux > - (5.10-5.12, maybe earlier), there's a bug with gcov counters not being > - flushed in UML. This translates to very low (<1%) reported coverage. This is > - related to the above issue and can be worked around by replacing the > - one call to ``uml_abort()`` (it's in ``os_dump_core()``) with a plain > - ``exit()``. > - > + files or compile errors. > > This is different from the "normal" way of getting coverage information that is > documented in Documentation/dev-tools/gcov.rst. > > base-commit: 87c9c16317882dd6dbbc07e349bc3223e14f3244 > -- > 2.32.0.93.g670b81a890-goog >