From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43AE1C433F5 for ; Tue, 19 Oct 2021 21:49:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 264DA6134F for ; Tue, 19 Oct 2021 21:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbhJSVv1 (ORCPT ); Tue, 19 Oct 2021 17:51:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhJSVv1 (ORCPT ); Tue, 19 Oct 2021 17:51:27 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 284EBC061746 for ; Tue, 19 Oct 2021 14:49:14 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id s136so17394423pgs.4 for ; Tue, 19 Oct 2021 14:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OiAYKXU6LKvLzjanHYWWmXBFY+iSjfiEc6TGGYBBgEw=; b=fWgHoUbXW88bErHyyMVe6LR3APM6ahymvSBseUQqdQzqNkt+VvsesPzwO4RHFaBlij bR+sKZTBVng5lqEvY72dla3yX2mjO8Gt+0AXLjwpbl4jo26VgWOXR1irR1iKCMlkNbC0 WdSziG/GI9LQnckxhbb+CnFrXp23KZdCwfl9T1asOJ+fnvyB0SiNuOnYqzgpPN+9E+Ma ttMFTp8x3CijvS2K73aQIgiNaTDVcnjVVUNIlWlip82kANLzZmDf1Tyk+pxX5WdbfP5z uwBvFEVPswtN+iXY5L7p63bbFAJnxlq/iOGSfjGO6+BeN94nZonUF2VIOsn5XLuPYW36 jY2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OiAYKXU6LKvLzjanHYWWmXBFY+iSjfiEc6TGGYBBgEw=; b=rHw53rcWSTOqVmgKqtP4wvixVntj4vdKKfpHLdHLaA0EQxjdaUEGny21NTnJgOxVIH n62oshTQMURfx+YOG6Wj2m7CY7QvGg8TXgm45WwpeowouljIQJaACbc60P2EBsuUPruS FT+mknmDmsV/ZL8mKJ7nR0Zss54UVNp4DYWOnIFnZiVp3SJy0cIn21spoJ+zI+fsMr3Q aifo0pbPFT4lA8uQMrhT+Uvduo4CvvQWRUg+/T2jFj1qsy67wyOT7V4zuOfqJWHXBabK TWcDshxBK8W6f+DLq5AE/lR6DjLaZtleJMJXoyDOU8L70c4/JMxPTYxLPU8R/aEOFThv Sx5g== X-Gm-Message-State: AOAM533AeL3hav2zY17j62n8hNiFiGal5y3CCFAMFt/rsCJZiF5kLjj9 AM9daIT02nMsXisfFFJdviXfh4GCAzzXmqRsHVShOQ== X-Google-Smtp-Source: ABdhPJzO56j6stRSQaNbz97xoiOoYnHEVGX7T1UKCAYsxRNSP7iPGeSgEpd1t0abktKdfZIyPYIfrsF0oddX0anc/z4= X-Received: by 2002:a05:6a00:b95:b0:44c:7c8b:f762 with SMTP id g21-20020a056a000b9500b0044c7c8bf762mr2429192pfj.60.1634680153440; Tue, 19 Oct 2021 14:49:13 -0700 (PDT) MIME-Version: 1.0 References: <20210915195306.612966-1-kaleshsingh@google.com> <20210915195306.612966-2-kaleshsingh@google.com> <20211019164834.465b2a53@gandalf.local.home> <20211019172600.0f211c98@gandalf.local.home> In-Reply-To: <20211019172600.0f211c98@gandalf.local.home> From: Kalesh Singh Date: Tue, 19 Oct 2021 14:49:02 -0700 Message-ID: Subject: Re: [PATCH 1/5] tracing: Add support for creating hist trigger variables from literal To: Steven Rostedt Cc: Suren Baghdasaryan , Hridya Valsaraju , Namhyung Kim , Jonathan Corbet , Ingo Molnar , Shuah Khan , Tom Zanussi , Masami Hiramatsu , "open list:DOCUMENTATION" , LKML , "open list:KERNEL SELFTEST FRAMEWORK" , "Cc: Android Kernel" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Oct 19, 2021 at 2:26 PM Steven Rostedt wrote: > > On Tue, 19 Oct 2021 14:21:04 -0700 > Kalesh Singh wrote: > > > Addition and subtraction are already supported operations. The use > > case given in Documentation/trace/histogram.rst is for calculating > > latencies. I don't have a use case where the constants may be needed > > in the addition/subtraction, but for simplicity and completeness we > > support them for all operations. > > Perhaps we should state that it's mostly added for completeness then. Good point. I'll update the commit message to clarify it. Thanks, Kalesh > > Thanks, > > -- Steve