From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DADC3C43457 for ; Wed, 14 Oct 2020 20:04:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 543592223F for ; Wed, 14 Oct 2020 20:04:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="DmMNN2qm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729050AbgJNUEe (ORCPT ); Wed, 14 Oct 2020 16:04:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgJNUEb (ORCPT ); Wed, 14 Oct 2020 16:04:31 -0400 Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D95BC061755 for ; Wed, 14 Oct 2020 13:04:29 -0700 (PDT) Received: by mail-yb1-xb44.google.com with SMTP id c3so335763ybl.0 for ; Wed, 14 Oct 2020 13:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zGovuSkrqe3VpGrjEQXbflGvhILsF7fMmDOvOv0HZ20=; b=DmMNN2qmYsS4IUMJxDlpsTT/dyttCIlI2O/iRpGPsOoMVgY2VUB3FsKzLAdAllhOw6 4WpXo9010agGLYSz5jufxNIum4wr/kq84c5wHHPZrFisDReUBtp/cNN7QU66pCr7twnU 9qnOBQ966moAM6YTleIjUmrgQIKq+R9JM6DsNuqVDnKlPYpxYV/GLN9xC3Usg9hkTWKY H3aCOH+sgNsWBj+4p2m2RpM4iMEkCHBoAvLAf+yDq0Q+UHO6trWQ5RWvtf/Aw+0Mk5vK KCe3y8+0Bv23QOqUlh+X27SX0Uq2vvPEQ4nplyk9EwzpkLyA1Nq4ff6WPPlHSb+BZkZy pnaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zGovuSkrqe3VpGrjEQXbflGvhILsF7fMmDOvOv0HZ20=; b=gIQC5oXQi/+mFssuxrnVt1LdrW+oUBkyF+DqeQ18A3Mr4bLhcTJxVNsj7w9o9tBgZm y0w2UY+n1KZ/I84eNWyJMuG8TW3PqwmWzp1C0/2owemE+B/6FJ9I+Mq3wdkEJVe16CN8 C6GXUSfDQvW6PaxLFJ1BUaG6zoJr2+fgmIDXUMU+1UGJwBiARPTiBy62ofVOuNEDClm8 Yh4x3IZn9F1qUYkrd+Wa2Vth0y/pi6F0dO1vNfKPK/rcDn/NYnaqimQCC/UrAzM4L1C+ xUHk91qVK+JSor+82+TSVxzqCZINW0vtQHsFnjkJOnDizhYsk0zrXnJGvpcgI+tNFJOb t0Cw== X-Gm-Message-State: AOAM530mlxZ74Mh5oH/KVuTFaZ9r4fPaa4IwwNLUN+0FuT72CbPgd5QU ghKZhxFo9tpHYB70or4a8Dz7tZdMXlMrV9p6PQbigw== X-Google-Smtp-Source: ABdhPJyEzfM9Ywu3QG2apMCdipxoXOO58m8ggHr0w0quLiQI/TLNpmE4HyYz3y8+OuT7tRmbBNkVGKUJhwp1vvzO8ds= X-Received: by 2002:a25:d6c7:: with SMTP id n190mr584642ybg.75.1602705868286; Wed, 14 Oct 2020 13:04:28 -0700 (PDT) MIME-Version: 1.0 References: <20200729201146.537433-1-vitor@massaru.org> <20200729203908.GD2655@hirez.programming.kicks-ass.net> <20200804132517.GK2657@hirez.programming.kicks-ass.net> <20200804142344.GM2674@hirez.programming.kicks-ass.net> <20201014195948.GE2974@worktop.programming.kicks-ass.net> In-Reply-To: <20201014195948.GE2974@worktop.programming.kicks-ass.net> From: Vitor Massaru Iha Date: Wed, 14 Oct 2020 17:03:52 -0300 Message-ID: Subject: Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit To: Peter Zijlstra Cc: Ian Rogers , Brendan Higgins , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org, Ingo Molnar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Oct 14, 2020 at 5:00 PM Peter Zijlstra wrote: > > On Wed, Oct 14, 2020 at 11:16:10AM -0700, Ian Rogers wrote: > > > There were some issues in the original patch, they should be easy to > > fix. I'm more concerned that Peter's issues are addressed about the > > general direction of the patch, verbosity and testing frameworks. I > > see Vitor followed up with Peter but I'm not sure that means the > > approach has been accepted. > > I kinda lost track, as long as it doesn't get more verbose I suppose I'm > fine. Ok. I'll send the v2 later with Ian's suggestions.