From: Anders Roxell <anders.roxell@linaro.org>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christian Brauner <christian@brauner.io>,
Shuah Khan <shuah@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Adrian Reber <areber@redhat.com>
Subject: Re: [PATCH v3 0/6] Update clone3 self-tests
Date: Mon, 16 Sep 2019 13:39:20 +0200 [thread overview]
Message-ID: <CADYN=9KM5YWat7Fbh52hB4=pjpwPRO5o62=Jg+D3SnEATy3CeA@mail.gmail.com> (raw)
In-Reply-To: <cover.1568224280.git.esyr@redhat.com>
On Wed, 11 Sep 2019 at 20:02, Eugene Syromiatnikov <esyr@redhat.com> wrote:
>
> Hello.
>
> This patch set updates clone3 selftest in several aspects:
> - adding checks for exit_signal invalid values handling;
> - adding clone3 to selftests targets;
> - enabling clone3 tests on all architectures;
> - minor cleanups of the clone3 test.
>
> This respin alignes additional clone3 self-tests with v3 of the
> exit_signal checking patch[1].
>
> Applied on top of brauer/linux.git/for-next.
>
> Changes since v2[2]:
> - CLONE3_ARGS_INVAL_EXIT_SIGNAL_NSIG check is now expected to fail.
>
> Changes since v1[3]:
> - exit_signal check extended to cover more cases of invalid
> exit_signal value.
>
> [1] https://lkml.org/lkml/2019/9/11/677
> [2] https://lkml.org/lkml/2019/9/10/768
> [3] https://lkml.org/lkml/2019/9/10/416
>
> Eugene Syromiatnikov (6):
> selftests/clone3: convert test modes into an enum
> selftests/clone3: add a check for invalid exit_signal
> selftests/clone3: use uint64_t for flags parameter
> selftests/clone3: fix up format strings
> selftests/clone3: enable clone3 self-tests on all architectures
> selftests: add clone3 to TARGETS
I wasn't able to build this patchset for arm64, I applied it on tag
next-20190904:
$ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -skj$(getconf
_NPROCESSORS_ONLN) headers_install
$ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -skj$(getconf
_NPROCESSORS_ONLN) -C tools/testing/selftests/clone3
clone3_set_tid.c: In function ‘raw_clone’:
clone3_set_tid.c:22:17: error: ‘__NR_clone3’ undeclared (first use in
this function); did you mean ‘raw_clone’?
return syscall(__NR_clone3, args, sizeof(struct clone_args));
^~~~~~~~~~~
raw_clone
clone3_set_tid.c:22:17: note: each undeclared identifier is reported
only once for each function it appears in
make: *** [../lib.mk:138:
/srv/src/kernel/kselftest-testing/tools/testing/selftests/clone3/clone3_set_tid]
Error 1
clone3.c: In function ‘raw_clone’:
clone3.c:41:17: error: ‘__NR_clone3’ undeclared (first use in this
function); did you mean ‘raw_clone’?
return syscall(__NR_clone3, args, size);
^~~~~~~~~~~
raw_clone
clone3.c:41:17: note: each undeclared identifier is reported only once
for each function it appears in
make: *** [../lib.mk:138:
/srv/src/kernel/kselftest-testing/tools/testing/selftests/clone3/clone3]
Error 1
make: Target 'all' not remade because of errors.
Any idea what I'm doing wrong?
Cheers,
Anders
>
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/clone3/Makefile | 4 +--
> tools/testing/selftests/clone3/clone3.c | 64 ++++++++++++++++++++++++++++-----
> 3 files changed, 57 insertions(+), 12 deletions(-)
>
> --
> 2.1.4
>
next prev parent reply other threads:[~2019-09-16 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 18:01 [PATCH v3 0/6] Update clone3 self-tests Eugene Syromiatnikov
2019-09-11 18:02 ` [PATCH v3 1/6] selftests/clone3: convert test modes into an enum Eugene Syromiatnikov
2019-09-11 18:02 ` [PATCH v3 2/6] selftests/clone3: add a check for invalid exit_signal Eugene Syromiatnikov
2019-09-11 18:02 ` [PATCH v3 3/6] selftests/clone3: use uint64_t for flags parameter Eugene Syromiatnikov
2019-09-11 18:02 ` [PATCH v3 4/6] selftests/clone3: fix up format strings Eugene Syromiatnikov
2019-09-11 18:02 ` [PATCH v3 5/6] selftests/clone3: enable clone3 self-tests on all architectures Eugene Syromiatnikov
2019-09-11 18:02 ` [PATCH v3 6/6] selftests: add clone3 to TARGETS Eugene Syromiatnikov
2019-09-16 11:39 ` Anders Roxell [this message]
2019-09-16 11:42 ` [PATCH v3 0/6] Update clone3 self-tests Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADYN=9KM5YWat7Fbh52hB4=pjpwPRO5o62=Jg+D3SnEATy3CeA@mail.gmail.com' \
--to=anders.roxell@linaro.org \
--cc=areber@redhat.com \
--cc=christian@brauner.io \
--cc=esyr@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).