From: SeongJae Park <sj38.park@gmail.com> To: Brendan Higgins <brendanhiggins@google.com> Cc: Jonathan Corbet <corbet@lwn.net>, KUnit Development <kunit-dev@googlegroups.com>, "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>, shuah <shuah@kernel.org>, SeongJae Park <sjpark@amazon.de> Subject: Re: [PATCH v3 0/5] Fix nits in the kunit Date: Wed, 4 Dec 2019 21:28:16 +0100 Message-ID: <CAEjAshpQNVdLgtLyTu5WjxygRptZ4qomKCQaxw1YaX5ppvBcNQ@mail.gmail.com> (raw) In-Reply-To: <CAEjAshrXG3GmNMAS6Upu0=cCe9KJxchQWeiqLg0b8kif9ivNTg@mail.gmail.com> On Wed, Dec 4, 2019 at 9:25 PM SeongJae Park <sj38.park@gmail.com> wrote: > > On Wed, Dec 4, 2019 at 8:21 PM Brendan Higgins > <brendanhiggins@google.com> wrote: > > > > On Tue, Dec 03, 2019 at 02:41:26PM -0800, Brendan Higgins wrote: > > > On Tue, Dec 3, 2019 at 10:08 AM SeongJae Park <sj38.park@gmail.com> wrote: > > > > > > > > This patchset contains trivial fixes for the kunit documentations and the > > > > wrapper python scripts. > > > > > > > > Changes from v2 (https://lore.kernel.org/linux-kselftest/1575361141-6806-1-git-send-email-sj38.park@gmail.com/T/#t): > > > > - Make 'build_dir' if not exists (missed from v3 by mistake) > > > > > > > > SeongJae Park (5): > > > > docs/kunit/start: Use in-tree 'kunit_defconfig' > > > > kunit: Remove duplicated defconfig creation > > > > kunit: Create default config in '--build_dir' > > > > kunit: Place 'test.log' under the 'build_dir' > > > > kunit: Rename 'kunitconfig' to '.kunitconfig' > > > > > > > > Documentation/dev-tools/kunit/start.rst | 13 +++++-------- > > > > tools/testing/kunit/kunit.py | 16 ++++++++++------ > > > > tools/testing/kunit/kunit_kernel.py | 8 ++++---- > > > > 3 files changed, 19 insertions(+), 18 deletions(-) > > > > > > Tested-by: Brendan Higgins <brendanhiggins@google.com> > > > > I just realized that I forgot to test for something... > > > > The following command fails: > > > > ./tools/testing/kunit/kunit.py run --timeout=60 --jobs=12 --defconfig > > > > [11:17:13] Building KUnit Kernel ... > > [11:17:16] Starting KUnit Kernel ... > > Traceback (most recent call last): > > File "tools/testing/kunit/kunit.py", line 142, in <module> > > main(sys.argv[1:]) > > File "tools/testing/kunit/kunit.py", line 135, in main > > result = run_tests(linux, request) > > File "tools/testing/kunit/kunit.py", line 67, in run_tests > > test_result = kunit_parser.parse_run_tests(kunit_output) > > File "/usr/local/google/home/brendanhiggins/gbmc-linux/tools/testing/kunit/kunit_parser.py", line 283, in parse_run_tests > > test_result = parse_test_result(list(isolate_kunit_output(kernel_output))) > > File "/usr/local/google/home/brendanhiggins/gbmc-linux/tools/testing/kunit/kunit_parser.py", line 54, in isolate_kunit_output > > for line in kernel_output: > > File "/usr/local/google/home/brendanhiggins/gbmc-linux/tools/testing/kunit/kunit_kernel.py", line 146, in run_kernel > > with open(os.path.join(build_dir, 'test.log'), 'w') as f: > > File "/usr/lib/python3.7/posixpath.py", line 80, in join > > a = os.fspath(a) > > TypeError: expected str, bytes or os.PathLike object, not NoneType > > > > It seems as though you assume that build_dir is always populated by the flag. > > Sorry for not checking the case. The 4th patch, "kunit: Place 'test.log' under > the 'build_dir'" made the bug. I fixed the 4th patch and tested with below > commands: > > ./tools/testing/kunit/kunit.py run --timeout=60 --jobs=12 > --defconfig --build_dir .kunit > ./tools/testing/kunit/kunit.py run --timeout=60 --jobs=12 --defconfig > > Just sent the 4th version patchset including the fix: > http://lkml.kernel.org/r/1575490683-13015-1-git-send-email-sj38.park@gmail.com Also, removed the 'Reviewed-by' from the 4th patch and didn't add 'Tested-by' to the patchset. Thanks, SeongJae Park > > I will consider adding some tests that can check such cases in the > 'kunit_tools_test.py' later. > > > Thanks, > SeongJae Park
next prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-03 18:08 SeongJae Park 2019-12-03 18:08 ` [PATCH v3 1/5] docs/kunit/start: Use in-tree 'kunit_defconfig' SeongJae Park 2019-12-03 18:08 ` [PATCH v3 2/5] kunit: Remove duplicated defconfig creation SeongJae Park 2019-12-03 18:08 ` [PATCH v3 3/5] kunit: Create default config in '--build_dir' SeongJae Park 2019-12-03 22:39 ` Brendan Higgins 2019-12-03 18:08 ` [PATCH v3 4/5] kunit: Place 'test.log' under the 'build_dir' SeongJae Park 2019-12-03 18:08 ` [PATCH v3 5/5] kunit: Rename 'kunitconfig' to '.kunitconfig' SeongJae Park 2019-12-03 22:41 ` [PATCH v3 0/5] Fix nits in the kunit Brendan Higgins 2019-12-04 19:21 ` Brendan Higgins 2019-12-04 20:25 ` SeongJae Park 2019-12-04 20:28 ` SeongJae Park [this message] 2019-12-05 9:44 ` sjpark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAEjAshpQNVdLgtLyTu5WjxygRptZ4qomKCQaxw1YaX5ppvBcNQ@mail.gmail.com \ --to=sj38.park@gmail.com \ --cc=brendanhiggins@google.com \ --cc=corbet@lwn.net \ --cc=kunit-dev@googlegroups.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ --cc=sjpark@amazon.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-kselftest Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \ linux-kselftest@vger.kernel.org public-inbox-index linux-kselftest Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest AGPL code for this site: git clone https://public-inbox.org/public-inbox.git