From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06456C43603 for ; Fri, 6 Dec 2019 19:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C34A124677 for ; Fri, 6 Dec 2019 19:31:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CGqxsXJ1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726325AbfLFTbu (ORCPT ); Fri, 6 Dec 2019 14:31:50 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:33095 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbfLFTbu (ORCPT ); Fri, 6 Dec 2019 14:31:50 -0500 Received: by mail-lj1-f194.google.com with SMTP id 21so8899535ljr.0; Fri, 06 Dec 2019 11:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c0i7PQFXimXWpGVLkYYKBm4f7YSggydB6SsE85wLPz0=; b=CGqxsXJ1NAkcws9QIo/5PmdAISTzNi1qBfMkvLLDNP52aJNNld2YyCheGY8hVccaCQ nHq2UHGPRcxS+fdB2mY10PfOzpVhdmcsCg7uNxWsrN5LHjp3hXEwnTEX6EjMFq2GzpRE FGSlObTNDSZEZLRKW2OZQGBUsN4r0gkqUvD5gLzNvR3Px1OMY314OaQmJGLmO+l8q3d8 jCk4VfSIp9iPF2db8IM/NeSGdDaVt3KcC3oOUtBjYwSfgIG5POjUsKR/HTy3c7bx/S6S 31WTMmPP5EgDt5svdCeZLTOkGDsjQJDPIYCnVM6sNMSnpancUVPQp+bnScpolg45mSym kDdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c0i7PQFXimXWpGVLkYYKBm4f7YSggydB6SsE85wLPz0=; b=e6Rv20xrsAbNmVzblr2VEK4hHPtPyn/Ry6qfrd7KZUeQhmxjWgWi3F5FCiFBnd021B Oh0N+sKnbZJ5if6VmWYMQrZenMD2XM/SHTo/59a0DisHvhM9WRXKeOt+uivJulPDoknD lkIa6aujw9tZHFXlRT2MI/ZKiD2MOr3p3UWqH4NfEwlBM+CqcFU7fegZV6dtGSMFqrw8 XdH1bmpxuaggA3Fm5niYEpaRm+qOVqG0qfoO+NYS0DuYqEVQbWDmJzzaErFHRl0BsNpP 6YYJ5ld/z04oHAMkxfAhxitWggqNv8HeyMybEpDNMvVK3DAh7SsjJRR4sUs+gfFg9t2T K5uQ== X-Gm-Message-State: APjAAAVhjOQBwkLa0aaA0GTZ0Q+2lbwe33fIXWnOVVNnVY72R8Nx3VAc H6DCxOMYBOJlRW8NsW0enilt8fZ1+9RROg5Uyhs= X-Google-Smtp-Source: APXvYqy64ysU6bQkPmBJYnQVN8J6Dx04EnlY29IwsfHNNDiNvdNu37U8eOIv5chOGy87VHdjwHl/keyJWALg1TEjMhk= X-Received: by 2002:a05:651c:102c:: with SMTP id w12mr9448372ljm.53.1575660707792; Fri, 06 Dec 2019 11:31:47 -0800 (PST) MIME-Version: 1.0 References: <20191202114221.827-1-sjpark@amazon.com> In-Reply-To: <20191202114221.827-1-sjpark@amazon.com> From: SeongJae Park Date: Fri, 6 Dec 2019 20:31:21 +0100 Message-ID: Subject: Re: [PATCH 1/2] kselftest/runner: Print new line in print of timeout log To: SeongJae Park Cc: Shuah Khan , Kees Cook , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , SeongJae Park Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hello Shuah, May I ask your comments? Thanks, SeongJae Park On Mon, Dec 2, 2019 at 12:42 PM SeongJae Park wrote: > > From: SeongJae Park > > If a timeout failure occurs, kselftest kills the test process and prints > the timeout log. If the test process has killed while printing a log > that ends with new line, the timeout log can be printed in middle of the > test process output so that it can be seems like a comment, as below: > > # test_process_log not ok 3 selftests: timers: nsleep-lat # TIMEOUT > > This commit avoids such problem by printing one more line before the > TIMEOUT failure log. > > Signed-off-by: SeongJae Park > --- > tools/testing/selftests/kselftest/runner.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh > index 84de7bc74f2c..a8d20cbb711c 100644 > --- a/tools/testing/selftests/kselftest/runner.sh > +++ b/tools/testing/selftests/kselftest/runner.sh > @@ -79,6 +79,7 @@ run_one() > if [ $rc -eq $skip_rc ]; then \ > echo "not ok $test_num $TEST_HDR_MSG # SKIP" > elif [ $rc -eq $timeout_rc ]; then \ > + echo "#" > echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT" > else > echo "not ok $test_num $TEST_HDR_MSG # exit=$rc" > -- > 2.17.1 >