From: SeongJae Park <sj38.park@gmail.com>
To: Heidi Fahim <heidifahim@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
David Gow <davidgow@google.com>, Shuah Khan <shuah@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
kunit-dev@googlegroups.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function
Date: Sun, 1 Dec 2019 22:10:18 +0100 [thread overview]
Message-ID: <CAEjAshrJy00VjDu3GY3gV6hu7J8PVcw=1jAeA_-GL02kvXTemQ@mail.gmail.com> (raw)
In-Reply-To: <CAMVcs3vKjd8XVku8VUq2R-OKKSq-X2L=h4niFxuoPBe_D63JAA@mail.gmail.com>
On Thu, Nov 28, 2019 at 12:58 AM Heidi Fahim <heidifahim@google.com> wrote:
>
> On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote:
> >
> > Assert in test_run_timeout was not updated with the build_dir argument
> > and caused the following error:
> > AssertionError: Expected call: run_kernel(timeout=3453)
> > Actual call: run_kernel(build_dir=None, timeout=3453)
> >
> > Needed to update kunit_tool_test to reflect this fix
> > https://lkml.org/lkml/2019/9/6/3
>
> Wrong url, here is the correct link to the fix that caused this bug:
> https://lkml.org/lkml/2019/9/6/351
Reviewed-by: SeongJae Park <sjpark@amazon.de>
Thanks,
SeongJae Park
next prev parent reply other threads:[~2019-12-01 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 23:19 [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function Heidi Fahim
2019-11-27 23:58 ` Heidi Fahim
2019-12-01 21:10 ` SeongJae Park [this message]
2019-12-02 17:09 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEjAshrJy00VjDu3GY3gV6hu7J8PVcw=1jAeA_-GL02kvXTemQ@mail.gmail.com' \
--to=sj38.park@gmail.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=heidifahim@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).