archive mirror
 help / color / mirror / Atom feed
From: Brendan Higgins <>
To: Daniel Latypov <>
Subject: Re: [PATCH v2] kunit: tool: reconfigure when the used kunitconfig changes
Date: Tue, 7 Dec 2021 17:49:38 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Nov 19, 2021 at 6:23 PM Daniel Latypov <> wrote:
> Problem: currently, if you remove something from your kunitconfig,
> will not regenerate the .config file.
> The same thing happens if you did --kunitconfig_add=CONFIG_KASAN=y [1]
> and then ran again without it. Your new run will still have KASAN.
> The reason is that won't regenerate the .config file if it's a
> superset of the kunitconfig. This speeds it up a bit for iterating.
> This patch adds an additional check that forces to regenerate
> the .config file if the current kunitconfig doesn't match the previous
> one.
> What this means:
> * deleting entries from .kunitconfig works as one would expect
> * dropping  a --kunitconfig_add also triggers a rebuild
> * you can still edit .config directly to turn on new options
> We implement this by creating a `last_used_kunitconfig` file in the
> build directory (so .kunit, by default) after we generate the .config.
> When comparing the kconfigs, we compare python sets, so duplicates and
> permutations don't trip us up.
> The majority of this patch is adding unit tests for the existing logic
> and for the new case where `last_used_kunitconfig` differs.
> [1]
> Signed-off-by: Daniel Latypov <>

When you first presented this, I wasn't a huge fan, but you convinced
me. I think the only reason I didn't initially like this is because of
how used-to kunit_tool's eccentricities I have gotten.

Reviewed-by: Brendan Higgins <>

      parent reply	other threads:[~2021-12-07 22:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 23:23 [PATCH v2] kunit: tool: reconfigure when the used kunitconfig changes Daniel Latypov
2021-11-20  0:40 ` David Gow
2021-12-07 22:49 ` Brendan Higgins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).