From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA56C433EF for ; Fri, 17 Dec 2021 05:07:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbhLQFH2 (ORCPT ); Fri, 17 Dec 2021 00:07:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbhLQFH1 (ORCPT ); Fri, 17 Dec 2021 00:07:27 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1C3CC061574 for ; Thu, 16 Dec 2021 21:07:27 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id w24so847303ply.12 for ; Thu, 16 Dec 2021 21:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A9pI3PLDD+OS9t2q3FMIaJurBaIWrkrm6Rd7tPFvvQ0=; b=Sd8ve/vPQ5ZGfHHTvAX9sXYdzR7AA9xakeshpgsZljkscsGfndi4UvDeEzzhIIza// U0TqH6XVH7O5D0aLNYUBPKIcO9/OH9t/yMcCOFSN13bx82dJ+4CcPBsYOOyNcn7gnP3e udlyeb11MWvlMCDH/8oo4txJUlo/ZOf/Kca3VA9Ph2giZUdDbeAkbsVExn6L950mssK9 NcsQo+LnV8mkP/3h75kDYjzDbQXbpqVE5iIr+CjEfiNSEEmzM5NDywDyo/HNYy3xeGqS XjF2PTPmJREzBdnjP6LuO+nH9FJ9qfiR0C/sLAmTSFZsFSYnJ//BWmLBR9VZwst3uftf TRBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A9pI3PLDD+OS9t2q3FMIaJurBaIWrkrm6Rd7tPFvvQ0=; b=ZPNhesBfQRdSF6cdpTScJuu7NyrRpyP2BJGpg2PcvtBBBuqJ+MJRX3coKt/SFEAaLz ZBCEb4evfjThtQD9+qMT4p1FTD5Cp6L8CYpCWOgLKFMAdCPcka2n1ejWJ/dl4f+IoF6R 4HtanKN8ej5b0jylPphfha9bCO1fojlmAy4993lr8ogT5aRT/REh048KI9CaeZsf6ca8 IkD1fnLz7ppS3xeOHTPXWVVZEXvvxcaEtbw7bYxtsnfInGVcLF/1i8Dvw1cSAbKohYnN l+ZIrTg0eGo6r+lYQj5VIiEP0FEFKXe++zKcmXZTSo5Bnj/gjdyNEdu1s32MlikJL3co o7VQ== X-Gm-Message-State: AOAM5327TUzPBRXH9i6kd0p8Fnfxjqgw3kheottolYzf91u9CXL8+aNp CEg70LZ8Nxtw/cQtGBEtciNmnFnNQ6XV7xBlqMzRPA== X-Google-Smtp-Source: ABdhPJzJKq1o8f6WEFg2rwwpF/uLHHrJJQdAZ5qIarI3++tyiyHB2lJXCUrdzb4fKcVDtdOMe0LppqrWVFSkUg+uzAM= X-Received: by 2002:a17:902:a717:b0:142:76bc:da69 with SMTP id w23-20020a170902a71700b0014276bcda69mr1468880plq.12.1639717646845; Thu, 16 Dec 2021 21:07:26 -0800 (PST) MIME-Version: 1.0 References: <20211216055958.634097-1-sharinder@google.com> <20211216055958.634097-4-sharinder@google.com> <87czlwcfav.fsf@meer.lwn.net> In-Reply-To: From: Brendan Higgins Date: Fri, 17 Dec 2021 00:07:15 -0500 Message-ID: Subject: Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture To: Harinder Singh Cc: Jonathan Corbet , Marco Elver , David Gow , shuah@kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Tim.Bird@sony.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Dec 16, 2021 at 11:57 PM Harinder Singh wrote: > > Hello Jonathan and Marco, > > > On Fri, Dec 17, 2021 at 4:45 AM Jonathan Corbet wrote: > > > > Marco Elver writes: > > > > > In response to the other email: Adding binary blobs just creates > > > problems, for comparing different versions, and general bloating the > > > whole repo, where better alternatives exist. > > > > > > I suppose an ASCII diagram is a bit primitive. :-) > > > > > > However, SVG files on the other hand are not binary blobs, they are > > > text-markup based (XML), and e.g. diffing them often provides useful > > > information about what changed. SVG also has the benefit of being > > > vector graphics, and not being limited to one resolution. > > > > > > Looking at the diagram you added, I think this can easily be turned > > > into vector graphics, and most likely will not use up 24KiB as a > > > result. > > > > I agree with all of this; we shouldn't be adding binary images to the > > docs, and we've decided at other times that SVG is generally the best > > compromise there. > > > I did not realize that .SVG is in XML format and preferred over .PNG. > Thanks for pointing this out. I replaced .SVG with .PNG. > > > Thanks, Marco, for pointing this out and producing an alternative. > > > A big thanks to Marco for creating this .SVG file for the documentation :-) > > > Once this is all settled, do you want it to go through the docs tree? > > > Yeah! that's the plan. Yep, please take this through the docs tree. I will send out my Reviewed-by on the other patches shortly.