From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A16C43215 for ; Mon, 2 Dec 2019 16:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0722E2071F for ; Mon, 2 Dec 2019 16:18:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SFZ2cXoC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727418AbfLBQSn (ORCPT ); Mon, 2 Dec 2019 11:18:43 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:43309 "EHLO mail-pl1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727478AbfLBQSn (ORCPT ); Mon, 2 Dec 2019 11:18:43 -0500 Received: by mail-pl1-f177.google.com with SMTP id q16so114431plr.10 for ; Mon, 02 Dec 2019 08:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lDr5P4cJ4UHd7ZMj54UzZaDvlWleENdbESvTh3swfpw=; b=SFZ2cXoCbyhBxZEnumr9gVKKRJyUSHgNKMl/PkvipUbkLT7mbjlw+oLbPuuxNu/raz OK3JoIptBAt2vnPg5nlcZ9WS8Pg3k/+HM9iBXfwBiook+l+Tdr0QNJEWjTUNIDtqk5Gk BZMd77IDy5czigoQWozohJjkNt393h/Ulm2woiG8fGr6j+0NcVC85zNVOLte5DV3R0IS 5CNPPGiERoj/exEvD2E9bSjz8J9ztpOIzJCIC301yLvhOOZhxJMcNkaatDmILlz261i7 4I5hPevVQkHnBUSbZE3m/Dne57F7kM9RyfuRHJXCgPc1yA/xswnwD/l99h6Zv0ZS/jx8 m+cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lDr5P4cJ4UHd7ZMj54UzZaDvlWleENdbESvTh3swfpw=; b=DVOqiacSTKAEV5X+Ezn0xKocGbst1f48WthO8rQCsE19cY549RZjA6oTlTUKAjUdRh GL8UlirZNgqKDazip6UdvvYloJwlP1ikazd7htAhxNyR0i02+hZIKSdZSk8lj7v+Zo9x Kn25dMxcE0rsDTyuS6lb0CD6Yr2Ow5YbZBPuthYSDW8nnbLyZYfbk3AVZSMTvYZs72dY BX3+NbPTYdq3MhnRQJvDtm4NefAmf++h3i0/CVYN8H/3Akchvfmi8Co/5i8MEjini6Hu 6MrLbYUF0/nONRGFujZs52P1jaYNM3ZSKc6EyDFKj0HqlcM+AMinWozvMt38IEmfmsj+ utJQ== X-Gm-Message-State: APjAAAUQ8Yr2G4SRhVHAagpuva369VeYytdQh1C3JiAV5aBWTrwblMN3 7bPVv2mm9rIldxjy40WP5wTpIQBOkNa8lsDjnlfJRg== X-Google-Smtp-Source: APXvYqzF/QIZsDrvGOeX/F9JxX91qCzNc6BGyC7UE6gbwPQ7v0o9JY+9iIJ+58e6b7q2cwegny55kqtzxh2HgC9OYjc= X-Received: by 2002:a17:90a:ff02:: with SMTP id ce2mr36132354pjb.117.1575303521875; Mon, 02 Dec 2019 08:18:41 -0800 (PST) MIME-Version: 1.0 References: <20191127185524.40220-1-yzaikin@google.com> In-Reply-To: <20191127185524.40220-1-yzaikin@google.com> From: Brendan Higgins Date: Mon, 2 Dec 2019 08:18:32 -0800 Message-ID: Subject: Re: [PATCH] fs/ext4/inode-test: Fix inode test on 32 bit platforms. To: Iurii Zaikin Cc: Shuah Khan , "Theodore Ts'o" , geert@linux-m68k.org, linux-ext4@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Nov 27, 2019 at 10:55 AM Iurii Zaikin wrote: > > Fixes the issue caused by the fact that in C in the expression > of the form -1234L only 1234L is the actual literal, the unary > minus is an operation applied to the literal. Which means that > to express the lower bound for the type one has to negate the > upper bound and subtract 1. > Original error: > Expected test_data[i].expected.tv_sec == timestamp.tv_sec, but > test_data[i].expected.tv_sec == -2147483648 > timestamp.tv_sec == 2147483648 > 1901-12-13 Lower bound of 32bit < 0 timestamp, no extra bits: msb:1 > lower_bound:1 extra_bits: 0 > Expected test_data[i].expected.tv_sec == timestamp.tv_sec, but > test_data[i].expected.tv_sec == 2147483648 > timestamp.tv_sec == 6442450944 > 2038-01-19 Lower bound of 32bit <0 timestamp, lo extra sec bit on: > msb:1 lower_bound:1 extra_bits: 1 > Expected test_data[i].expected.tv_sec == timestamp.tv_sec, but > test_data[i].expected.tv_sec == 6442450944 > timestamp.tv_sec == 10737418240 > 2174-02-25 Lower bound of 32bit <0 timestamp, hi extra sec bit on: > msb:1 lower_bound:1 extra_bits: 2 > not ok 1 - inode_test_xtimestamp_decoding > not ok 1 - ext4_inode_test > > Reported-by: Geert Uytterhoeven > Signed-off-by: Iurii Zaikin > Tested-by: Geert Uytterhoeven Acked-by: Brendan Higgins Thanks for taking care of this so quickly!