archive mirror
 help / color / mirror / Atom feed
From: Brendan Higgins <>
To: Randy Dunlap <>
Cc: Stephen Rothwell <>,
	Linux Next Mailing List <>,
	Linux Kernel Mailing List <>,
	Shuah Khan <>,
Subject: Re: linux-next: Tree for Aug 27 (kunit)
Date: Tue, 27 Aug 2019 09:09:43 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Aug 27, 2019 at 8:29 AM Randy Dunlap <> wrote:
> On 8/27/19 2:05 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20190826:
> >
> on i386:
> # CONFIG_PRINTK is not set
> ../kunit/test.c: In function ‘kunit_vprintk_emit’:
> ../kunit/test.c:21:9: error: implicit declaration of function ‘vprintk_emit’; did you mean ‘vprintk’? [-Werror=implicit-function-declaration]
>   return vprintk_emit(0, level, NULL, 0, fmt, args);
>          ^~~~~~~~~~~~
>          vprintk

Ooops, it never occurred to me to test the situation where I wouldn't
be able to see test results :-)

It seems to me that the right thing to do here is to do what
dev_printk and friends do and to ifdef this out if CONFIG_PRINTK is
unavailable. Does that seem reasonable?

Also, do you want me to resend my patches with the fix or do you want
me to send a new patch with this fix? (Sorry for the newbie question.)


  reply	other threads:[~2019-08-27 16:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2019-08-27 15:29 ` linux-next: Tree for Aug 27 (kunit) Randy Dunlap
2019-08-27 16:09   ` Brendan Higgins [this message]
2019-08-27 16:12     ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).