From: Brendan Higgins <firstname.lastname@example.org> To: Andy Shevchenko <email@example.com>, SeongJae Park <firstname.lastname@example.org>, SeongJae Park <email@example.com> Cc: Shuah Khan <firstname.lastname@example.org>, "open list:KERNEL SELFTEST FRAMEWORK" <email@example.com>, KUnit Development <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com> Subject: Re: [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again Date: Mon, 26 Oct 2020 13:44:33 -0700 Message-ID: <CAFd5g45N_7HTTObU799_S-9QPFXhQkeQ=yqvH-J79ROvKSXs4A@mail.gmail.com> (raw) In-Reply-To: <20201025124459.GA1157488@surfacebook.localdomain> On Sun, Oct 25, 2020 at 5:45 AM <firstname.lastname@example.org> wrote: > > On Thu, Oct 22, 2020 at 08:35:26AM +0200, SeongJae Park wrote: > > On Wed, 21 Oct 2020 14:32:52 -0700 Brendan Higgins <email@example.com> wrote: > > > > > On Mon, Oct 12, 2020 at 3:27 AM SeongJae Park <firstname.lastname@example.org> wrote: > > > > > > > > From: SeongJae Park <email@example.com> > > > > > > > > 'kunit_kernel.kunittest_config' was constant at first, and therefore it > > > > used UPPER_SNAKE_CASE naming convention that usually means it is > > > > constant in Python world. But, commit e3212513a8f0 ("kunit: Create > > > > default config in '--build_dir'") made it modifiable to fix a use case > > > > of the tool and thus the naming also changed to lower_snake_case. > > > > However, this resulted in a confusion. As a result, some successing > > > > changes made the tool unittest fail, and a fix of it again incurred > > > > the '--build_dir' use case failure. > > > > > > > > As the previous commit fixed the '--build_dir' use case without > > > > modifying the variable again, this commit marks the variable as constant > > > > again with UPPER_SNAKE_CASE, to reduce future confusions. > > > > > > > >  Commit d43c7fb05765 ("kunit: tool: fix improper treatment of file location") > > > > > > > > Signed-off-by: SeongJae Park <firstname.lastname@example.org> > > > > > > Reviewed-by: Brendan Higgins <email@example.com> > > > > Thanks :) > > > > > > > > Thanks for this! This is something I meant to fix a while ago and forgot about. > > > > > > One minor issue, this patch does not apply on torvalds/master right > > > now. Could you please rebase this? > > > > Surely of course, I will send next version soon. > > May I ask what happened to ? > I mean it seems these two are goind to collide. > > Brendan? > > : https://firstname.lastname@example.org/ Sorry for the confusion here. After an initial glance at your patches (before I did the review end of last week) I thought only the first patch from SeongJae would potentially conflict with yours (Andy's) (hence why I hadn't reviewed it yet, I was waiting until after I looked at yours). I noticed on Friday that SeongJae's changes were actually fully encompassed by Andy's, so I am taking Andy's not SongJae's. Sorry, I was going to notify SongJae today, but you beat me to it. Sorry everyone.
next prev parent reply index Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-12 10:26 [PATCH 1/2] kunit: tool: Fix LinuxSourceTree's missed handling of 'build_dir' SeongJae Park 2020-10-12 10:26 ` [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again SeongJae Park 2020-10-20 6:52 ` SeongJae Park 2020-10-21 21:32 ` Brendan Higgins 2020-10-22 6:35 ` SeongJae Park 2020-10-25 12:44 ` andy 2020-10-26 20:44 ` Brendan Higgins [this message] 2020-10-27 7:19 ` SeongJae Park
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFd5g45N_7HTTObU799_S-9QPFXhQkeQ=yqvH-J79ROvKSXs4A@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-kselftest Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \ email@example.com public-inbox-index linux-kselftest Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest AGPL code for this site: git clone https://public-inbox.org/public-inbox.git