From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66A3C32753 for ; Wed, 14 Aug 2019 10:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD36B2084F for ; Wed, 14 Aug 2019 10:04:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mX9zQWTJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726221AbfHNKEB (ORCPT ); Wed, 14 Aug 2019 06:04:01 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36119 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725861AbfHNKEB (ORCPT ); Wed, 14 Aug 2019 06:04:01 -0400 Received: by mail-pf1-f196.google.com with SMTP id w2so2471194pfi.3 for ; Wed, 14 Aug 2019 03:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A8hpxCTzvYAcZn9UvY3kAbimH8cB/wVPQT2NUqi4FTg=; b=mX9zQWTJ21YVDsg/IO/lw3vK/5gRG1WKeYfq5hAVfRdrbxBQb/LOP7585An8TcS5uX tQfD//4o9HuUJa0OuyeBf0yYOxvzPAaOMjQC0e2XsG/XzCmrU1JU4X/cHR16Fl4JFHLe Zi0Tt+GUrI9Wq+kCxNmISk1ZO0HC18yrn6Nwe48kfT9CiA+xyYq2zY+VKjPraHI0VO+y z/s0hx02KzWhdnSkkt85Mam6mmVNYQ/kS61kWPXi/v/57imnYMdAPEqFsVlbDExrl+Ld 2hdI8g4c1e8Cjj/bm8uvF1dfC8bBYtWFJT7eA1eUTgYFQ5SiQc/BI8jH+SCjQE2t4VrR 5trQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A8hpxCTzvYAcZn9UvY3kAbimH8cB/wVPQT2NUqi4FTg=; b=OwvsZGeUgTmKdTC5g8xED6G94wnKcLmgkPJ9LZzB00WZL0aeodH2aBMVtCjoCNhevm tNRZSpWrIam5RX8i/lmYaYHt5pchCF/8H8w3YbgsX/3v4YamIZvT58pFgOko0s1F3jI1 VnTMygmZidqgmNPC4pWOIN6CCg2YM980DZxk3UO2rzdrn7mYMYYaOuDpdW9SJKx9xQMc cX3U0IOy+ilmHsKV8UAkzSHWBMMxJ3oYv6h6WIkNgS2cktFHl9d6qemlUVIZEZtC7FGn 9qYhBMhO9pZbfslh8RiiAGj5a31b23MZG4/LfVZf4W1qtJPSimskDFU4YcxAgZj2Dsib zchw== X-Gm-Message-State: APjAAAWU2WkSOb2Yb8OOH5YZ2/AkqU8hCjTkDK49yqupjeG2EDjVcyi2 kPOLgVGKEbV9WOyLWoFcvGiczmPydz495aeER7e6Hg== X-Google-Smtp-Source: APXvYqxyXqiNwjdTK3oFKny5yM7CmoKjVDpDDnZBrvH4fSE28h1/JfZ1mGpG1xfSCFWK+kgS1gJNI6SNjgBRmNUJeQM= X-Received: by 2002:a63:205f:: with SMTP id r31mr36074127pgm.159.1565777039574; Wed, 14 Aug 2019 03:03:59 -0700 (PDT) MIME-Version: 1.0 References: <20190814055108.214253-1-brendanhiggins@google.com> In-Reply-To: <20190814055108.214253-1-brendanhiggins@google.com> From: Brendan Higgins Date: Wed, 14 Aug 2019 03:03:47 -0700 Message-ID: Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework To: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , Stephen Boyd , shuah , "Theodore Ts'o" , Masahiro Yamada Cc: devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com, Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Aug 13, 2019 at 10:52 PM Brendan Higgins wrote: > > ## TL;DR > > This revision addresses comments from Stephen and Bjorn Helgaas. Most > changes are pretty minor stuff that doesn't affect the API in anyway. > One significant change, however, is that I added support for freeing > kunit_resource managed resources before the test case is finished via > kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke > KUnit on certain configurations (like the default one for x86, whoops). > > Based on Stephen's feedback on the previous change, I think we are > pretty close. I am not expecting any significant changes from here on > out. Stephen, it looks like you have just replied with "Reviewed-bys" on all the remaining emails that you looked at. Is there anything else that we are missing? Or is this ready for Shuah to apply? [...] Cheers!