From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08FB3C3A5A2 for ; Fri, 20 Sep 2019 16:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD725208C3 for ; Fri, 20 Sep 2019 16:35:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ewmmEAJg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404286AbfITQfS (ORCPT ); Fri, 20 Sep 2019 12:35:18 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:38601 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbfITQfS (ORCPT ); Fri, 20 Sep 2019 12:35:18 -0400 Received: by mail-pl1-f195.google.com with SMTP id w10so3438563plq.5 for ; Fri, 20 Sep 2019 09:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ut91GscP6XLibdVcHru7hVB6OigJ1obwmaUA419NO4I=; b=ewmmEAJggE6Gu5gv9nuWkGHEl7zAqQAL51IBQ+0JuOcXfc4aJFK0Pg0lW0R1RpwPtA NHBNZhy1VI5QGpzQFyOn+PQ+uymEEZ+ymNbNzbHXYFl5gzryMC/DMMmV6HNqXX/FkpxU h4G3O2UU33dZCH/lSqL3V/EfLtt3oRbfuV6bTpGgrIqefOlDFJdd/mSS4sJrFu+LWb4T +C9WIq7JJP9uU1E1d3D153qm3dqqq+w65cvTcC7EgBv/CGhiaqNEeYLna+qk1zHVOG08 CUiUWaqT2L58txe5eAWCeMyuyutx0tiP11CzNW8Auzh6SmD1XfUeL9BkwOfGM4uXlxKz wEOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ut91GscP6XLibdVcHru7hVB6OigJ1obwmaUA419NO4I=; b=hC0dLRxu2jevpH1Js/L8BIedIskTxZPtPSTFRcFvSpVOY7f7ZAzboBbhv1QMhxm48b gM8AtkMs2SyTBCA7OSLRYzWakXhRl1b676Fts6S07nMrgOGczTlyzE0NqKskEhW9uWMj 7T5HeKDKhPnZV/E6R9Z5lKilfePk0yuKIGTWLWnF1S5iH3SSJG/oQgUGTmj7xXGSwWvO S9PbETlmP438RApwwkwo70bCMqZ3tcVeCUhQ4yBv1SIwiKt+Sg5qZapNMV365Xg1yg2o jRtNLkJL7gjTF6RiIxIdU8W4Z9ERYxwqhqT7h2ZyfJYK60yycctr/pZJjFO5eDzDFi06 Dbdg== X-Gm-Message-State: APjAAAUVjoMjEJ0lURpJFMQYtnNfyol1jk8FAeQhikQRVEyoHdfDANHe dS8JmAMZHUCa4Sa6667v/BnOirMH5oDDjl18Lzm73A== X-Google-Smtp-Source: APXvYqyclMRLHSpJm5RmBZhd2T6hJ6JBkUDAy5b6WWYCrTVqYKMdG4lpaeYsrmN2jjbgbq045mlPoSbQ7+GtMvBQ/cs= X-Received: by 2002:a17:902:ff0e:: with SMTP id f14mr18119782plj.325.1568997317338; Fri, 20 Sep 2019 09:35:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Brendan Higgins Date: Fri, 20 Sep 2019 09:35:06 -0700 Message-ID: Subject: Re: [GIT PULL] Kselftest update for Linux 5.4-rc1 To: Shuah Khan Cc: Linus Torvalds , Mark Brown , Jarkko Sakkinen , Anders Roxell , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Sep 20, 2019 at 9:27 AM Shuah Khan wrote: > > Hi Linus, > > On Fri, Sep 20, 2019, 10:18 AM Linus Torvalds wrote: >> >> On Tue, Sep 17, 2019 at 12:26 PM Shuah Khan wrote: >> > >> > This Kselftest update for Linux 5.4-rc1 consists of several fixes to >> > existing tests and adds KUnit, a lightweight unit testing and mocking >> > framework for the Linux kernel from Brendan Higgins. >> >> So I pulled this, but then I almost immediately unpulled it. >> >> My reason for doing that may be odd, but it's because of the top-level >> 'kunit' directory. This shouldn't be on the top level. >> >> The reason I react so strongly is that it actually breaks my finger >> memory. I don't type out filenames - I auto-compete them. So "kernel/" >> is "k", "drivers/" is "d" etc. >> >> It already doesn't work for everything ("mm/" is actually "mm" >> not because we have files in the git tree, but because the build >> creates various "module" files), but this breaks a common pattern for >> me. Sorry about that. I am surprised that none of the other reviewers brought this up. > On hindsight, I probably should have run this by you to get your feedback. > >> > In the future KUnit will be linked to Kselftest framework to provide >> > a way to trigger KUnit tests from user-space. >> >> Can the kernel parts please move to lib/kunit/ or something like that. I'm fine with lib/kunit/. > I will work with Brendan and come up with a plan and send another request early next week. Cheers