From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 789A2C3A59B for ; Fri, 30 Aug 2019 23:02:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3748523430 for ; Fri, 30 Aug 2019 23:02:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EYxkV44g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728187AbfH3XC0 (ORCPT ); Fri, 30 Aug 2019 19:02:26 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38197 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728111AbfH3XC0 (ORCPT ); Fri, 30 Aug 2019 19:02:26 -0400 Received: by mail-pl1-f194.google.com with SMTP id w11so4019032plp.5 for ; Fri, 30 Aug 2019 16:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WuSrKaBjz6ivWHwLFrJgF/L58VeUxzznRdGEYR+c17w=; b=EYxkV44gAiJ5RGYNjhQk6VbArVubnJW/4qj50Eu8EsglB+MFzheaW/0YM4soCMmUvy sBx6BCsU81MbaWrb+zExxv/sNrAWyhxZbGpG5nDfEGZ4nUDjLCxBqp+6G+LL+525lhlN HbokrROYgvVX1dBiCYW/M7kPYIrtL3VeLSKEN4SqEtlcOFqwEs2sTM4RIaUsHpqPOtJF ChT3acb5jJ3MDHbDXseFCZs8DkuC/cUStBiX5q3gu8fByUeNedQvJ0kytpmpRvGmxM23 mS3rHmTMIrL5iw5YAcFJDl6gOqJXnQ/WFaH0Nxyky0M5SYDCrBTjbkI+Y02q3Ihi/x7d rc+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WuSrKaBjz6ivWHwLFrJgF/L58VeUxzznRdGEYR+c17w=; b=LLzaK0ViBMEudpmU0ErEqgtQvHnmAb6I3MXhHIPCso7irfK0Afq7z9qLIh6G/C3mN4 oFxbJN15VNv8w0qkeMGr1nHeioBpPD3JUlZrbo41OoFL7zJduHCKinj3PfsBeR+etxE4 VYB/lHVWcmhYTJTVL3xOhrIroB1yN9wRI93ocLSTuso+srT48QRTuNsiZCvGxnvaPxhA JjLyH/iQjPZ14k1DROBE1jOmcfo2RKDqthfuAx0DlL0mm0b8PNU0Mfg0YuVCFFtXEDBr KpjrTI0xTYG0vZJI+hQIf4+qtrsiGIUJqNhomT9+ycy/wWX07ifMX+WTAxXFf2R59PNt l7Jg== X-Gm-Message-State: APjAAAV8Um0fTV9vko6y+CtKt3ITMo6miyqQGOoO87LTwhwianOGgpS/ ZnuGTE+gNB9oQUEIy4QjINLX1FUlBP/nFeIDzc5wSw== X-Google-Smtp-Source: APXvYqzkMlSCoOQPf0lhYF0++cQJXd6u59DjiL0h5Bj++9ubODi8+C2cl9McsvOTctf9UxMtNw30sqoEUw3WN7OcBu0= X-Received: by 2002:a17:902:169:: with SMTP id 96mr17348451plb.297.1567206144995; Fri, 30 Aug 2019 16:02:24 -0700 (PDT) MIME-Version: 1.0 References: <20190828093143.163302-1-brendanhiggins@google.com> <20190828094929.GA14038@jagdpanzerIV> <8b2d63bf-56cd-e8f5-e8ee-2891c2c1be8f@kernel.org> <20190830183821.GA30306@google.com> In-Reply-To: From: Brendan Higgins Date: Fri, 30 Aug 2019 16:02:13 -0700 Message-ID: Subject: Re: [PATCH v2] kunit: fix failure to build without printk To: Joe Perches Cc: "Bird, Timothy" , shuah , Sergey Senozhatsky , kunit-dev@googlegroups.com, Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Frank Rowand , Stephen Boyd , Petr Mladek , sergey.senozhatsky@gmail.com, Steven Rostedt , Randy Dunlap , Stephen Rothwell Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote: > > On Fri, 2019-08-30 at 21:58 +0000, Tim.Bird@sony.com wrote: > > > From: Joe Perches > [] > > IMHO %pV should be avoided if possible. Just because people are > > doing it doesn't mean it should be used when it is not necessary. > > Well, as the guy that created %pV, I of course > have a different opinion. > > > > then wouldn't it be easier to pass in the > > > > kernel level as a separate parameter and then strip off all printk > > > > headers like this: > > > > > > Depends on whether or not you care for overall > > > object size. Consolidated formats with the > > > embedded KERN_ like suggested are smaller > > > overall object size. > > > > This is an argument I can agree with. I'm generally in favor of > > things that lessen kernel size creep. :-) > > As am I. Sorry, to be clear, we are talking about the object size penalty due to adding a single parameter to a function. Is that right?