From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52BCC43331 for ; Fri, 8 Nov 2019 01:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D9022178F for ; Fri, 8 Nov 2019 01:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="o1RBKYxF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbfKHBHn (ORCPT ); Thu, 7 Nov 2019 20:07:43 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:41580 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfKHBHn (ORCPT ); Thu, 7 Nov 2019 20:07:43 -0500 Received: by mail-pl1-f195.google.com with SMTP id d29so2841905plj.8 for ; Thu, 07 Nov 2019 17:07:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vNYHIxb4w5wh5OJ2UcsY/rxFSYSM5NjM0g5yCBahmMM=; b=o1RBKYxFeem3vQdmMcb09c/Czaur5BjspbdukbuDfCPWavGuCZYv2d5eYk3lzUh5zm 64GDst1itnU6KFqzbvLptz0a7TprmbEIfrVlckuFFjVVhbFLt4noKjbjPsr0C2VT7zs7 oCXWMnTKo7jhXWG8Azi4vgX7U037o0KWgXiqfqk324fSvD+XVtYNGMlNsvtdRQlFlnzx XhjuZEhaqpSLjag1ZJGKxsH9Alr304AWYK1hlAREjI/7pwZH/cCON+gJC3eoMzy5jIvC XO2TvoGVoVH9G7xuHsfnddVQJF6HiX0rJKy4qOrdLFUwO9ViLCySgdXxB6CKMgB7DQ+x zuWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vNYHIxb4w5wh5OJ2UcsY/rxFSYSM5NjM0g5yCBahmMM=; b=fXQiqDmO85qrBSeWNrLBeJe8NQH2X+0NmQRXx/GUo64OP+fNqOGcjmfZfyAY70Aymn Epkwshlx9U+41CVOGgt4+/aFJS3kkXS6nooOnUSJKNUhjOO1FOyKgJJKrbqh0Y8p74eY RDrGBjXbHDJLEVrHePDYikqM6OV7Y/8hymK77Z5fJaI8P96n5D1OQIyrOr7sEQSmJgCN QX3zZ7yu7AXvPNELAQCgRpykpLKq4Ps5oopASDDx2ASahZvjwYt4VDCAXcgbwSIPoTGZ 533yzkuI8uxVsBSPYT4gtPxWEzsaKI6Ds5trsiUhjkn+HuwFOOEwadpElvoWzYa5Nf0b EATg== X-Gm-Message-State: APjAAAV7u2OO5mwZnbYZZi0uR7IvryOQCdSOo5/kAWg8JcFmdKHthQ0H 0oUvIDu3cklo3B0iBwYVlh2LLjtpvQ8HtlkpoyzffDl9leY= X-Google-Smtp-Source: APXvYqw+LoU/IiQ8hdHb0R4rY4nc0yI7TqoKto/BO3EMbJDNKkiWiBcBbg8Rvg4gxblStWoydjQcOZFgytKxwL5aXKY= X-Received: by 2002:a17:90a:252d:: with SMTP id j42mr9572203pje.131.1573175262439; Thu, 07 Nov 2019 17:07:42 -0800 (PST) MIME-Version: 1.0 References: <1571335639-21675-1-git-send-email-alan.maguire@oracle.com> <1571335639-21675-3-git-send-email-alan.maguire@oracle.com> In-Reply-To: <1571335639-21675-3-git-send-email-alan.maguire@oracle.com> From: Brendan Higgins Date: Thu, 7 Nov 2019 17:07:31 -0800 Message-ID: Subject: Re: [PATCH v3 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h To: Alan Maguire Cc: "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , KUnit Development , Kees Cook , Iurii Zaikin , Andrew Morton , Masahiro Yamada , catalin.marinas@arm.com, joe.lawrence@redhat.com, penguin-kernel@i-love.sakura.ne.jp, schowdary@nvidia.com, urezki@gmail.com, andriy.shevchenko@linux.intel.com, Jonathan Corbet , "open list:DOCUMENTATION" Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Oct 17, 2019 at 11:08 AM Alan Maguire wrote: > > also remove unused kunit_generic_try_catch > > Signed-off-by: Alan Maguire Reviewed-by: Brendan Higgins > --- > include/kunit/try-catch.h | 10 ---------- > lib/kunit/test-test.c | 1 + > lib/kunit/test.c | 1 + > lib/kunit/try-catch-impl.h | 23 +++++++++++++++++++++++ Just wanted to say that I *am* happy with the *-impl.h naming scheme here since there is a public header file with almost the same name. So everything looks good to me with this patch. > lib/kunit/try-catch.c | 1 + > 5 files changed, 26 insertions(+), 10 deletions(-) > create mode 100644 lib/kunit/try-catch-impl.h Thanks for the patch!