From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0364C33CA9 for ; Tue, 14 Jan 2020 02:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A84A220CC7 for ; Tue, 14 Jan 2020 02:19:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="C5RRpqXM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729238AbgANCTJ (ORCPT ); Mon, 13 Jan 2020 21:19:09 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:34513 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729164AbgANCTI (ORCPT ); Mon, 13 Jan 2020 21:19:08 -0500 Received: by mail-pj1-f68.google.com with SMTP id s94so429102pjc.1 for ; Mon, 13 Jan 2020 18:19:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I7aN7Y1nzik1KbsNshiwY6nugyBpWzW8lv7vF97PZQM=; b=C5RRpqXMfZpMtG14RRkraQFn1Sb5pbDBSB3Cb3uaNQfi/0xa0jM56TSKBtGYYLNo6n tWVPwTFEsCdF+47l7vtn4Fr1RnA6OJhuyLBDUrjWxQQ45xqZS4KPsPekcWf7md5BWqqN y4mtINZx/zEAi+nLD+ji9BLOfL2uI46y8ZAOK7cfFJuLd4mjK04x4Ln4RILVBD7LUPxu 67aj+1E82N427JNXgL467Ozglj20XYvWOSxrkp7QD/dF1/C6tlpKrtB0oay4HWoY6h1l 6powEnAq0H5y3mvCQXt1bNGGmpkQwichArkoOF08BCpu76t8xY9MMH04iAcDzbD1ZFQ0 +4oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I7aN7Y1nzik1KbsNshiwY6nugyBpWzW8lv7vF97PZQM=; b=SuQJq7deyafgXN4SAiFykfIBnsF00rr4BvZMMuAyoWqjBx6VVeoAkqdEky2yarvRan XA5tyZFY/zhjUzU6dfN/0dgUP9Fv/kJRz/qfEqZsCBRYlQ/WWxcOs9HNYxCWc+hGSzXT WyekEzo4k35HMiC8KRFsKE0TJzNwbBB400NJo9iBAyBS9aDwUqUcPHaWChtB8vgqtbsj KxUimLLttKXl46BJkiZzl4gZYaPR84gD81/2kvPimNLls9wfpGb52GmcXYOGDq76bZdE 3gmbniCbmvTrCas8K4lyOf9X1KJ0grnEvC2S4rpRa7yVYz0lSWC1gcvr7/I2mkR8/u2a 3xFQ== X-Gm-Message-State: APjAAAVCLrQzmwzi84T8LsCYSH63dherfPIEBzfkhTk9oYa2z/C6FnC0 0nJ83ZcRISabverbUT6ONoMCyDqlDhc033Twws9vhg== X-Google-Smtp-Source: APXvYqz+9AZOJJpTU34QiSXSYDhA2HUFGP93xod3rAKylUqbvfH/Pmt8P197RInxMERv7NI/gqMqrsXBuTOaZAiTkLM= X-Received: by 2002:a17:902:fe8d:: with SMTP id x13mr17804616plm.232.1578968347761; Mon, 13 Jan 2020 18:19:07 -0800 (PST) MIME-Version: 1.0 References: <1578656965-2993-1-git-send-email-alan.maguire@oracle.com> In-Reply-To: From: Brendan Higgins Date: Mon, 13 Jan 2020 18:18:56 -0800 Message-ID: Subject: Re: [PATCH kunit] kunit: building kunit as a module breaks allmodconfig To: Shuah Khan Cc: Alan Maguire , Greg KH , rafael@kernel.org, jmorris@namei.org, serge@hallyn.com, Knut Omang , Linux Kernel Mailing List , linux-security-module@vger.kernel.org, KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Stephen Rothwell Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Jan 10, 2020 at 1:39 PM Shuah Khan wrote: > > Hi Alan, > > On 1/10/20 4:49 AM, Alan Maguire wrote: > > kunit tests that do not support module build should depend > > on KUNIT=y rather than just KUNIT in Kconfig, otherwise > > they will trigger compilation errors for "make allmodconfig" > > builds. > > > > Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") > > Signed-off-by: Alan Maguire > > Reported-by: Stephen Rothwell > > Thanks for fixing this quickly. For future reference, Signed-off-by > should be last. I fixed it and applied the patch. Thanks everyone for taking care of this so quickly in my absence! Cheers