From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0064EC433FF for ; Tue, 13 Aug 2019 07:53:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C79D920665 for ; Tue, 13 Aug 2019 07:53:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nVz7SRzw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbfHMHxm (ORCPT ); Tue, 13 Aug 2019 03:53:42 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:35478 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727029AbfHMHxm (ORCPT ); Tue, 13 Aug 2019 03:53:42 -0400 Received: by mail-pf1-f196.google.com with SMTP id d85so629535pfd.2 for ; Tue, 13 Aug 2019 00:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1w6tEv+UsY5F/hdJoPjOc+8EZA8fHnLVH5Ee68+K+14=; b=nVz7SRzwhp+sIStWQOhdw7+eMounsWwWY4b9W+H2splMtvxXWG/v8uX0oyrPhi9Pc/ DbYNbNpkCoegNiTUpPMiXg34BXPrPJrAjoIA7DyPnMkZHZfSastxpDXvu6zpEH76cIXz 2ipKiw0wJIDxWMLZyrA5y40OVaB5InZkV31euGDTlfUD9NGVPd2AdaFiZI2HUpl+1Z71 eZE6OVlRYXpa7v0Ieb0+s2HPAU8hcA299XGRboiSsBb0Wz4QiBbaFXHTBKHp4dwxoDYm Lyn/gNUB2QMFaYgVWF7lBw/U70QsznbaxSpwZOVQK35ds3v4ks7lmHH71KHdUCsOoz7q RS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1w6tEv+UsY5F/hdJoPjOc+8EZA8fHnLVH5Ee68+K+14=; b=QmcFXQyXEB5A0mPqVbNiaV/9qftyOO5P4MpFZTXxYYEaLEDyrsEJvesjVGP5ZK4+UO Zw67LPExQH1L41n53uQUACJLc99bmJx0i8bqnLoe6KdB6P8MwaCvDtPwxc1IxAYngDOr iE6UDwKo5qyg+NaaNje7XAc+5+prtunoKGjrkVBOY1HH/SCFbcYoBVATXDTrHn3uoy+A 1pNTiVQ5/uru3Y+UyJhzvxtrEcJBT0p4yq/TY2sah9LrWsRR8At67GZgPUso5J+QVEZz B//AjZbVX3pPkxcEZEVbxHhlVhCUdo6naePtAlbfo+0LL3KdPdJzo7OinI7x27OAj8a5 6Drg== X-Gm-Message-State: APjAAAXf9XGr7knLP2Id/2nV/wy9rwdJJzTmoNtTv8PFNA54FimNuodN UKqqfRCaBfJaCRkzlm6q2VcMeVuX27EqyS43P/m2zQ== X-Google-Smtp-Source: APXvYqwRt249N6Nnc3lDOtyH2RE286o2POCGTN4Y9Dd+KQhTUzxvnzvxmCpITQmOohY+Myh1tvYfqlbmJVebyc0CKlY= X-Received: by 2002:a63:b919:: with SMTP id z25mr33087981pge.201.1565682820534; Tue, 13 Aug 2019 00:53:40 -0700 (PDT) MIME-Version: 1.0 References: <20190812182421.141150-1-brendanhiggins@google.com> <20190812182421.141150-11-brendanhiggins@google.com> <20190813042455.4A04320644@mail.kernel.org> <20190813055707.8B2BB206C2@mail.kernel.org> In-Reply-To: <20190813055707.8B2BB206C2@mail.kernel.org> From: Brendan Higgins Date: Tue, 13 Aug 2019 00:53:28 -0700 Message-ID: Subject: Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort To: Stephen Boyd Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , shuah , "Theodore Ts'o" , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Aug 12, 2019 at 10:57 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 22:06:04) > > On Mon, Aug 12, 2019 at 9:24 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-08-12 11:24:13) > > > > + > > > > +static int kunit_try_catch_test_init(struct kunit *test) > > > > +{ > > > > + struct kunit_try_catch_test_context *ctx; > > > > + > > > > + ctx = kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); > > > > > > Can this fail? Should return -ENOMEM in that case? > > > > Yes, I should do that. > > Looks like it's asserted to not be an error. If it's pushed into the API > then there's nothing to do here, and you can have my reviewed-by on this > patch. > > Reviewed-by: Stephen Boyd Cool, thanks!