From: Brendan Higgins <brendanhiggins@google.com>
To: David Gow <davidgow@google.com>
Cc: shuah <shuah@kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCH] Fix linked-list KUnit test when run multiple times
Date: Fri, 24 Jan 2020 16:02:30 -0800 [thread overview]
Message-ID: <CAFd5g45x3A2SdbUtZfGRGmpdEoe0BYsofRogyCXigR+xT_Jy=w@mail.gmail.com> (raw)
In-Reply-To: <CABVgOSnVLyOAYMi2eFaOXtm96SdmrO8hmJ4f2gKbDJ7wS_8d5w@mail.gmail.com>
On Fri, Jan 24, 2020 at 3:13 PM David Gow <davidgow@google.com> wrote:
>
> On Fri, Jan 24, 2020 at 2:01 PM Brendan Higgins
> <brendanhiggins@google.com> wrote:
> > Oh good, I am glad we are getting rid of those static variables. (I
> > thought we already dropped those - whoops.) I think this drops this
> > last of them, can you confirm David?
>
> Yeah, this is the last of them.
>
> I vaguely recall a suggestion that it may be worth testing that the
> LIST_HEAD() macro works with static, but as mentioned in the
> description, the for_each_entry_* tests probably aren't the best place
> to do that anyway...
Ah, I think I missed that. Makes sense.
prev parent reply other threads:[~2020-01-25 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 19:45 [PATCH] Fix linked-list KUnit test when run multiple times David Gow
2020-01-24 22:01 ` Brendan Higgins
2020-01-24 23:13 ` David Gow
2020-01-25 0:02 ` Brendan Higgins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g45x3A2SdbUtZfGRGmpdEoe0BYsofRogyCXigR+xT_Jy=w@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=alan.maguire@oracle.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).