Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] kunit: Fix kunit.py --raw_output option
@ 2020-10-22  3:04 David Gow
  2020-10-22  4:11 ` Brendan Higgins
  0 siblings, 1 reply; 3+ messages in thread
From: David Gow @ 2020-10-22  3:04 UTC (permalink / raw)
  To: Brendan Higgins, Shuah Khan
  Cc: kunit-dev, linux-kselftest, linux-kernel, David Gow

Due to the raw_output() function on kunit_parser.py actually being a
generator, it only runs if something reads the lines it returns. Since
we no-longer do that (parsing doesn't actually happen if raw_output is
enabled), it was not printing anything.

Fixes:	45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")
Signed-off-by: David Gow <davidgow@google.com>
---
 tools/testing/kunit/kunit_parser.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/kunit/kunit_parser.py b/tools/testing/kunit/kunit_parser.py
index 8019e3dd4c32..744ee9cb0073 100644
--- a/tools/testing/kunit/kunit_parser.py
+++ b/tools/testing/kunit/kunit_parser.py
@@ -66,7 +66,6 @@ def isolate_kunit_output(kernel_output):
 def raw_output(kernel_output):
 	for line in kernel_output:
 		print(line)
-		yield line
 
 DIVIDER = '=' * 60
 
-- 
2.29.0.rc1.297.gfa9743e501-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kunit: Fix kunit.py --raw_output option
  2020-10-22  3:04 [PATCH] kunit: Fix kunit.py --raw_output option David Gow
@ 2020-10-22  4:11 ` Brendan Higgins
  2020-10-26 19:31   ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Brendan Higgins @ 2020-10-22  4:11 UTC (permalink / raw)
  To: David Gow
  Cc: Shuah Khan, KUnit Development,
	open list:KERNEL SELFTEST FRAMEWORK, Linux Kernel Mailing List

On Wed, Oct 21, 2020 at 8:05 PM David Gow <davidgow@google.com> wrote:
>
> Due to the raw_output() function on kunit_parser.py actually being a
> generator, it only runs if something reads the lines it returns. Since
> we no-longer do that (parsing doesn't actually happen if raw_output is
> enabled), it was not printing anything.
>
> Fixes:  45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")
> Signed-off-by: David Gow <davidgow@google.com>

Thanks for fixing this!

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kunit: Fix kunit.py --raw_output option
  2020-10-22  4:11 ` Brendan Higgins
@ 2020-10-26 19:31   ` Shuah Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2020-10-26 19:31 UTC (permalink / raw)
  To: Brendan Higgins, David Gow
  Cc: KUnit Development, open list:KERNEL SELFTEST FRAMEWORK,
	Linux Kernel Mailing List, Shuah Khan

On 10/21/20 10:11 PM, Brendan Higgins wrote:
> On Wed, Oct 21, 2020 at 8:05 PM David Gow <davidgow@google.com> wrote:
>>
>> Due to the raw_output() function on kunit_parser.py actually being a
>> generator, it only runs if something reads the lines it returns. Since
>> we no-longer do that (parsing doesn't actually happen if raw_output is
>> enabled), it was not printing anything.
>>
>> Fixes:  45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")

You need just the SHA1 45ba7a893ad8

Fixed this up and applied to linux-kselftest kunit-fixes branch


>> Signed-off-by: David Gow <davidgow@google.com>
> 
> Thanks for fixing this!
> 
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> Tested-by: Brendan Higgins <brendanhiggins@google.com>
> 

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22  3:04 [PATCH] kunit: Fix kunit.py --raw_output option David Gow
2020-10-22  4:11 ` Brendan Higgins
2020-10-26 19:31   ` Shuah Khan

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git