From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 705BDC433FF for ; Tue, 13 Aug 2019 05:06:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DE2C206C2 for ; Tue, 13 Aug 2019 05:06:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Y+dmDban" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726650AbfHMFGR (ORCPT ); Tue, 13 Aug 2019 01:06:17 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:35490 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfHMFGQ (ORCPT ); Tue, 13 Aug 2019 01:06:16 -0400 Received: by mail-pf1-f195.google.com with SMTP id d85so386458pfd.2 for ; Mon, 12 Aug 2019 22:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Abf3cK9D+gRrRGwQh2kwak/YzDDkHOqgDtvVTIo4q7A=; b=Y+dmDbanwPRKrcGCv4/WQS9jtPyx6cpYSiNcTCluUKOVyeyn7wl8RZe0u1cf6FlML6 wfRe3v8dcFvKIShJjXRgh8cEGNhzCFLCfZTUSJEGO2Ea0/S9/l8EIDzT2hfdmu4vYl3/ XIR90pnuI3K4kV1d5Bm11Pn57c+GfE4dVDOOxOsnLShgWMYlA1pJcJoF7sOPZtexCwYP ELhxZQwrFnEmjZhgXx2mjuE3HiLK9TadecMdLzAo0eHIWgo1V1G1uOa5P7ZTv3NrW55Q IwxyHJePJisriyJmWo1d+yNh53aHnfmOSYFZCbC26Ph2JuMFkmU8c4wQttP2Gfux7zEx HKsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Abf3cK9D+gRrRGwQh2kwak/YzDDkHOqgDtvVTIo4q7A=; b=pPFXPUlJdrGZUVImJsO/mR8YhjYHe8AR2137grdo9wTLZfJfBgtjLikH9yIH1fAuG6 cqNIk+C/mftxUEykL6h7QSgV7L7eKw3OwhA4UFK+H4hLi0MFdTiprZtgvUrWldncF5ay GCjX/8P6B5KOW88habeexbCU37lZj2yv8sJFUCrPB5l0A4aMxAqb2J/Wtp1K/9b1+tUv oF6qqpr5FsYyW2xf0p1EMjbtoP6OPVsUbOKIw4348o6U0cXfOac4UbCTWPI0SKhbN5fK 12RwIDaRYn+Q37+OHF1nXwmmZn07BiNLtg+NOrh89LDw7W9oorvAqyY0czTpuRfPdEZl 98sA== X-Gm-Message-State: APjAAAXnLMTguj0LAN5bgqHXqnsXEVqjyKXrgnuyEcRfxlXJ6u6DMzFI HDOZ1ohFoQ+sPw8D9rSOpIFw43nlyRq6RW2QD+C31A== X-Google-Smtp-Source: APXvYqzlm/LZa7vLxmhuF4EQXYFyYKJYlrIat9BhnUUptmEmQR49KGysQZ4JhDoNNZWx7O5yEaH2e2yfA6hMO6s/qoE= X-Received: by 2002:a63:205f:: with SMTP id r31mr30781941pgm.159.1565672775425; Mon, 12 Aug 2019 22:06:15 -0700 (PDT) MIME-Version: 1.0 References: <20190812182421.141150-1-brendanhiggins@google.com> <20190812182421.141150-11-brendanhiggins@google.com> <20190813042455.4A04320644@mail.kernel.org> In-Reply-To: <20190813042455.4A04320644@mail.kernel.org> From: Brendan Higgins Date: Mon, 12 Aug 2019 22:06:04 -0700 Message-ID: Subject: Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort To: Stephen Boyd Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , shuah , "Theodore Ts'o" , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Aug 12, 2019 at 9:24 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:13) > > + > > +static int kunit_try_catch_test_init(struct kunit *test) > > +{ > > + struct kunit_try_catch_test_context *ctx; > > + > > + ctx = kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); > > Can this fail? Should return -ENOMEM in that case? Yes, I should do that. > > + test->priv = ctx; > > + > > + ctx->try_catch = kunit_kmalloc(test, > > + sizeof(*ctx->try_catch), > > + GFP_KERNEL);