* [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests
@ 2020-10-16 11:08 Andy Shevchenko
2020-10-16 11:08 ` [PATCH v3 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Andy Shevchenko @ 2020-10-16 11:08 UTC (permalink / raw)
To: linux-kselftest, Brendan Higgins, kunit-dev, Shuah Khan,
Vitor Massaru Iha
Cc: Andy Shevchenko, Mark Brown, David Gow
Follow new file name convention for the KUnit tests.
Since we have lib/*test*.c in a few variations,
use 'kunit' suffix to distinguish usual test cases
with KUnit-based ones.
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: David Gow <davidgow@google.com>
---
v3: added Rb (David), expanded Cc (Mark)
MAINTAINERS | 2 +-
lib/Makefile | 2 +-
lib/{list-test.c => list_kunit.c} | 0
3 files changed, 2 insertions(+), 2 deletions(-)
rename lib/{list-test.c => list_kunit.c} (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4538378de6f5..20facbca9388 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10188,7 +10188,7 @@ M: David Gow <davidgow@google.com>
L: linux-kselftest@vger.kernel.org
L: kunit-dev@googlegroups.com
S: Maintained
-F: lib/list-test.c
+F: lib/list_kunit.c
LIVE PATCHING
M: Josh Poimboeuf <jpoimboe@redhat.com>
diff --git a/lib/Makefile b/lib/Makefile
index 5ca03ba6ee45..1a5e6a6ebe8d 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
# KUnit tests
obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
-obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
+obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
obj-$(CONFIG_BITS_TEST) += test_bits.o
diff --git a/lib/list-test.c b/lib/list_kunit.c
similarity index 100%
rename from lib/list-test.c
rename to lib/list_kunit.c
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 2/3] lib/linear_ranges_kunit: Follow new file name convention for KUnit tests
2020-10-16 11:08 [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
@ 2020-10-16 11:08 ` Andy Shevchenko
2020-10-16 16:07 ` Mark Brown
2020-10-16 11:08 ` [PATCH v3 3/3] lib/bits_kunit: " Andy Shevchenko
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2020-10-16 11:08 UTC (permalink / raw)
To: linux-kselftest, Brendan Higgins, kunit-dev, Shuah Khan,
Vitor Massaru Iha
Cc: Andy Shevchenko, Mark Brown, Matti Vaittinen, David Gow
Follow new file name convention for the KUnit tests.
Since we have lib/*test*.c in a few variations,
use 'kunit' suffix to distinguish usual test cases
with KUnit-based ones.
Cc: Mark Brown <broonie@kernel.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: David Gow <davidgow@google.com>
---
v3: added Rb (David)
MAINTAINERS | 3 +--
lib/Makefile | 2 +-
lib/{test_linear_ranges.c => linear_ranges_kunit.c} | 0
3 files changed, 2 insertions(+), 3 deletions(-)
rename lib/{test_linear_ranges.c => linear_ranges_kunit.c} (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 20facbca9388..249417a036f9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10069,8 +10069,7 @@ F: include/uapi/linux/lightnvm.h
LINEAR RANGES HELPERS
M: Mark Brown <broonie@kernel.org>
R: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
-F: lib/linear_ranges.c
-F: lib/test_linear_ranges.c
+F: lib/linear_ranges*.c
F: include/linux/linear_range.h
LINUX FOR POWER MACINTOSH
diff --git a/lib/Makefile b/lib/Makefile
index 1a5e6a6ebe8d..5c18519d6733 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
# KUnit tests
obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
+obj-$(CONFIG_LINEAR_RANGES_TEST) += linear_ranges_kunit.o
obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
-obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
obj-$(CONFIG_BITS_TEST) += test_bits.o
diff --git a/lib/test_linear_ranges.c b/lib/linear_ranges_kunit.c
similarity index 100%
rename from lib/test_linear_ranges.c
rename to lib/linear_ranges_kunit.c
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 3/3] lib/bits_kunit: Follow new file name convention for KUnit tests
2020-10-16 11:08 [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
2020-10-16 11:08 ` [PATCH v3 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
@ 2020-10-16 11:08 ` Andy Shevchenko
2020-10-20 20:55 ` Brendan Higgins
2020-10-20 20:55 ` [PATCH v3 1/3] lib/list_kunit: " Brendan Higgins
2020-10-30 19:50 ` Andy Shevchenko
3 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2020-10-16 11:08 UTC (permalink / raw)
To: linux-kselftest, Brendan Higgins, kunit-dev, Shuah Khan,
Vitor Massaru Iha
Cc: Andy Shevchenko, Mark Brown, David Gow
Follow new file name convention for the KUnit tests.
Since we have lib/*test*.c in a few variations,
use 'kunit' suffix to distinguish usual test cases
with KUnit-based ones.
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: David Gow <davidgow@google.com>
---
v3: added Rb (David), expanded Cc (Mark)
lib/Makefile | 2 +-
lib/{test_bits.c => bits_kunit.c} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename lib/{test_bits.c => bits_kunit.c} (100%)
diff --git a/lib/Makefile b/lib/Makefile
index 5c18519d6733..70a4a21ff5d6 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
# KUnit tests
obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
+obj-$(CONFIG_BITS_TEST) += bits_kunit.o
obj-$(CONFIG_LINEAR_RANGES_TEST) += linear_ranges_kunit.o
obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
-obj-$(CONFIG_BITS_TEST) += test_bits.o
diff --git a/lib/test_bits.c b/lib/bits_kunit.c
similarity index 100%
rename from lib/test_bits.c
rename to lib/bits_kunit.c
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 2/3] lib/linear_ranges_kunit: Follow new file name convention for KUnit tests
2020-10-16 11:08 ` [PATCH v3 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
@ 2020-10-16 16:07 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-10-16 16:07 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kselftest, Brendan Higgins, kunit-dev, Shuah Khan,
Vitor Massaru Iha, Matti Vaittinen, David Gow
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Fri, Oct 16, 2020 at 02:08:35PM +0300, Andy Shevchenko wrote:
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests
2020-10-16 11:08 [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
2020-10-16 11:08 ` [PATCH v3 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
2020-10-16 11:08 ` [PATCH v3 3/3] lib/bits_kunit: " Andy Shevchenko
@ 2020-10-20 20:55 ` Brendan Higgins
2020-10-30 19:50 ` Andy Shevchenko
3 siblings, 0 replies; 7+ messages in thread
From: Brendan Higgins @ 2020-10-20 20:55 UTC (permalink / raw)
To: Andy Shevchenko
Cc: open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
Shuah Khan, Vitor Massaru Iha, Mark Brown, David Gow
On Fri, Oct 16, 2020 at 4:08 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: David Gow <davidgow@google.com>
Thanks for taking care of this!
Acked-by: Brendan Higgins <brendanhiggins@google.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 3/3] lib/bits_kunit: Follow new file name convention for KUnit tests
2020-10-16 11:08 ` [PATCH v3 3/3] lib/bits_kunit: " Andy Shevchenko
@ 2020-10-20 20:55 ` Brendan Higgins
0 siblings, 0 replies; 7+ messages in thread
From: Brendan Higgins @ 2020-10-20 20:55 UTC (permalink / raw)
To: Andy Shevchenko
Cc: open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
Shuah Khan, Vitor Massaru Iha, Mark Brown, David Gow
On Fri, Oct 16, 2020 at 4:08 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: David Gow <davidgow@google.com>
Acked-by: Brendan Higgins <brendanhiggins@google.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests
2020-10-16 11:08 [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
` (2 preceding siblings ...)
2020-10-20 20:55 ` [PATCH v3 1/3] lib/list_kunit: " Brendan Higgins
@ 2020-10-30 19:50 ` Andy Shevchenko
3 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2020-10-30 19:50 UTC (permalink / raw)
To: linux-kselftest, Brendan Higgins, kunit-dev, Shuah Khan,
Vitor Massaru Iha
Cc: Mark Brown, David Gow
On Fri, Oct 16, 2020 at 02:08:34PM +0300, Andy Shevchenko wrote:
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.
Can we get this applied?
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: David Gow <davidgow@google.com>
> ---
> v3: added Rb (David), expanded Cc (Mark)
> MAINTAINERS | 2 +-
> lib/Makefile | 2 +-
> lib/{list-test.c => list_kunit.c} | 0
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename lib/{list-test.c => list_kunit.c} (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4538378de6f5..20facbca9388 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10188,7 +10188,7 @@ M: David Gow <davidgow@google.com>
> L: linux-kselftest@vger.kernel.org
> L: kunit-dev@googlegroups.com
> S: Maintained
> -F: lib/list-test.c
> +F: lib/list_kunit.c
>
> LIVE PATCHING
> M: Josh Poimboeuf <jpoimboe@redhat.com>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5ca03ba6ee45..1a5e6a6ebe8d 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
>
> # KUnit tests
> obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
> -obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> +obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
> obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> obj-$(CONFIG_BITS_TEST) += test_bits.o
> diff --git a/lib/list-test.c b/lib/list_kunit.c
> similarity index 100%
> rename from lib/list-test.c
> rename to lib/list_kunit.c
> --
> 2.28.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-30 19:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 11:08 [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
2020-10-16 11:08 ` [PATCH v3 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
2020-10-16 16:07 ` Mark Brown
2020-10-16 11:08 ` [PATCH v3 3/3] lib/bits_kunit: " Andy Shevchenko
2020-10-20 20:55 ` Brendan Higgins
2020-10-20 20:55 ` [PATCH v3 1/3] lib/list_kunit: " Brendan Higgins
2020-10-30 19:50 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).