Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function
@ 2019-11-27 23:19 Heidi Fahim
  2019-11-27 23:58 ` Heidi Fahim
  2019-12-02 17:09 ` Brendan Higgins
  0 siblings, 2 replies; 4+ messages in thread
From: Heidi Fahim @ 2019-11-27 23:19 UTC (permalink / raw)
  To: brendanhiggins, davidgow, shuah
  Cc: sj38.park, linux-kselftest, kunit-dev, linux-kernel, Heidi Fahim

Assert in test_run_timeout was not updated with the build_dir argument
and caused the following error:
AssertionError: Expected call: run_kernel(timeout=3453)
Actual call: run_kernel(build_dir=None, timeout=3453)

Needed to update kunit_tool_test to reflect this fix
https://lkml.org/lkml/2019/9/6/3

Signed-off-by: Heidi Fahim <heidifahim@google.com>
Change-Id: I6f161c72c6a5f071a4dc31582ba08b91974502ce
---
 tools/testing/kunit/kunit_tool_test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py
index 4a12baa0cd4e..a2a8ea6beae3 100755
--- a/tools/testing/kunit/kunit_tool_test.py
+++ b/tools/testing/kunit/kunit_tool_test.py
@@ -199,7 +199,7 @@ class KUnitMainTest(unittest.TestCase):
 		timeout = 3453
 		kunit.main(['run', '--timeout', str(timeout)], self.linux_source_mock)
 		assert self.linux_source_mock.build_reconfig.call_count == 1
-		self.linux_source_mock.run_kernel.assert_called_once_with(timeout=timeout)
+		self.linux_source_mock.run_kernel.assert_called_once_with(build_dir=None, timeout=timeout)
 		self.print_mock.assert_any_call(StrContains('Testing complete.'))
 
 if __name__ == '__main__':
-- 
2.24.0.432.g9d3f5f5b63-goog


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function
  2019-11-27 23:19 [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function Heidi Fahim
@ 2019-11-27 23:58 ` Heidi Fahim
  2019-12-01 21:10   ` SeongJae Park
  2019-12-02 17:09 ` Brendan Higgins
  1 sibling, 1 reply; 4+ messages in thread
From: Heidi Fahim @ 2019-11-27 23:58 UTC (permalink / raw)
  To: Brendan Higgins, David Gow, shuah
  Cc: sj38.park, linux-kselftest, kunit-dev, linux-kernel

On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote:
>
> Assert in test_run_timeout was not updated with the build_dir argument
> and caused the following error:
> AssertionError: Expected call: run_kernel(timeout=3453)
> Actual call: run_kernel(build_dir=None, timeout=3453)
>
> Needed to update kunit_tool_test to reflect this fix
> https://lkml.org/lkml/2019/9/6/3

Wrong url, here is the correct link to the fix that caused this bug:
https://lkml.org/lkml/2019/9/6/351

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function
  2019-11-27 23:58 ` Heidi Fahim
@ 2019-12-01 21:10   ` SeongJae Park
  0 siblings, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2019-12-01 21:10 UTC (permalink / raw)
  To: Heidi Fahim
  Cc: Brendan Higgins, David Gow, Shuah Khan,
	open list:KERNEL SELFTEST FRAMEWORK, kunit-dev, LKML

On Thu, Nov 28, 2019 at 12:58 AM Heidi Fahim <heidifahim@google.com> wrote:
>
> On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote:
> >
> > Assert in test_run_timeout was not updated with the build_dir argument
> > and caused the following error:
> > AssertionError: Expected call: run_kernel(timeout=3453)
> > Actual call: run_kernel(build_dir=None, timeout=3453)
> >
> > Needed to update kunit_tool_test to reflect this fix
> > https://lkml.org/lkml/2019/9/6/3
>
> Wrong url, here is the correct link to the fix that caused this bug:
> https://lkml.org/lkml/2019/9/6/351

Reviewed-by: SeongJae Park <sjpark@amazon.de>


Thanks,
SeongJae Park

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function
  2019-11-27 23:19 [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function Heidi Fahim
  2019-11-27 23:58 ` Heidi Fahim
@ 2019-12-02 17:09 ` Brendan Higgins
  1 sibling, 0 replies; 4+ messages in thread
From: Brendan Higgins @ 2019-12-02 17:09 UTC (permalink / raw)
  To: Heidi Fahim
  Cc: David Gow, shuah, SeongJae Park,
	open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Linux Kernel Mailing List

On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote:
>
> Assert in test_run_timeout was not updated with the build_dir argument
> and caused the following error:
> AssertionError: Expected call: run_kernel(timeout=3453)
> Actual call: run_kernel(build_dir=None, timeout=3453)
>
> Needed to update kunit_tool_test to reflect this fix
> https://lkml.org/lkml/2019/9/6/3
>
> Signed-off-by: Heidi Fahim <heidifahim@google.com>
> Change-Id: I6f161c72c6a5f071a4dc31582ba08b91974502ce

Change-Id should not be used on LKML patches. Did you run checkpatch?

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 23:19 [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function Heidi Fahim
2019-11-27 23:58 ` Heidi Fahim
2019-12-01 21:10   ` SeongJae Park
2019-12-02 17:09 ` Brendan Higgins

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git