From: Brendan Higgins <brendanhiggins@google.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: shuah <shuah@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SeongJae Park <sjpark@amazon.de>
Subject: Re: [PATCH 4/6] kunit: Create default config in 'build_dir'
Date: Mon, 2 Dec 2019 22:40:49 -0800 [thread overview]
Message-ID: <CAFd5g46bb_46dCpu3t=qT0FMqifS8wodnhjWC7jfpkuhT1ngAQ@mail.gmail.com> (raw)
In-Reply-To: <1575242724-4937-5-git-send-email-sj38.park@gmail.com>
On Sun, Dec 1, 2019 at 3:25 PM SeongJae Park <sj38.park@gmail.com> wrote:
>
> From: SeongJae Park <sjpark@amazon.de>
>
> If both '--build_dir' and '--defconfig' are given, the handling of
> '--defconfig' ignores '--build_dir' option. This commit modifies the
> behavior to respect '--build_dir' option.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
> tools/testing/kunit/kunit.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
> index f8f2695..1746330 100755
> --- a/tools/testing/kunit/kunit.py
> +++ b/tools/testing/kunit/kunit.py
> @@ -114,6 +114,11 @@ def main(argv, linux=None):
> cli_args = parser.parse_args(argv)
>
> if cli_args.subcommand == 'run':
> + if cli_args.build_dir:
> + kunit_kernel.KUNITCONFIG_PATH = os.path.join(
If you are going to modify the value of KUNITCONFIG_PATH can you
rename the variable to make it lower_snake_case? UPPER_SNAKE_CASE in
Python is usually (at least in this directory) used to indicate the
variable is a constant.
> + cli_args.build_dir,
> + kunit_kernel.KUNITCONFIG_PATH)
> +
> if cli_args.defconfig:
> create_default_kunitconfig()
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-12-03 6:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 23:25 [PATCH 0/6] Fix nits in the kunit SeongJae Park
2019-12-01 23:25 ` [PATCH 1/6] docs/kunit/start: Use in-tree 'kunit_defconfig' SeongJae Park
2019-12-02 17:13 ` Brendan Higgins
2019-12-01 23:25 ` [PATCH 2/6] docs/kunit/start: Skip wrapper run command SeongJae Park
2019-12-02 17:25 ` Brendan Higgins
2019-12-02 20:59 ` SeongJae Park
2019-12-03 8:27 ` SeongJae Park
2019-12-02 21:03 ` David Gow
2019-12-02 21:09 ` SeongJae Park
2019-12-01 23:25 ` [PATCH 3/6] kunit: Remove duplicated defconfig creation SeongJae Park
2019-12-02 17:27 ` Brendan Higgins
2019-12-01 23:25 ` [PATCH 4/6] kunit: Create default config in 'build_dir' SeongJae Park
2019-12-03 6:40 ` Brendan Higgins [this message]
2019-12-03 8:28 ` SeongJae Park
2019-12-01 23:25 ` [PATCH 5/6] kunit: Place 'test.log' under the 'build_dir' SeongJae Park
2019-12-03 6:48 ` Brendan Higgins
2019-12-01 23:25 ` [PATCH 6/6] kunit: Rename 'kunitconfig' to '.kunitconfig' SeongJae Park
2019-12-03 7:00 ` [PATCH 0/6] Fix nits in the kunit Brendan Higgins
2019-12-03 7:10 ` SeongJae Park
2019-12-03 8:25 ` SeongJae Park
2019-12-03 17:45 ` Brendan Higgins
2019-12-03 18:10 ` SeongJae Park
2019-12-03 22:35 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g46bb_46dCpu3t=qT0FMqifS8wodnhjWC7jfpkuhT1ngAQ@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).