From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F841C32750 for ; Tue, 13 Aug 2019 05:03:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7383F206C2 for ; Tue, 13 Aug 2019 05:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="svgoSdNR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbfHMFDz (ORCPT ); Tue, 13 Aug 2019 01:03:55 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:39904 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbfHMFDz (ORCPT ); Tue, 13 Aug 2019 01:03:55 -0400 Received: by mail-pl1-f196.google.com with SMTP id z3so1951747pln.6 for ; Mon, 12 Aug 2019 22:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aKOfFTV6VGP5BNUB1Vnarc/F0DL+26vq0829FAbZrqo=; b=svgoSdNRxSLsCnnIOc7xbQg9GgF9oKMJ1Zy9kd11vWwaKXoOnKpb4m3E5VD5iVlgYD +Q8GW61vmO7pSODND/EU3ySpZFU6zBm/nnzXrEdbXjYeyp0z5HZ4MlPGEFDVamV7AnNt YxSzN7MGuqE5YtmeQLv8pM8cwjVoHM11Q7HgFuNs7NBSHTrEDEHtBfVlPMX1tM122Zoh /lJWbiyvCy294xIaxGNy1x0QeVRdkekMXrwW6vrlb0zY+yiiNnJIqQVHv78TipzeF0fL lbgrIbrBSmtQjgptdFMq0Sq8pSiArBm+sF/Wu+BeNyqHXo/vQXv7UP+JqfWMmgemFjSH IU5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aKOfFTV6VGP5BNUB1Vnarc/F0DL+26vq0829FAbZrqo=; b=HIBXOhztYKrDPC8sZrx9xv3bnJVzDqIJFXQ0039kE5kVzf14s2mOtejUfzliuoR5r6 U2IMRrVjCHjewkq4M7/4wPZ+DYutuzvWN5ICUwXWsU3dIrWFXRuht37i2QK1HMfXWPV1 bIoreRpdFPhyy4i+xhWGrKca9tEDFKgNxeB3FNlpfLpnFAUZOC1i5se0LWCd5sAccgH7 PGFgTDrptDb1+P73M/hQRlT5Ts5Km8cxzfPzl5Jwj4UCvxAYR3e7//qpTHx77G6ZRMAc y2eCMsqnoIcmlzPTz8jyzp/9kiAq6tbFkfqI780FL240/ePwQrY/jSISRES+eam/ts5o NDyw== X-Gm-Message-State: APjAAAUgUUMmwBJThG+qR1PH+EEJBTtt2CILE8xA0mELYld5DJJNI4kO Ew30W5qnIk1B7rQg7MwrfxysGf+ngxLBhTtGg0o/Qg== X-Google-Smtp-Source: APXvYqwgOw9EQ70Umy0oEnQ5G5LCL6qyMyWjnNbSVpHRs20m04I8HxLTnoiIjpuTiP19er8DvO/pyE/cwQSXqDyWk+Y= X-Received: by 2002:a17:902:5983:: with SMTP id p3mr26758654pli.232.1565672634067; Mon, 12 Aug 2019 22:03:54 -0700 (PDT) MIME-Version: 1.0 References: <20190812182421.141150-1-brendanhiggins@google.com> <20190812182421.141150-5-brendanhiggins@google.com> <20190812234644.E054D20679@mail.kernel.org> <20190813045747.3AF0A206C2@mail.kernel.org> In-Reply-To: <20190813045747.3AF0A206C2@mail.kernel.org> From: Brendan Higgins Date: Mon, 12 Aug 2019 22:03:42 -0700 Message-ID: Subject: Re: [PATCH v12 04/18] kunit: test: add assertion printing library To: Stephen Boyd Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , shuah , "Theodore Ts'o" , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Aug 12, 2019 at 9:57 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 21:27:05) > > On Mon, Aug 12, 2019 at 4:56 PM Brendan Higgins > > wrote: > > > > > > On Mon, Aug 12, 2019 at 4:46 PM Stephen Boyd wrote: > > > > > > > > Quoting Brendan Higgins (2019-08-12 11:24:07) > > > > > +#define KUNIT_INIT_FAIL_ASSERT_STRUCT(test, type) { \ > > > > > + .assert = KUNIT_INIT_ASSERT_STRUCT(test, \ > > > > > + type, \ > > > > > + kunit_fail_assert_format) \ > > > > > > > > This one got indented one too many times? > > > > > > Not unless I have been using the wrong formatting for multiline > > > macros. You can see this commit applied here: > > > https://kunit.googlesource.com/linux/+/870964da2990920030990dd1ffb647ef408e52df/include/kunit/assert.h#59 > > > > > > I have test, type, and kunit_fail_assert_format all column aligned (it > > > just doesn't render nicely in the patch format). > > > > Disregard that last comment. I just looked at the line immediately > > above your comment and thought it looked correct. Sorry about that > > (you were pointing out that the .assert line looked wrong, correct?). > > Yes. .assert is double tabbed? Yes it is. Sorry about the confusion. Will fix.