* [PATCH v2] kunit: testing kunit: Bug fix in test_run_timeout function
@ 2019-12-02 23:53 Heidi Fahim
2019-12-03 6:16 ` Brendan Higgins
0 siblings, 1 reply; 2+ messages in thread
From: Heidi Fahim @ 2019-12-02 23:53 UTC (permalink / raw)
To: brendanhiggins, davidgow, shuah
Cc: sj38.park, linux-kselftest, kunit-dev, linux-kernel, Heidi Fahim,
SeongJae Park
Assert in test_run_timeout was not updated with the build_dir argument
and caused the following error:
AssertionError: Expected call: run_kernel(timeout=3453)
Actual call: run_kernel(build_dir=None, timeout=3453)
Needed to update kunit_tool_test to reflect this fix
https://lkml.org/lkml/2019/9/6/351
Signed-off-by: Heidi Fahim <heidifahim@google.com>
Reviewed-by: SeongJae Park <sjpark@amazon.de>
---
tools/testing/kunit/kunit_tool_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py
index 4a12baa0cd4e..a2a8ea6beae3 100755
--- a/tools/testing/kunit/kunit_tool_test.py
+++ b/tools/testing/kunit/kunit_tool_test.py
@@ -199,7 +199,7 @@ class KUnitMainTest(unittest.TestCase):
timeout = 3453
kunit.main(['run', '--timeout', str(timeout)], self.linux_source_mock)
assert self.linux_source_mock.build_reconfig.call_count == 1
- self.linux_source_mock.run_kernel.assert_called_once_with(timeout=timeout)
+ self.linux_source_mock.run_kernel.assert_called_once_with(build_dir=None, timeout=timeout)
self.print_mock.assert_any_call(StrContains('Testing complete.'))
if __name__ == '__main__':
--
2.24.0.393.g34dc348eaf-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] kunit: testing kunit: Bug fix in test_run_timeout function
2019-12-02 23:53 [PATCH v2] kunit: testing kunit: Bug fix in test_run_timeout function Heidi Fahim
@ 2019-12-03 6:16 ` Brendan Higgins
0 siblings, 0 replies; 2+ messages in thread
From: Brendan Higgins @ 2019-12-03 6:16 UTC (permalink / raw)
To: Heidi Fahim, shuah
Cc: David Gow, SeongJae Park, open list:KERNEL SELFTEST FRAMEWORK,
KUnit Development, Linux Kernel Mailing List, SeongJae Park
On Mon, Dec 2, 2019 at 3:53 PM Heidi Fahim <heidifahim@google.com> wrote:
>
> Assert in test_run_timeout was not updated with the build_dir argument
> and caused the following error:
> AssertionError: Expected call: run_kernel(timeout=3453)
> Actual call: run_kernel(build_dir=None, timeout=3453)
>
> Needed to update kunit_tool_test to reflect this fix
> https://lkml.org/lkml/2019/9/6/351
>
> Signed-off-by: Heidi Fahim <heidifahim@google.com>
> Reviewed-by: SeongJae Park <sjpark@amazon.de>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>
Heidi, thanks for taking care of this!
Shuah, can we make sure to get this in as a v5.5 fix?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-03 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 23:53 [PATCH v2] kunit: testing kunit: Bug fix in test_run_timeout function Heidi Fahim
2019-12-03 6:16 ` Brendan Higgins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).