From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724A3C3524B for ; Tue, 4 Feb 2020 22:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 469902082E for ; Tue, 4 Feb 2020 22:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="icGZp+gW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727500AbgBDWfm (ORCPT ); Tue, 4 Feb 2020 17:35:42 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:39856 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727654AbgBDWfm (ORCPT ); Tue, 4 Feb 2020 17:35:42 -0500 Received: by mail-pj1-f67.google.com with SMTP id e9so57103pjr.4 for ; Tue, 04 Feb 2020 14:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wW0tjd+cBxeR6/lhPUUjx0fEpBoP1LYYTT0FsIiI1ho=; b=icGZp+gWX8+ra8EaRzj0omZeGdmp0NxlbomRJ1M8RaU/WQNP+zqgYuJZSPFcaiWcnZ 2pCWkyEpTMGGCi9alcZbNMp01PJ6HAZzwmE6trVB6wWJfukGW4fmAYtsgfiXedtOqqRT bmFSWApPulYRdVfiU3CIZn8jePJi3U2HzSVo++6ZSgzVHry0vhZ3v1h/qeuxOx83W3He S2QBe7oA9erOEncvfIOndMP6l3GHqBJB+9L+ElZ0vc5VnS5GueU9EJ3BnmcLAsA1zQb2 zG+yXK+320g1OiPoDFO6spKz5/W1GSM7NskP7wp/j9iQ7LQ71cVXLbv42DtWh8/5ZB7g 33Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wW0tjd+cBxeR6/lhPUUjx0fEpBoP1LYYTT0FsIiI1ho=; b=DwUmnO624Bq0BNiIYPl/9Hoxnt59B/gJvRvblPMLoGTlS8A0XCGRYkDV7MzRK/LYwE gCGW0JrOM4+0LbQOF97dw21Gz+z6z990a1Dfy+BwTLN6bI1R68RvBarRPJiP7whybsCN qbt9o4z7mZU1TA9sx/qnbrVlCgBTwRA7GNsdLmXNu/DMMZz++PJI9PmfPob6mfluu0dr 5WDI4ta83m1ZSNZXzFDP/EVhboWy08crWWLG010AWAHj/a9gyCrTxL0y77rZxGAqWD6t ErOZo0ubA0uQJrxgB65Yvr4rvNbSsnn93TfEDcy0/PMLWSHXH7xWSiqSNV5x0Su7l6e4 0O+w== X-Gm-Message-State: APjAAAV182+oiTqIJ68kWUQB7VQ6tCggWhvXKRXi8CqddpAIkolFt3vd TZP83BGYq7gRtsh+OxzaNssaEOBHeU3jZSGvshSsKg== X-Google-Smtp-Source: APXvYqy0w6xoiM6E9N7yfGOvN2yylEfVSD+LT3cHC469AG7ZzC1NJLwbAZS26Rmu1su+jZ8vZlXD5Lh2v7ZgeQA4us4= X-Received: by 2002:a17:902:fe8d:: with SMTP id x13mr32717392plm.232.1580855739838; Tue, 04 Feb 2020 14:35:39 -0800 (PST) MIME-Version: 1.0 References: <20200130230812.142642-1-brendanhiggins@google.com> <20200130230812.142642-4-brendanhiggins@google.com> <11977708-bb18-e322-db7a-9f21d7cdec54@gmail.com> In-Reply-To: <11977708-bb18-e322-db7a-9f21d7cdec54@gmail.com> From: Brendan Higgins Date: Tue, 4 Feb 2020 14:35:28 -0800 Message-ID: Subject: Re: [PATCH v2 3/7] kunit: test: create a single centralized executor for all tests To: Frank Rowand Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , Arnd Bergmann , Kees Cook , Shuah Khan , Alan Maguire , Iurii Zaikin , David Gow , Andrew Morton , rppt@linux.ibm.com, Greg KH , Stephen Boyd , Logan Gunthorpe , Luis Chamberlain , Knut Omang , linux-um , linux-arch@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , "open list:DOCUMENTATION" Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Feb 4, 2020 at 2:27 PM Frank Rowand wrote: > > On 1/30/20 5:08 PM, Brendan Higgins wrote: > > From: Alan Maguire > > > > Add a centralized executor to dispatch tests rather than relying on > > late_initcall to schedule each test suite separately. Centralized > > execution is for built-in tests only; modules will execute tests > > when loaded. > > > > Signed-off-by: Alan Maguire > > Co-developed-by: Iurii Zaikin > > Signed-off-by: Iurii Zaikin > > Co-developed-by: Brendan Higgins > > Signed-off-by: Brendan Higgins > > Reviewed-by: Stephen Boyd > > --- > > include/kunit/test.h | 73 +++++++++++++++++++++++++++----------------- > > lib/kunit/Makefile | 3 +- > > lib/kunit/executor.c | 36 ++++++++++++++++++++++ > > 3 files changed, 83 insertions(+), 29 deletions(-) > > create mode 100644 lib/kunit/executor.c > > > > diff --git a/include/kunit/test.h b/include/kunit/test.h > > index 2dfb550c6723a..8a02f93a6b505 100644 > > --- a/include/kunit/test.h > > +++ b/include/kunit/test.h > > The following fragment does not match the test.h in Linux 5.5 or 5.4-rc1 (as one > possible earlier version). And we are not to Linux 5.5-rc1 yet. (Simple way > to check for the mis-match - 5.5 has kunit_test_suite() instead of > kunit_test_suites().) > > I know that there is an alternate tree where some of the development occurs. > Can you please add a link in MAINTAINERS? And please note (at least in > patch 0) what tree the series is developed against? Yep, I was planning on sending an update to the MAINTAINERS with that and some other updates soon. In future revisions, I will put a link to the tree I developed against. In the meantime, we send pull-requests from here: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=kunit And that is what I used as my development base for this series.