From: Brendan Higgins <brendanhiggins@google.com> To: Alan Maguire <alan.maguire@oracle.com>, "Theodore Ts'o" <tytso@mit.edu>, Iurii Zaikin <yzaikin@google.com>, David Gow <davidgow@google.com> Cc: "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, KUnit Development <kunit-dev@googlegroups.com>, Kees Cook <keescook@chromium.org>, Andrew Morton <akpm@linux-foundation.org>, Masahiro Yamada <yamada.masahiro@socionext.com>, catalin.marinas@arm.com, joe.lawrence@redhat.com, penguin-kernel@i-love.sakura.ne.jp, urezki@gmail.com, andriy.shevchenko@linux.intel.com, Jonathan Corbet <corbet@lwn.net>, adilger.kernel@dilger.ca, Luis Chamberlain <mcgrof@kernel.org>, "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>, Knut Omang <knut.omang@oracle.com> Subject: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module Date: Tue, 3 Dec 2019 09:54:25 -0800 Message-ID: <CAFd5g47dRP9HvsZD3sqzzfbAthNq8gxEdh57owo3CqVHLNOf6w@mail.gmail.com> (raw) In-Reply-To: <1575374868-32601-4-git-send-email-alan.maguire@oracle.com> On Tue, Dec 3, 2019 at 4:08 AM Alan Maguire <alan.maguire@oracle.com> wrote: > > As tests are added to kunit, it will become less feasible to execute > all built tests together. By supporting modular tests we provide > a simple way to do selective execution on a running system; specifying > > CONFIG_KUNIT=y > CONFIG_KUNIT_EXAMPLE_TEST=m > > ...means we can simply "insmod example-test.ko" to run the tests. > > To achieve this we need to do the following: > > o export the required symbols in kunit > o string-stream tests utilize non-exported symbols so for now we skip > building them when CONFIG_KUNIT_TEST=m. > o support a new way of declaring test suites. Because a module cannot > do multiple late_initcall()s, we provide a kunit_test_suites() macro > to declare multiple suites within the same module at once. > o some test module names would have been too general ("test-test" > and "example-test" for kunit tests, "inode-test" for ext4 tests); > rename these as appropriate ("kunit-test", "kunit-example-test" > and "ext4-inode-test" respectively). > > Co-developed-by: Knut Omang <knut.omang@oracle.com> > Signed-off-by: Knut Omang <knut.omang@oracle.com> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> > --- > fs/ext4/Kconfig | 2 +- > fs/ext4/Makefile | 5 ++++ > fs/ext4/inode-test.c | 4 ++- > include/kunit/test.h | 35 +++++++++++++++------- > kernel/sysctl-test.c | 4 ++- > lib/Kconfig.debug | 4 +-- > lib/kunit/Kconfig | 4 +-- > lib/kunit/Makefile | 10 +++++-- > lib/kunit/assert.c | 8 +++++ > lib/kunit/{example-test.c => kunit-example-test.c} | 4 ++- > lib/kunit/{test-test.c => kunit-test.c} | 5 ++-- > lib/kunit/string-stream-test.c | 2 +- > lib/kunit/test.c | 8 +++++ > lib/kunit/try-catch.c | 2 ++ > lib/list-test.c | 4 ++- > 15 files changed, 76 insertions(+), 25 deletions(-) > rename lib/kunit/{example-test.c => kunit-example-test.c} (97%) > rename lib/kunit/{test-test.c => kunit-test.c} (98%) Ted, David, and Iurii, can you each review/ack for the bits that each of you own? Thanks for all your hard work on this Alan!
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-03 12:07 [PATCH v5 linux-kselftest-test 0/6] kunit: support building core/tests as modules Alan Maguire 2019-12-03 12:07 ` [PATCH v5 linux-kselftest-test 1/6] kunit: move string-stream.h to lib/kunit Alan Maguire 2019-12-03 12:07 ` [PATCH v5 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h Alan Maguire 2019-12-03 12:07 ` [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module Alan Maguire 2019-12-03 17:54 ` Brendan Higgins [this message] 2019-12-04 0:38 ` Theodore Y. Ts'o 2019-12-04 0:42 ` Brendan Higgins 2019-12-04 0:51 ` Brendan Higgins 2019-12-04 15:41 ` Alan Maguire 2019-12-05 0:00 ` Iurii Zaikin 2019-12-06 13:53 ` Alan Maguire 2019-12-04 0:17 ` Iurii Zaikin 2019-12-04 15:30 ` Alan Maguire 2019-12-04 0:55 ` David Gow 2019-12-03 12:07 ` [PATCH v5 linux-kselftest-test 4/6] kunit: remove timeout dependence on sysctl_hung_task_timeout_seconds Alan Maguire 2019-12-03 22:45 ` Brendan Higgins 2019-12-03 12:07 ` [PATCH v5 linux-kselftest-test 5/6] kunit: allow kunit to be loaded as a module Alan Maguire 2019-12-03 22:47 ` Brendan Higgins 2019-12-03 12:07 ` [PATCH v5 linux-kselftest-test 6/6] kunit: update documentation to describe module-based build Alan Maguire 2019-12-03 22:50 ` Brendan Higgins 2019-12-03 23:06 ` [PATCH v5 linux-kselftest-test 0/6] kunit: support building core/tests as modules Brendan Higgins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFd5g47dRP9HvsZD3sqzzfbAthNq8gxEdh57owo3CqVHLNOf6w@mail.gmail.com \ --to=brendanhiggins@google.com \ --cc=adilger.kernel@dilger.ca \ --cc=akpm@linux-foundation.org \ --cc=alan.maguire@oracle.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=davidgow@google.com \ --cc=joe.lawrence@redhat.com \ --cc=keescook@chromium.org \ --cc=knut.omang@oracle.com \ --cc=kunit-dev@googlegroups.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=mcgrof@kernel.org \ --cc=penguin-kernel@i-love.sakura.ne.jp \ --cc=tytso@mit.edu \ --cc=urezki@gmail.com \ --cc=yamada.masahiro@socionext.com \ --cc=yzaikin@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-kselftest Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \ linux-kselftest@vger.kernel.org public-inbox-index linux-kselftest Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest AGPL code for this site: git clone https://public-inbox.org/public-inbox.git