From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E246C433F5 for ; Wed, 5 Oct 2022 20:41:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbiJEUlJ (ORCPT ); Wed, 5 Oct 2022 16:41:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231134AbiJEUlI (ORCPT ); Wed, 5 Oct 2022 16:41:08 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E32762A95 for ; Wed, 5 Oct 2022 13:41:07 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id z97so133651ede.8 for ; Wed, 05 Oct 2022 13:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wezMY0HcT+UXrF/Kp1mqgrelTmjrv48aVuFmQkT0QkM=; b=pMRkqZuA0XwgD1ltGokKvQ/xSa9jAL8/1q6ZYlVAdIz48r82ogNpa+9g+ARAOTz0xm QVsTbAqCecamtq6Rn1+jQJE8fdQklZzaJOTkX+iMZ0l2y0N5cRRTLNIUlzJU+BjwgRVZ SjKPpaDirLtUtwnJQg/PfqJvzasGa04p8Wcs7WnG3ItKuWX3RA4HkWBlxGBUkCkZok+k ENITADfYS53EvKj3Loc0kSfkkcv8K3YQs8ucD89brYvI0mieIzei8S6fnBBdCbsgmqEi oyrLqPZ0WzOmh0zLajlgbUTVdlV+UHtIPCaNKmtqoz9QFkR55ma6PrmspEgT78kUuhPq y5dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wezMY0HcT+UXrF/Kp1mqgrelTmjrv48aVuFmQkT0QkM=; b=JjO1qVYP3m+tA5LLWtnXoKLNh4a6wxzK6DVnPlJdfBGrMR01mkqVnjpStaO6JiUEL3 N/8Gg76mqZ2nVnpfbp+mwBRuINF4hNA3Mf1c9sj/rj+ILklvxav205lQ2fZmm6im0jto MgBufZWEpbcZiTlCsBN2o0x9q3/AcVW64hqfeAfrGJv2iHfZieBH8C8h+Q8galKVPcR7 UwHoOTaTEWiR0Q/R6B3+Rj+/mBpLzT+QbXrpeCl6ncKCt9TJDmFE/oxJcPM4xjXo6pe0 c+26CxKkOFwIn7JgeXuIfqkO8SJjFFG9WrgnMdah2IDnDvXfehSh5fYwJ8pneFgsoyEO 0Pfg== X-Gm-Message-State: ACrzQf0xX0DWBZJjlOkO5X3PMv+PSPOMBk/ZOB52ICVoAC+s9fATl9aP 5KJInVLbvmDv8t7AU6ctdsEMPYcdfB8yvYUh9RJMBw== X-Google-Smtp-Source: AMsMyM5ZqR/Q+hN0/JlujBTlWbuTUIYpAXZac8OwJLMYeXl9GqBRApH2XD/qoCRHNW3cxtqfK2j8RjRm9ES4wJFR788= X-Received: by 2002:a05:6402:4310:b0:459:7806:8ee6 with SMTP id m16-20020a056402431000b0045978068ee6mr1504103edc.198.1665002465512; Wed, 05 Oct 2022 13:41:05 -0700 (PDT) MIME-Version: 1.0 References: <20220722171534.3576419-1-dlatypov@google.com> <20220722171534.3576419-5-dlatypov@google.com> In-Reply-To: <20220722171534.3576419-5-dlatypov@google.com> From: Brendan Higgins Date: Wed, 5 Oct 2022 16:40:54 -0400 Message-ID: Subject: Re: [PATCH v2 5/5] kunit: make kunit_kfree(NULL) a no-op to match kfree() To: Daniel Latypov Cc: davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Jul 22, 2022 at 1:15 PM Daniel Latypov wrote: > > The real kfree() function will silently return when given a NULL. > So a user might reasonably think they can write the following code: > char *buffer = NULL; > if (param->use_buffer) buffer = kunit_kzalloc(test, 10, GFP_KERNEL); > ... > kunit_kfree(test, buffer); > > As-is, kunit_kfree() will mark the test as FAILED when buffer is NULL. > (And in earlier times, it would segfault). > > Let's match the semantics of kfree(). > > Suggested-by: David Gow > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins