Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] kunit: add PRINTK dependency
@ 2019-09-06 15:27 Arnd Bergmann
  2019-09-06 15:31 ` Tim.Bird
  2019-09-06 15:39 ` Shuah Khan
  0 siblings, 2 replies; 6+ messages in thread
From: Arnd Bergmann @ 2019-09-06 15:27 UTC (permalink / raw)
  To: Brendan Higgins
  Cc: Arnd Bergmann, Greg Kroah-Hartman, Logan Gunthorpe, Stephen Boyd,
	Shuah Khan, linux-kselftest, kunit-dev, linux-kernel

The vprintk_emit() function is not available when CONFIG_PRINTK
is disabled:

kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-Werror,-Wimplicit-function-declaration]

I suppose without printk(), there is not much use in kunit
either, so add a Kconfig depenedency here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kunit/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kunit/Kconfig b/kunit/Kconfig
index 8541ef95b65a..e80d8af00454 100644
--- a/kunit/Kconfig
+++ b/kunit/Kconfig
@@ -6,6 +6,7 @@ menu "KUnit support"
 
 config KUNIT
 	bool "Enable support for unit tests (KUnit)"
+	depends on PRINTK
 	help
 	  Enables support for kernel unit tests (KUnit), a lightweight unit
 	  testing and mocking framework for the Linux kernel. These tests are
-- 
2.20.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] kunit: add PRINTK dependency
  2019-09-06 15:27 [PATCH] kunit: add PRINTK dependency Arnd Bergmann
@ 2019-09-06 15:31 ` Tim.Bird
  2019-09-06 15:39 ` Shuah Khan
  1 sibling, 0 replies; 6+ messages in thread
From: Tim.Bird @ 2019-09-06 15:31 UTC (permalink / raw)
  To: arnd, brendanhiggins
  Cc: gregkh, logang, sboyd, skhan, linux-kselftest, kunit-dev, linux-kernel

Minor spelling nit..

> -----Original Message-----
> From: Arnd Bergmann
> 
> The vprintk_emit() function is not available when CONFIG_PRINTK
> is disabled:
> 
> kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-
> Werror,-Wimplicit-function-declaration]
> 
> I suppose without printk(), there is not much use in kunit
> either, so add a Kconfig depenedency here.
depenedency -> dependency

> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  kunit/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kunit/Kconfig b/kunit/Kconfig
> index 8541ef95b65a..e80d8af00454 100644
> --- a/kunit/Kconfig
> +++ b/kunit/Kconfig
> @@ -6,6 +6,7 @@ menu "KUnit support"
> 
>  config KUNIT
>  	bool "Enable support for unit tests (KUnit)"
> +	depends on PRINTK
>  	help
>  	  Enables support for kernel unit tests (KUnit), a lightweight unit
>  	  testing and mocking framework for the Linux kernel. These tests are
> --
> 2.20.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kunit: add PRINTK dependency
  2019-09-06 15:27 [PATCH] kunit: add PRINTK dependency Arnd Bergmann
  2019-09-06 15:31 ` Tim.Bird
@ 2019-09-06 15:39 ` Shuah Khan
  2019-09-06 16:02   ` Arnd Bergmann
  1 sibling, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2019-09-06 15:39 UTC (permalink / raw)
  To: Arnd Bergmann, Brendan Higgins
  Cc: Greg Kroah-Hartman, Logan Gunthorpe, Stephen Boyd,
	linux-kselftest, kunit-dev, linux-kernel,
	skh >> Shuah Khan

On 9/6/19 9:27 AM, Arnd Bergmann wrote:
> The vprintk_emit() function is not available when CONFIG_PRINTK
> is disabled:
> 
> kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-Werror,-Wimplicit-function-declaration]
> 
> I suppose without printk(), there is not much use in kunit
> either, so add a Kconfig depenedency here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   kunit/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/kunit/Kconfig b/kunit/Kconfig
> index 8541ef95b65a..e80d8af00454 100644
> --- a/kunit/Kconfig
> +++ b/kunit/Kconfig
> @@ -6,6 +6,7 @@ menu "KUnit support"
>   
>   config KUNIT
>   	bool "Enable support for unit tests (KUnit)"
> +	depends on PRINTK
>   	help
>   	  Enables support for kernel unit tests (KUnit), a lightweight unit
>   	  testing and mocking framework for the Linux kernel. These tests are
> 

Hi Arnd,

This is found and fixed already. I am just about to apply Berndan's
patch that fixes this dependency. All of this vprintk_emit() stuff
is redone.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kunit: add PRINTK dependency
  2019-09-06 15:39 ` Shuah Khan
@ 2019-09-06 16:02   ` Arnd Bergmann
  2019-09-06 16:08     ` Shuah Khan
  0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2019-09-06 16:02 UTC (permalink / raw)
  To: Shuah Khan
  Cc: Brendan Higgins, Greg Kroah-Hartman, Logan Gunthorpe,
	Stephen Boyd, open list:KERNEL SELFTEST FRAMEWORK, kunit-dev,
	linux-kernel

On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan <skhan@linuxfoundation.org> wrote:

> >   config KUNIT
> >       bool "Enable support for unit tests (KUnit)"
> > +     depends on PRINTK
> >       help
> >         Enables support for kernel unit tests (KUnit), a lightweight unit
> >         testing and mocking framework for the Linux kernel. These tests are
> >
>
> Hi Arnd,
>
> This is found and fixed already. I am just about to apply Berndan's
> patch that fixes this dependency. All of this vprintk_emit() stuff
> is redone.

Ok, perfect. Unfortunately I only started testing the coming
linux-next release after Stephen went on his break, so
I'm missing some updates.

    Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kunit: add PRINTK dependency
  2019-09-06 16:02   ` Arnd Bergmann
@ 2019-09-06 16:08     ` Shuah Khan
  2019-09-07  0:43       ` Brendan Higgins
  0 siblings, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2019-09-06 16:08 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Brendan Higgins, Greg Kroah-Hartman, Logan Gunthorpe,
	Stephen Boyd, open list:KERNEL SELFTEST FRAMEWORK, kunit-dev,
	linux-kernel, shuah

On 9/6/19 10:02 AM, Arnd Bergmann wrote:
> On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
> 
>>>    config KUNIT
>>>        bool "Enable support for unit tests (KUnit)"
>>> +     depends on PRINTK
>>>        help
>>>          Enables support for kernel unit tests (KUnit), a lightweight unit
>>>          testing and mocking framework for the Linux kernel. These tests are
>>>
>>
>> Hi Arnd,
>>
>> This is found and fixed already. I am just about to apply Berndan's
>> patch that fixes this dependency. All of this vprintk_emit() stuff
>> is redone.
> 
> Ok, perfect. Unfortunately I only started testing the coming
> linux-next release after Stephen went on his break, so
> I'm missing some updates.
> 

No worries. I am pushing it now - should be there in 5-10 mins.

Please use linuxk-kselftest next.

Let me know if you see any issues. Thanks for testing it.

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kunit: add PRINTK dependency
  2019-09-06 16:08     ` Shuah Khan
@ 2019-09-07  0:43       ` Brendan Higgins
  0 siblings, 0 replies; 6+ messages in thread
From: Brendan Higgins @ 2019-09-07  0:43 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Shuah Khan, Greg Kroah-Hartman, Logan Gunthorpe, Stephen Boyd,
	open list:KERNEL SELFTEST FRAMEWORK, kunit-dev, linux-kernel,
	shuah

On Fri, Sep 6, 2019 at 9:08 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 9/6/19 10:02 AM, Arnd Bergmann wrote:
> > On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
> >
> >>>    config KUNIT
> >>>        bool "Enable support for unit tests (KUnit)"
> >>> +     depends on PRINTK
> >>>        help
> >>>          Enables support for kernel unit tests (KUnit), a lightweight unit
> >>>          testing and mocking framework for the Linux kernel. These tests are
> >>>
> >>
> >> Hi Arnd,
> >>
> >> This is found and fixed already. I am just about to apply Berndan's
> >> patch that fixes this dependency. All of this vprintk_emit() stuff
> >> is redone.
> >
> > Ok, perfect. Unfortunately I only started testing the coming
> > linux-next release after Stephen went on his break, so
> > I'm missing some updates.
> >
>
> No worries. I am pushing it now - should be there in 5-10 mins.
>
> Please use linuxk-kselftest next.
>
> Let me know if you see any issues. Thanks for testing it.

Hi Arnd, Shuah accepted my version of the fix earlier today.
Nevertheless, I really appreciate you looking into this. Sorry for
wasting your time.

Please let me know if you run into any additional issues.

Thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 15:27 [PATCH] kunit: add PRINTK dependency Arnd Bergmann
2019-09-06 15:31 ` Tim.Bird
2019-09-06 15:39 ` Shuah Khan
2019-09-06 16:02   ` Arnd Bergmann
2019-09-06 16:08     ` Shuah Khan
2019-09-07  0:43       ` Brendan Higgins

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org linux-kselftest@archiver.kernel.org
	public-inbox-index linux-kselftest


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/ public-inbox