From: Daniel Latypov <dlatypov@google.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: David Gow <davidgow@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Aaron Tomlin <atomlin@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Brendan Higgins <brendanhiggins@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
Sebastian Reichel <sre@kernel.org>,
John Ogness <john.ogness@linutronix.de>,
Joe Fradley <joefradley@google.com>,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2] kunit: Taint kernel if any tests run
Date: Wed, 4 May 2022 14:19:59 -0500 [thread overview]
Message-ID: <CAGS_qxoFECVJD3Jby1eTWG741hBWuotuEM78PU-qfyvp-nLV7Q@mail.gmail.com> (raw)
In-Reply-To: <YnLJ6dJQBTYjBRHZ@bombadil.infradead.org>
On Wed, May 4, 2022 at 1:46 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
> OK so, we can just skip tainting considerations for selftests which
> don't use modules for now. There may be selftests which do wonky
> things in userspace but indeed I agree the userspace taint would
> be better for those but I don't think it may be worth bother
> worrying about those at this point in time.
>
> But my point in that sharing a taint between kunit / selftests modules
> does make sense and is easily possible. The unfortunate aspect is just
Yes, I 100% agree that we should share a taint for kernelspace testing
from both kunit/kselftest.
Someone running the system won't care what framework was used.
> that selftests don't have a centralized runner, because I can just
> run tools/testing/selftests/sysctl/sysctl.sh for example and that's it.
> So I think we have no other option but to just add the module info
> manually for selftests at this time.
Somewhat tangential: there's a number of other test modules that
aren't explicitly part of kselftest.
Long-term, I think most of them should be converted to kselftest or
kunit as appropriate, so they'll get taken care of eventually.
A number of these modules depend on CONFIG_DEBUG_KERNEL=y, but we
can't pre-emptively set this new taint flag by checking for it as it's
too widely used :\
E.g. the debian-based distro I'm using right now has it set
$ grep 'CONFIG_DEBUG_KERNEL=y' /boot/config-$(uname -r)
CONFIG_DEBUG_KERNEL=y
-Daniel
next prev parent reply other threads:[~2022-05-04 19:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 4:39 [PATCH] kunit: Taint kernel if any tests run David Gow
2022-04-29 7:09 ` Greg KH
2022-04-29 11:21 ` Jani Nikula
2022-04-29 11:41 ` Greg KH
2022-04-29 11:54 ` Jani Nikula
2022-04-29 12:07 ` Greg KH
2022-04-30 2:54 ` David Gow
2022-04-30 3:00 ` [PATCH v2] " David Gow
2022-04-30 5:50 ` Greg KH
2022-05-01 18:22 ` Luis Chamberlain
2022-05-01 18:24 ` Luis Chamberlain
2022-05-03 6:49 ` David Gow
2022-05-04 14:51 ` Luis Chamberlain
2022-05-04 16:25 ` Daniel Latypov
2022-05-04 18:46 ` Luis Chamberlain
2022-05-04 19:19 ` Daniel Latypov [this message]
2022-05-04 21:12 ` Luis Chamberlain
2022-05-05 5:57 ` Luis Chamberlain
2022-05-06 7:01 ` David Gow
2022-05-09 20:43 ` Luis Chamberlain
2022-05-13 8:32 ` [PATCH v3 1/3] panic: Taint kernel if tests are run David Gow
2022-05-13 15:35 ` Luis Chamberlain
2022-05-17 20:45 ` Brendan Higgins
2022-05-13 8:32 ` [PATCH v3 2/3] kunit: Taint the kernel when KUnit " David Gow
2022-05-13 15:36 ` Luis Chamberlain
2022-05-13 19:08 ` Daniel Latypov
2022-05-14 3:04 ` David Gow
2022-05-14 19:25 ` Daniel Latypov
2022-05-17 20:58 ` Brendan Higgins
2022-05-17 20:58 ` Brendan Higgins
2022-05-13 8:32 ` [PATCH v3 3/3] selftest: Taint kernel when test module loaded David Gow
2022-05-13 15:38 ` Luis Chamberlain
2022-05-14 8:34 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGS_qxoFECVJD3Jby1eTWG741hBWuotuEM78PU-qfyvp-nLV7Q@mail.gmail.com \
--to=dlatypov@google.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=atomlin@redhat.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=joefradley@google.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mcgrof@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).