linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Latypov <dlatypov@google.com>
To: "Maíra Canal" <maira.canal@usp.br>
Cc: David Gow <davidgow@google.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	KUnit Development <kunit-dev@googlegroups.com>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/2] kunit: add coverage_uml.config to enable GCOV on UML
Date: Fri, 24 Jun 2022 09:13:08 -0700	[thread overview]
Message-ID: <CAGS_qxodP-3=mcL4pcG=BSremBZiDeT1YdCRDPP4oVWVEZ=pEg@mail.gmail.com> (raw)
In-Reply-To: <6e46976d-bcf3-e7fd-cd30-bc25c67c5518@usp.br>

On Fri, Jun 24, 2022 at 7:12 AM Maíra Canal <maira.canal@usp.br> wrote:
>
> On 6/24/22 04:55, 'David Gow' via KUnit Development wrote:
> > On Fri, Jun 24, 2022 at 8:12 AM 'Daniel Latypov' via KUnit Development
> > <kunit-dev@googlegroups.com> wrote:
> >>
> >> Now that kunit.py's --kunitconfig is repeatable, let's create a file to
> >> hold the various options needed to enable coverage under UML.
> >>
> >> This can be used like so:
> >> $ ./tools/testing/kunit/kunit.py run \
> >>    --kunitconfig=tools/testing/kunit/configs/all_tests_uml.config \
> >>    --kunitconfig=tools/testing/kunit/configs/coverage_uml.config \
> >>    --make_options=CC=/usr/bin/gcc-6
> >>
> >> which on my system is enough to get coverage working [1].
> >>
>
> It's great to see this coming to KUnit! As I was testing this series, I
> wasn't able to generate the coverage stats with GCC11. I got a linking
> error from ld:
>
> ERROR:root:/usr/bin/ld:
> /usr/lib/gcc/x86_64-redhat-linux/11/libgcov.a(_gcov.o): in function
> `mangle_path':
> (.text+0x19f0): multiple definition of `mangle_path';
> fs/seq_file.o:/home/mairacanal/linux/.kunit/../fs/seq_file.c:441: first
> defined here
> collect2: error: ld returned 1 exit status
>
> By changing the name of the function to `seq_mangle_path`, it is
> possible to solve the linking error and run the tests. But, anyway, no
> .gcda files are generated.
>
> I checked out, and this is a known issue that was already discussed in
> this series [1] (but I guess it didn't move on).

There's the two main issues I knew about and that you noted.
* no gcda files produced (gcc 7+)
* seq_mangle_path (I don't remember, gcc 8 or 9+?)

The latter can be worked around locally fairly easily, as you also found.
The former is due to how the exit handlers work, iirc.

I didn't know about [1], but it also mentions the exit handlers issue.
However, from the sounds of [2], it seems like it might be a dead end for now :\
So I wouldn't hold onto hope of using modern GCC versions with this.

[2] https://lore.kernel.org/all/d36ea54d8c0a8dd706826ba844a6f27691f45d55.camel@sipsolutions.net/

Daniel

  reply	other threads:[~2022-06-24 16:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  0:12 [PATCH 1/2] kunit: tool: make --kunitconfig repeatable, blindly concat Daniel Latypov
2022-06-24  0:12 ` [PATCH 2/2] kunit: add coverage_uml.config to enable GCOV on UML Daniel Latypov
2022-06-24  7:55   ` David Gow
2022-06-24 14:12     ` Maíra Canal
2022-06-24 16:13       ` Daniel Latypov [this message]
2022-06-24  7:55 ` [PATCH 1/2] kunit: tool: make --kunitconfig repeatable, blindly concat David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGS_qxodP-3=mcL4pcG=BSremBZiDeT1YdCRDPP4oVWVEZ=pEg@mail.gmail.com' \
    --to=dlatypov@google.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maira.canal@usp.br \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).