From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE59C00140 for ; Tue, 2 Aug 2022 22:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237241AbiHBWaL (ORCPT ); Tue, 2 Aug 2022 18:30:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237248AbiHBWaE (ORCPT ); Tue, 2 Aug 2022 18:30:04 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D41D9558F5 for ; Tue, 2 Aug 2022 15:29:46 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id f22so8341565edc.7 for ; Tue, 02 Aug 2022 15:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nt4PXjotTawRx9pQyNbVwREiDBb+yvN1pKjWnXAYa7E=; b=k21vaPYO3PBf3TdXzucVl6smIURDRlEOU1yWSdRwFVWrjJcBTAgBWf972w4noHOmEo qtE3zWZbm2PlR93udpDPS8M9t+wcFdGoM8zMjPy0EE84T5Bjb27vx3mD7ZFWLou3j4Xe Zb30W+UNrpf8NKpESqvHNp1PIhdrxKsU/hDTF8qVXegJ70IIzkxXh9ArGpU/2TwUW8ii vga1Ix8HCEOlcrkPtK9IxK/Iureb/koiSNNJvcrCOSk0W9UzOacgM2WmESksKTlIfP3h vxbHt0nW+0jYzn3vPPA9jzyEinKxpZwA26L05BCw888IdYxU+5Abqcl0bJgcIET+liWV EiGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nt4PXjotTawRx9pQyNbVwREiDBb+yvN1pKjWnXAYa7E=; b=ME6gbJXx6dHtQbhso4+034J1r/nwqcOCwM1DEhqGP69dUmGvgC3gcdMacozbDCxcBe Lb8kqlJLZw0HdNSGI4lNP1hVmjzVgRH+VRd/KJQZqxxYUJtwN7d9QWUWZP8KG09FDgSa hOCyW7VE1RmTXF07nVzWbY8HmopaQVBY+R+4Zh4esR4XnYFcWY3++pt5UvjBlfRCbmq6 vpvfC7k3Nk6B0rLuF+eMwZ6KPKXRP+3QV8nKt6nAXpvQOSAfm6it83ve2uxbXPn2D9PN 147fG4AOZtVncUml1HLyPal+Qz1/k5FxQoi7JQ0GTTtHHGW4Qs/eVy+Yb1IFNyWykwe6 KRMA== X-Gm-Message-State: ACgBeo1nxgR/goPq0u4sz5w2y+vOWztAKk6CHyV9EkVsrJa57n3usPD2 fx1FET06xV4elzWCUB+bSjXmk+ZaSb7MHe0M1jE7m6ovxL7cRg== X-Google-Smtp-Source: AA6agR7diXu6NWBhqw9P2LB3kLSFApdVDiifLmRG6e6KRnD1E6WkHi9LZBbwS1HdeEB9G+Gpg782c1GCnusBxyRkEFU= X-Received: by 2002:a05:6402:4385:b0:43d:4820:4532 with SMTP id o5-20020a056402438500b0043d48204532mr17896002edc.233.1659479385307; Tue, 02 Aug 2022 15:29:45 -0700 (PDT) MIME-Version: 1.0 References: <20220802212621.420840-1-mairacanal@riseup.net> <20220802212621.420840-4-mairacanal@riseup.net> In-Reply-To: <20220802212621.420840-4-mairacanal@riseup.net> From: Daniel Latypov Date: Tue, 2 Aug 2022 15:29:33 -0700 Message-ID: Subject: Re: [PATCH v2 3/3] kunit: Use KUNIT_EXPECT_MEMEQ macro To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: Brendan Higgins , davidgow@google.com, airlied@linux.ie, daniel@ffwll.ch, davem@davemloft.net, kuba@kernel.org, jose.exposito89@gmail.com, javierm@redhat.com, andrealmeid@riseup.net, melissa.srw@gmail.com, siqueirajordao@riseup.net, Isabella Basso , magalilemes00@gmail.com, tales.aparecida@gmail.com, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Aug 2, 2022 at 2:27 PM Ma=C3=ADra Canal wro= te: > > Use KUNIT_EXPECT_MEMEQ to compare memory blocks in replacement of the > KUNIT_EXPECT_EQ macro. Therefor, the statement > > KUNIT_EXPECT_EQ(test, memcmp(foo, bar, size), 0); > > is replaced by: > > KUNIT_EXPECT_MEMEQ(test, foo, bar, size); > > Signed-off-by: Ma=C3=ADra Canal Acked-by: Daniel Latypov I didn't go and find the appropriate commit from the drm tree to base this on, so I couldn't apply it locally. But looking at the diff itself, looks good!