From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695E3C07E9D for ; Mon, 26 Sep 2022 23:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231377AbiIZXkS (ORCPT ); Mon, 26 Sep 2022 19:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231344AbiIZXkN (ORCPT ); Mon, 26 Sep 2022 19:40:13 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A3703AB30 for ; Mon, 26 Sep 2022 16:40:11 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id f193so7963770pgc.0 for ; Mon, 26 Sep 2022 16:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=CV/mbcKH4qX6MXHBANtxht73WgG6wuL82GOFfkKV6Oo=; b=cmO1i0bXpBONGQenXSWE8SHA6yaryyoYYkT4mkxsgUgf2jcvBRBzouBtr8+1SuVzDl ZY47sAAs3gvxgKC1x32NpztbrLAT2LfGnkJO40OM3nZ37b7ae8o1e28YV0bc0F1boL1N UqM3VvJv4OlPuyWDhqUqlNiZxKdqLbB0uMYUt8XEAkuMyOMfWCI4ppGRwbWK6lt0zAMq Rrkoly+Y38TnboaGdX0KA+yEioPFhtTfPQhVPRHzgUkHptSX/LAGjx5w0BzqQrZ6vvpu rlEyykxv5IaVtXCKdOynNY4KHOOE8mJzTOtYatR60tU+yvDqeZ1HBPokPqHlQPh13LpC imng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=CV/mbcKH4qX6MXHBANtxht73WgG6wuL82GOFfkKV6Oo=; b=QQVUaOuxgNYNkpwzpnYiqIX/j1UeEXWnolxwZPbFiWw85EVGPjcsOHHBK0X2+4qwq5 +OEhw+QjYami16WRR9snCnYIH+Wdl2+wnM19pcxjRQFkjTkN6zAZQHgOFzOXzrk63YZ4 MV4wEaXsg0wzL1N/oYXU2xcBwh54ILZP7WqzkVbV7bmEYWjGVizE+zvNXHYhhR6Z+8MW 2+ZDWOfqQIYEJ4+rWtwBf38xglLVCUqWsqQCnMRfGc+H1DPRUlf7GuJ2wbd3aXGLtlOb rdqm8VBTa/KhQzN0SOCC+X9c5iv9u0UQOVTjnfUAYQrlAR/cwjsY6JOFB4mb0ionyrTX ldRg== X-Gm-Message-State: ACrzQf3k8dB0p6XTW7KtjFdd1bNLEI5i3IHQ7T0mMZuwgh+zLVcymp+E fIvUA0loDTSgO/s83wWWZ/2M4FmBlVUxAvDe/YTbVQ== X-Google-Smtp-Source: AMsMyM5K4IdmzFXzkfAqdNpbKl06Dd2pgkXO6kCLJK4hGCT2BUNLtye6deOSLfkAlLcKX+PNq9ErzSN1ASvgTBzFENw= X-Received: by 2002:a63:1a51:0:b0:43b:e496:f2f4 with SMTP id a17-20020a631a51000000b0043be496f2f4mr22554894pgm.99.1664235610798; Mon, 26 Sep 2022 16:40:10 -0700 (PDT) MIME-Version: 1.0 References: <20220915000448.1674802-1-vannapurve@google.com> <20220915000448.1674802-5-vannapurve@google.com> In-Reply-To: From: Vishal Annapurve Date: Mon, 26 Sep 2022 16:40:00 -0700 Message-ID: Subject: Re: [V2 PATCH 4/8] KVM: selftests: x86: Precompute the result for is_{intel,amd}_cpu() To: David Matlack Cc: x86 , kvm list , LKML , Linuxkselftest , Paolo Bonzini , shuah , Ben Gardon , Sean Christopherson , Oliver Upton , Peter Xu , Vitaly Kuznetsov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Sep 26, 2022 at 4:34 PM David Matlack wrote: > > On Mon, Sep 26, 2022 at 4:27 PM Vishal Annapurve wrote: > > > > On Wed, Sep 21, 2022 at 2:19 PM David Matlack wrote: > > > ... > > > > is_amd_cpu is used by guest code within fix_hypercall_test.c, just > > caching the result will break the guest code execution. I have clubbed > > these two changes together in order to ensure that is_amd_cpu works > > fine for both host userspace and guest vm logic. > > Ah, so the sync_global_to_guest() part needs to go in the patch that > adds caching to is_amd_cpu(). > > But the point still stands that adding AMD support to kvm_hypercall() > is a logically independent change. > I see what you mean. Will split this change into two in the next series. > > ... > > > > -- > > > > 2.37.2.789.g6183377224-goog > > > >