From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F02DC33CAC for ; Thu, 6 Feb 2020 18:16:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03EF9218AC for ; Thu, 6 Feb 2020 18:16:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kPIbp8Ej" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727872AbgBFSQN (ORCPT ); Thu, 6 Feb 2020 13:16:13 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:41977 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbgBFSQN (ORCPT ); Thu, 6 Feb 2020 13:16:13 -0500 Received: by mail-ot1-f68.google.com with SMTP id r27so6395238otc.8 for ; Thu, 06 Feb 2020 10:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hqXyWTPsRk1sbEhv4F9kR6Aqgito1sCOBhDIlov5OKo=; b=kPIbp8EjtDr3arTeSUaNQfsuunB6rDyUC15mM8xmbQzCU6cCM9dZcABgKrZu4aA4ot zGuPoZjW03Kp1BP9L3alLJLvShDanfAxcTC0vG5bq/BAE5FXyJVYDAKHvx5m39Yiv3MX 3y6ca5OVMQ8AlQEMGZpuo2T9mcNKYt6EI8Z4OfEFgWzxk2cutJWG3VAKPyeJMZETw3Se 7IhrMnmTt3fKkQ7CP84POfDcoJX7OVACnImZLwfi4pnotY7FBPiwV+g1jHcv+pYo2k/3 zhAr8gEiBDGGaCaQ9VTVp+Kqfq3MxqzKgQw5MLl4pU9oEDHH8EUydogxSexQaL4d5J7x ogaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hqXyWTPsRk1sbEhv4F9kR6Aqgito1sCOBhDIlov5OKo=; b=Yfr557gOTWcMUKp793YiIXDKe0bH9cKWESdhL9WC+rDPDiT4foicqjcLcNWrNpCGaB eP7k8XAzpFVW6ACNYllwFIpputMZwaygMhAh5pGx0VLYIPvrnkpq2ZHV/tWcxqpT9c1X BN6dzL7FIaXHz75irk7soohDoPLvwdER+ycQ9DumhiykzEzwbnF5CL7qt8++y7D6zE1h Th1FduPBKiNBWfDx9lOp6HwJVIRJilJQgobG7gf1tO71q2sWbqsUUPAQg6xxXj6ZUyNG YBPhJE0BWlGPGjWwOG9zKlXcY8IxkX2stsIvnfW5SluPyEPacceieb8nf+zuZYzamiQA ptNA== X-Gm-Message-State: APjAAAVsw/urVqCvEMbxgxOBb0ZhYVn2FVN+JjcSq+gemHzfitSeQpLZ yyTEXCtI9f4XcH0BpJrSwDcVbXXxKCj0gKY4VX1cBA== X-Google-Smtp-Source: APXvYqwaTckcrFH7bGMSbhTZKw9pvz/Uc/msLLj+ylmlNbFufkDY6NdmzFxf2raQY1DpieW73ZkZW/Hdk58JVEhIdNA= X-Received: by 2002:a9d:6a2:: with SMTP id 31mr30905207otx.313.1581012972461; Thu, 06 Feb 2020 10:16:12 -0800 (PST) MIME-Version: 1.0 References: <20200203232248.104733-1-almasrymina@google.com> <20200203232248.104733-2-almasrymina@google.com> In-Reply-To: From: Mina Almasry Date: Thu, 6 Feb 2020 10:16:01 -0800 Message-ID: Subject: Re: [PATCH v11 2/9] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations To: Mike Kravetz Cc: shuah , David Rientjes , Shakeel Butt , Greg Thelen , Andrew Morton , open list , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Feb 5, 2020 at 2:08 PM Mike Kravetz wrote: > > On 2/3/20 3:22 PM, Mina Almasry wrote: > > Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb > > usage or hugetlb reservation counter. > > > > Adds a new interface to uncharge a hugetlb_cgroup counter via > > hugetlb_cgroup_uncharge_counter. > > > > Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init, > > hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline. > > > > Signed-off-by: Mina Almasry > > Acked-by: Mike Kravetz > > Acked-by: David Rientjes > > > > --- > > > > Changes in v11: > > - Changed all 'reserved' or 'reservation' to 'rsvd' to reflect the user > > interface. > > Thanks. > > Small nit, > > > @@ -450,8 +496,7 @@ static ssize_t hugetlb_cgroup_reset(struct kernfs_open_file *of, > > struct hugetlb_cgroup *h_cg = hugetlb_cgroup_from_css(of_css(of)); > > > > counter = &h_cg->hugepage[MEMFILE_IDX(of_cft(of)->private)]; > > - rsvd_counter = > > - &h_cg->rsvd_hugepage[MEMFILE_IDX(of_cft(of)->private)]; > > + rsvd_counter = &h_cg->rsvd_hugepage[MEMFILE_IDX(of_cft(of)->private)]; > > > > That looks like a change just to reformat a line added in the first patch? > > > switch (MEMFILE_ATTR(of_cft(of)->private)) { > > case RES_MAX_USAGE: > Gah, my bad. I'll move this to patch 1. > -- > Mike Kravetz