From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0DD2C3A5A2 for ; Fri, 20 Sep 2019 16:18:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C2692173E for ; Fri, 20 Sep 2019 16:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568996294; bh=GCKtG+CD95R2mS8EzwBNLj/gVyiJwKt4oDtH9SJYBic=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=M+N5+YVqe01A3cDYuyRFtGaetwvCu7zA5AUlKNgnQvVjHFQ/MBdyUYoGqpdzltmDV xi2QHl3PPBVp7qENiJD/KPvdw2wMcNai7KsP7/BkkM471ob4CIaEhGyjgJEeCvuQMt qFh/EzaiVbvtbFabiwPZpWZWunk+pogH/60Q0VH0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390601AbfITQSO (ORCPT ); Fri, 20 Sep 2019 12:18:14 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:33836 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390287AbfITQSO (ORCPT ); Fri, 20 Sep 2019 12:18:14 -0400 Received: by mail-lj1-f196.google.com with SMTP id j19so6160004lja.1 for ; Fri, 20 Sep 2019 09:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/tRAwwujfBovXt36HtC9JZ/4MVaZlXqEF94BXjqBttQ=; b=OuqSL56Vss9lPTztD/skWobMCVipuMEUX9+lHEdLASwSyG2xgG8y/svapwJXwLJJ5u M79im92CVbCsjPjTYjVv8TYLIjFWLKAMMY6KVlzWgrt2X3MS5NS4puwacoKKKjsNj6mF Qa7CZgFDD3VTS2AuGKApg6P+YvbDbM9exl/2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/tRAwwujfBovXt36HtC9JZ/4MVaZlXqEF94BXjqBttQ=; b=mk0Ir11tB0swWn2eQ/Sk88WPD7HX2qTuot8G79dXUwLtiP01tzbG7k3nT1tOmY5uVU JlhLVApkxRMF6YnoydnYitUH3a5hsc3MXoYaa1WO93wiFvnb7gktrHgaJRgSKMblPlu0 AUKEyTOlhrzW5B+zcTPwLWG0WybhTwQOOiNWMvnYPKkVxB3LpDm3XmlgzkJlmCj96/9X 0KVWJ+CJQRW43Eatje0NICk5PCXnVBD7HqxxihknwRfr5aEHaK60G/+8MOr/ojtngeqS BBEkMkafI2wLz8s3B6m+khGF/hXeJbdl+fW4fBPa7sulG9aXojkdtZW9QEktDcKuIBgg At9Q== X-Gm-Message-State: APjAAAUSvivydt1/2l9Q8JylLj02OZDqTbvBhsHMU8DzIPHmhqSW1wd7 hiSUqhUyVDiEFF1wyXa7QCZNjOjoNL4= X-Google-Smtp-Source: APXvYqwQe5MrTo15gSOIrS+BChFkqCsXgJDPzztuF1EWT7S5rezEmC1C/0z1y/ATt3+yErs0tRzTDg== X-Received: by 2002:a2e:9ac1:: with SMTP id p1mr3434684ljj.179.1568996291317; Fri, 20 Sep 2019 09:18:11 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id 21sm537325ljq.15.2019.09.20.09.18.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Sep 2019 09:18:10 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id b20so2266479ljj.5 for ; Fri, 20 Sep 2019 09:18:10 -0700 (PDT) X-Received: by 2002:a2e:3e07:: with SMTP id l7mr9721577lja.180.1568996289896; Fri, 20 Sep 2019 09:18:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 20 Sep 2019 09:17:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Kselftest update for Linux 5.4-rc1 To: Shuah Khan Cc: Mark Brown , Jarkko Sakkinen , Brendan Higgins , Anders Roxell , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Sep 17, 2019 at 12:26 PM Shuah Khan wrote: > > This Kselftest update for Linux 5.4-rc1 consists of several fixes to > existing tests and adds KUnit, a lightweight unit testing and mocking > framework for the Linux kernel from Brendan Higgins. So I pulled this, but then I almost immediately unpulled it. My reason for doing that may be odd, but it's because of the top-level 'kunit' directory. This shouldn't be on the top level. The reason I react so strongly is that it actually breaks my finger memory. I don't type out filenames - I auto-compete them. So "kernel/" is "k", "drivers/" is "d" etc. It already doesn't work for everything ("mm/" is actually "mm" not because we have files in the git tree, but because the build creates various "module" files), but this breaks a common pattern for me. > In the future KUnit will be linked to Kselftest framework to provide > a way to trigger KUnit tests from user-space. Can the kernel parts please move to lib/kunit/ or something like that? Linus