linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: syzbot <syzbot+0251e883fe39e7a0cb0a@syzkaller.appspotmail.com>,
	"David Miller" <davem@davemloft.net>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	jhs@mojatatu.com, "Jiří Pírko" <jiri@resnulli.us>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	kuba@kernel.org, kvalo@codeaurora.org, leon@kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-kselftest@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	syzkaller-bugs@googlegroups.com,
	"Thomas Gleixner" <tglx@linutronix.de>,
	vivien.didelot@gmail.com, "Cong Wang" <xiyou.wangcong@gmail.com>
Subject: Re: INFO: rcu detected stall in wg_packet_tx_worker
Date: Sun, 26 Apr 2020 13:52:45 -0600	[thread overview]
Message-ID: <CAHmME9rxYkDhH3Fj-U24Ho7oGcdABK9hXsACPDQ1rz9WUcEuSQ@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9ov2ae08UTzwKL7enquChzDNxpg4c=ppnJqS2QF6ZAn_Q@mail.gmail.com>

It looks like part of the issue might be that I call
udp_tunnel6_xmit_skb while holding rcu_read_lock_bh, in
drivers/net/wireguard/socket.c. But I think there's good reason to do
so, and udp_tunnel6_xmit_skb should be rcu safe. In fact,
every.single.other user of udp_tunnel6_xmit_skb in the kernel uses it
with rcu locked. So, hm...

  reply	other threads:[~2020-04-26 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <00000000000005d1ab05a4351006@google.com>
2020-04-26 17:57 ` INFO: rcu detected stall in wg_packet_tx_worker syzbot
2020-04-26 19:40   ` Eric Dumazet
2020-04-26 19:42     ` Jason A. Donenfeld
2020-04-26 19:52       ` Jason A. Donenfeld [this message]
2020-04-26 19:58         ` Jason A. Donenfeld
2020-04-26 20:26       ` Eric Dumazet
2020-04-26 20:38         ` Eric Dumazet
2020-04-26 20:46           ` Jason A. Donenfeld
2020-04-26 21:53             ` Eric Dumazet
2020-05-04 11:23               ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9rxYkDhH3Fj-U24Ho7oGcdABK9hXsACPDQ1rz9WUcEuSQ@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=syzbot+0251e883fe39e7a0cb0a@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tglx@linutronix.de \
    --cc=vivien.didelot@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).