From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCCF8C6FD1D for ; Tue, 21 Mar 2023 08:49:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231237AbjCUIsy (ORCPT ); Tue, 21 Mar 2023 04:48:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjCUIsE (ORCPT ); Tue, 21 Mar 2023 04:48:04 -0400 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B39524617A; Tue, 21 Mar 2023 01:47:23 -0700 (PDT) Received: by mail-yb1-xb33.google.com with SMTP id j7so16134477ybg.4; Tue, 21 Mar 2023 01:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679388441; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BBcmCiZrY50ZVCjcfSorkVtQXTza6Z7SWwBdqZaP/I4=; b=jbbXeahRIqpklGCp3MMQY1+jUyR8wUFH0caEcc0b0DmB1P+wNncEkjPsSf353eg/7G d3dZkKvPH2/Z1nh/s0WulwtfPsUM60B+NLbpP8AmLFXU3s/3k9LTCXJUFMsGXGtabdCS bslaPjaxVJY3cm4x3Pfuap23HzOqlRVMHERY0KYJzPp2lZ6gDyKF9gxPciuwMjHI7lCH p+7OiRuEPi1jmpc3yek4j7JMfLrwMisttLNRNFkjTG+2qZu2AY1j8Rt+dDy8PeFOkDcg UFjILYnGHhb2KEUUsgvHDNQuCHQ9F5Uhf5I9laD2Vftwj5VkfY3B1GvSGBqSnkk1T4Cz RFWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679388441; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BBcmCiZrY50ZVCjcfSorkVtQXTza6Z7SWwBdqZaP/I4=; b=Kut79ysIsxL+rjG8QCOOtCnG/BqQIjLPiOl2AXyRvDU0ZGkxahC/vTAO7ApGgrLt8w 6e70Xwi5XtyaNWBWfQstbEoqcPsfGOaCwu+fwNBbyFpEXwo89gKqO+Z2ZaecvFX1pNqo U6VxAMD8WuDDEiNq4jHtNEZTxNsOZgyqtk136LnnNMMnBKURb5TWHQjbqn6FSbn8WJhF r02E1KaZha8hIW+aZTSWkJldVfOaR7miq0/6RQLMBL9qWhTEIEqtGLubDVrXegeN3ZkT 8zSMGzyFJ0/pfoL54ugk9Xa4xiFNBbA8vEaY3K+sYFqGKnFTI5Y6pppjt+LYqyQgRBg4 dkqg== X-Gm-Message-State: AAQBX9eKjrn4DGCFruL6zr+J+8PvY4pUofHNx9AIlBhjGhmuDCd6UYgP QmD+whghO+4D9iFO9BMTi+T1Slo37TEmRFfbQVw= X-Google-Smtp-Source: AKy350ah4ZHOodkxV7oojAcvrqsXLiq4Vm5Q1MNdWojdKwbYAju+Jmek2XYJr95HmruI+ZHpqKTBHqmWyXC1J7AvSh4= X-Received: by 2002:a05:6902:1104:b0:9fc:e3d7:d60f with SMTP id o4-20020a056902110400b009fce3d7d60fmr728215ybu.5.1679388441642; Tue, 21 Mar 2023 01:47:21 -0700 (PDT) MIME-Version: 1.0 References: <20230319195656.326701-1-kal.conley@dectris.com> <20230319195656.326701-4-kal.conley@dectris.com> In-Reply-To: From: Magnus Karlsson Date: Tue, 21 Mar 2023 09:47:10 +0100 Message-ID: Subject: Re: [PATCH bpf-next 3/3] selftests: xsk: Add tests for 8K and 9K frame sizes To: Kal Conley Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, 21 Mar 2023 at 09:45, Magnus Karlsson wrote: > > On Sun, 19 Mar 2023 at 21:07, Kal Conley wrote: > > > > Add tests: > > - RUN_TO_COMPLETION_8K_FRAME_SIZE: frame_size=8192 (aligned) > > - RUN_TO_COMPLETION_9K_FRAME_SIZE: frame_size=9000 (unaligned) > > > > Signed-off-by: Kal Conley > > --- > > tools/testing/selftests/bpf/xskxceiver.c | 24 ++++++++++++++++++++++++ > > tools/testing/selftests/bpf/xskxceiver.h | 2 ++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c > > index 7a47ef28fbce..f10ff8c5e9c5 100644 > > --- a/tools/testing/selftests/bpf/xskxceiver.c > > +++ b/tools/testing/selftests/bpf/xskxceiver.c > > @@ -1789,6 +1789,30 @@ static void run_pkt_test(struct test_spec *test, enum test_mode mode, enum test_ > > pkt_stream_replace(test, DEFAULT_PKT_CNT, PKT_SIZE); > > testapp_validate_traffic(test); > > break; > > + case TEST_TYPE_RUN_TO_COMPLETION_8K_FRAME: > > + if (!hugepages_present(test->ifobj_tx)) { > > + ksft_test_result_skip("No 2M huge pages present.\n"); > > + return; > > + } > > + test_spec_set_name(test, "RUN_TO_COMPLETION_8K_FRAME_SIZE"); > > + test->ifobj_tx->umem->frame_size = 8192; > > + test->ifobj_rx->umem->frame_size = 8192; > > + pkt_stream_replace(test, DEFAULT_PKT_CNT, PKT_SIZE); > > + testapp_validate_traffic(test); > > + break; > > + case TEST_TYPE_RUN_TO_COMPLETION_9K_FRAME: > > TEST_TYPE_UNALIGNED_9K_FRAME > > > + if (!hugepages_present(test->ifobj_tx)) { > > + ksft_test_result_skip("No 2M huge pages present.\n"); > > + return; > > + } > > + test_spec_set_name(test, "RUN_TO_COMPLETION_9K_FRAME_SIZE"); > > UNALIGNED_MODE_9K _9K_FRAME_SIZE it should have been. Hit send too early. > > + test->ifobj_tx->umem->frame_size = 9000; > > + test->ifobj_rx->umem->frame_size = 9000; > > + test->ifobj_tx->umem->unaligned_mode = true; > > + test->ifobj_rx->umem->unaligned_mode = true; > > + pkt_stream_replace(test, DEFAULT_PKT_CNT, PKT_SIZE); > > + testapp_validate_traffic(test); > > + break; > > case TEST_TYPE_RX_POLL: > > test->ifobj_rx->use_poll = true; > > test_spec_set_name(test, "POLL_RX"); > > diff --git a/tools/testing/selftests/bpf/xskxceiver.h b/tools/testing/selftests/bpf/xskxceiver.h > > index 3e8ec7d8ec32..ff723b6d7852 100644 > > --- a/tools/testing/selftests/bpf/xskxceiver.h > > +++ b/tools/testing/selftests/bpf/xskxceiver.h > > @@ -70,6 +70,8 @@ enum test_mode { > > enum test_type { > > TEST_TYPE_RUN_TO_COMPLETION, > > TEST_TYPE_RUN_TO_COMPLETION_2K_FRAME, > > + TEST_TYPE_RUN_TO_COMPLETION_8K_FRAME, > > + TEST_TYPE_RUN_TO_COMPLETION_9K_FRAME, > > TEST_TYPE_RUN_TO_COMPLETION_SINGLE_PKT, > > TEST_TYPE_RX_POLL, > > TEST_TYPE_TX_POLL, > > -- > > 2.39.2 > >