archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <>
To: Shuah Khan <>
Cc: Michal Marek <>,
	"Cc: Shuah Khan" <>,
	Linux Kbuild mailing list <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH 2/2] selftests: Add kselftest_install target to main Makefile
Date: Thu, 26 Sep 2019 12:24:41 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Shuah,

On Thu, Sep 26, 2019 at 8:05 AM Shuah Khan <> wrote:
> Add kselftest_install target to install tests from the top level
> Makefile. This is to simplify kselftest use-cases for CI and
> distributions where build and test systems are different.
> This change addresses requests from developers and testers to add
> support for installing kselftest from the main Makefile.
> In addition, make the install directory the same when install is
> run using "make kselftest_install" or by running
> Also fix the INSTALL_PATH variable conflict between main Makefile.
> Signed-off-by: Shuah Khan <>

So, if these two patches were applied, we would see the following:

PHONY += kselftest_build
        $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests all

PHONY += kselftest
        $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests

PHONY += kselftest_install
        $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests install

PHONY += kselftest-clean
        $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean

I do not want to see this endless crap addition just for
changing the working directory to $(srctree)/tools/testing/selftests

Why don't you use pattern rule?
Those will be reduced into the two rules.

PHONY += kselftest
        $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests

kselftest-%: FORCE
        $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*

This also avoids your inconsistency about
"kselftest-" vs "kselftest_".

Given the existing "kselftest-clean" and "kselftest-merge",
"kselftest_build" and "kselftest_install"
(using an underscore instead of n hyphen)
would add needless confusion.

Best Regards
Masahiro Yamada

  reply	other threads:[~2019-09-26  3:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 23:04 [PATCH 0/2] Simplify kselftest build and install use-cases Shuah Khan
2019-09-25 23:04 ` [PATCH 1/2] Makefile: Add kselftest_build target to build tests Shuah Khan
2019-09-25 23:04 ` [PATCH 2/2] selftests: Add kselftest_install target to main Makefile Shuah Khan
2019-09-26  3:24   ` Masahiro Yamada [this message]
2019-09-26 22:11     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/2] selftests: Add kselftest_install target to main Makefile' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).