linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dmabuf-heaps/dmabuf-heap.c: Initialize features variable to avoid compiler warning
@ 2019-11-05  9:40 Xiao Yang
  2019-11-07 20:30 ` shuah
  0 siblings, 1 reply; 3+ messages in thread
From: Xiao Yang @ 2019-11-05  9:40 UTC (permalink / raw)
  To: john.stultz, shuah; +Cc: linux-kselftest, Xiao Yang, kernel test robot

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
---
 tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
index ec47901ef2e2..5e3eeec299b2 100644
--- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
+++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
@@ -154,7 +154,7 @@ static int do_test(char *heap_name)
 	int heap_fd = -1, dmabuf_fd = -1, importer_fd = -1;
 	uint32_t handle = 0;
 	void *p = NULL;
-	unsigned long long features;
+	unsigned long long features = 0;
 	int ret;
 
 	printf("Testing heap: %s\n", heap_name);
-- 
2.21.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmabuf-heaps/dmabuf-heap.c: Initialize features variable to avoid compiler warning
  2019-11-05  9:40 [PATCH] dmabuf-heaps/dmabuf-heap.c: Initialize features variable to avoid compiler warning Xiao Yang
@ 2019-11-07 20:30 ` shuah
  2019-11-07 20:38   ` John Stultz
  0 siblings, 1 reply; 3+ messages in thread
From: shuah @ 2019-11-07 20:30 UTC (permalink / raw)
  To: Xiao Yang, john.stultz; +Cc: linux-kselftest, kernel test robot, shuah

On 11/5/19 2:40 AM, Xiao Yang wrote:
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>

Missing commit log. Please add one to show the compiler warn you are
fixing.

> ---
>   tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
> index ec47901ef2e2..5e3eeec299b2 100644
> --- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
> +++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
> @@ -154,7 +154,7 @@ static int do_test(char *heap_name)
>   	int heap_fd = -1, dmabuf_fd = -1, importer_fd = -1;
>   	uint32_t handle = 0;
>   	void *p = NULL;
> -	unsigned long long features;
> +	unsigned long long features = 0;
>   	int ret;
>   
>   	printf("Testing heap: %s\n", heap_name);
> 

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmabuf-heaps/dmabuf-heap.c: Initialize features variable to avoid compiler warning
  2019-11-07 20:30 ` shuah
@ 2019-11-07 20:38   ` John Stultz
  0 siblings, 0 replies; 3+ messages in thread
From: John Stultz @ 2019-11-07 20:38 UTC (permalink / raw)
  To: shuah; +Cc: Xiao Yang, linux-kselftest, kernel test robot

On Thu, Nov 7, 2019 at 12:30 PM shuah <shuah@kernel.org> wrote:
> On 11/5/19 2:40 AM, Xiao Yang wrote:
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
>
> Missing commit log. Please add one to show the compiler warn you are
> fixing.

Shuah's feedback is good advice for future patches, but I wanted to
clarify that I've dropped the affected code, so there's no reason to
respin this patch.

thanks
-john

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-07 20:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05  9:40 [PATCH] dmabuf-heaps/dmabuf-heap.c: Initialize features variable to avoid compiler warning Xiao Yang
2019-11-07 20:30 ` shuah
2019-11-07 20:38   ` John Stultz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).